Page MenuHomePhabricator

Cannot select first letter (bracket) of edit summary due to being a pseudo element in CSS
Open, Needs TriagePublic

Description

Steps to reproduce

  1. Go in history of same page
  2. Try to select edit summary

If you select it with first letter of edit summary, you can't select it. If you select edit summary without first letter of it, selecting works. Selecting should works completly.

[ORIGINAL REPORT]
Good afternoon.

I have noticed a glitch that happens when I want to select the edit summary and copy it. It is not possible to select the first letter of it with the cursor from the left, but when is the first letter chosen from the right with another text, the page completely crashes. This happens everywhere with the edit summary (in user contributions, recent changes, page history...), and on all of Wikipedia projects (I tried English, Croatian, Hungarian and Czech Wikipedia, English Wiktionary, Wikimedia Commons). But it happens only on MediaWiki projects. On other sites, such as Wikia, the summary selection works completely normal.

Event Timeline

Kizule subscribed.

Hi @Moson81 and welcome to Phabricator! You assigned this task to you, do you really want to fix in code this problem?

I do not know how to fix it. I ask if it's possible to fix this problem.

Hmm, yes. I can reproduce this. When user want to select edit summary, if he select first letter it can't select nothing in summary. If he select second letter everything is ok but first letter is still unselectable.

Aklapper changed the task status from Open to Stalled.EditedSep 1 2019, 12:50 PM

Hi, thanks for taking the time to report this and welcome!
Please see https://www.mediawiki.org/wiki/How_to_report_a_bug and provide a complete list of steps to reproduce the problem (step by step, as a list of steps), including links and browser information and browser version information.
You can edit the task description by clicking Edit Task.
Ideally, exact and clear steps to reproduce should allow any other person to follow these steps (without having to interpret those steps) and see the same results. Problems that others can reliably reproduce can get fixed faster. Thanks!

Kizule renamed this task from Wikipedia page crashes in error after first letter of an edit summary is selected to First letter of an edit summary can't be selected.Sep 1 2019, 2:23 PM
Kizule changed the task status from Stalled to Open.
Kizule updated the task description. (Show Details)

Thanks for the clarification.

From Firefox 68 on https://cs.wikipedia.org/w/index.php?title=Galerie_Rudolfinum&action=history (please always provide links!):

T231746.jpg (224×1 px, 115 KB)

This happens because the brackets are pseudo elements in CSS. See for example https://github.com/w3c/csswg-drafts/issues/2894

Aklapper renamed this task from First letter of an edit summary can't be selected to Cannot select first letter (bracket) of edit summary due to being a pseudo element in CSS.Sep 1 2019, 8:00 PM
Aklapper added a project: Design.
Aklapper edited projects, added CSS; removed Design.

i am interested in solving this bug please help me to do dso

Hi @AdarshTiwari11, thanks for your interest and welcome to Wikimedia Phabricator! Do you have a specific question?

i have just did environment setup , can you say what should be my first step to start this process

Generally speaking (which is off-topic here, see the link I had posted): Reproducing the problem, investigating it, finding the related code, writing a fix, verifying that the fix does what it should, putting the fix up for review in Gerrit. Basically. :) See also https://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_hacker - thanks!