Page MenuHomePhabricator

Depicts selector too big
Open, MediumPublic

Description

Currently the Depicts selector frequently covers up the metadata on both mobile and web, making it hard to, for example, type names of depicted individuals in the categories and/or the description from commons. Is there a way to make it less tall for each of the suggested items?

Event Timeline

Yes well spotted. We actually have other issues with the library we're using for the search dropdown, so the plan was to switch to a different library which has much reduced space taken up apart from other things.
We'll make sure the new library we choose addresses this along with the other issues.

I checked the library repo at https://github.com/select2/select2. The best possible fix seems to be changing
var enoughRoomAbove = viewport.top < (offset.top - dropdown.height); to var enoughRoomAbove = false; , if we want the dropdown to be below always.
The library still doesn't provide an option to set the above and below behavior by user.
specific file can be seen at https://github.com/select2/select2/blob/develop/src/js/select2/dropdown/attachBody.js (line 176).
I have already tested this and it works great on mobile and desktop views.
Should I create a patch ? Thanks.

@Sanyam.wikime you can always submit a patch as the task is open for discussions.

NavinoEvans moved this task from Backlog to Incoming Bugs on the ISA board.

Change 579607 had a related patch set uploaded (by Sanyam.wikime; owner: Sanyam.wikime):
[labs/tools/Isa@master] Fixed : Depicts selector too big

https://gerrit.wikimedia.org/r/579607

Aklapper subscribed.

Removing task assignee due to inactivity as this open task has been assigned for more than two years. See the email sent to the task assignee on August 22nd, 2022.
Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be welcome!
If this task has been resolved in the meantime, or should not be worked on ("declined"), please update its task status via "Add Action… 🡒 Change Status".
Also see https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator. Thanks!

Change 579607 abandoned by Eugene233:

[labs/tools/Isa@master] Fixed : Depicts selector too big

Reason:

PS not worked on for a while.

https://gerrit.wikimedia.org/r/579607