Page MenuHomePhabricator

Repeated errors while undeleting a file
Closed, DuplicatePublic

Description

Following from https://commons.wikimedia.org/w/index.php?title=User_talk:Martin_Urbanec&oldid=364071280#Copyright_status:_File:%E0%A4%B6%E0%A4%BF%E0%A4%B2%E0%A5%8D%E0%A4%AA%E0%A4%95%E0%A4%BE%E0%A4%B0_%E0%A4%9A%E0%A4%B0%E0%A4%BF%E0%A4%A4%E0%A5%8D%E0%A4%B0%E0%A4%95%E0%A5%8B%E0%A4%B6_%E0%A4%96%E0%A4%82%E0%A4%A1_%E0%A5%A8_-_%E0%A4%B8%E0%A4%BE%E0%A4%B9%E0%A4%BF%E0%A4%A4%E0%A5%8D%E0%A4%AF.pdf I am trying to merge it with https://commons.wikimedia.org/wiki/File:%E0%A4%B6%E0%A4%BF%E0%A4%B2%E0%A5%8D%E0%A4%AA%E0%A4%95%E0%A4%BE%E0%A4%B0_%E0%A4%9A%E0%A4%B0%E0%A4%BF%E0%A4%A4%E0%A5%8D%E0%A4%B0%E0%A4%95%E0%A5%8B%E0%A4%B6_%E0%A4%96%E0%A4%82%E0%A4%A1_%E0%A5%A8_%E2%80%93_%E0%A4%B8%E0%A4%BE%E0%A4%B9%E0%A4%BF%E0%A4%A4%E0%A5%8D%E0%A4%AF.pdf
but I get repeated errors while trying to undelete the file after move.

First I got

Could not acquire lock for "mwstore://local-multiwrite/local-public/8/84/शिल्पकार_चरित्रकोश_खंड_२_–_साहित्य.pdf".

then

MediaWiki internal error.

Original exception: [XWwIjgpAICgAAI1nf8IAAABD] 2019-09-01 18:06:08: Fatal exception of type "Wikibase\DataModel\Services\Lookup\EntityLookupException"

Exception caught inside exception handler.

Set $wgShowExceptionDetails = true; at the bottom of LocalSettings.php to show detailed debugging information.

Event Timeline

Kizule added a subscriber: Kizule.

@Urbanecm Oh, this is really weird. We get similar reports. Did I add the correct tags?

MediaWiki internal error.

Original exception: [XWwLHwpAAD8AAC1WrNIAAACN] 2019-09-01 18:17:03: Fatal exception of type "Wikibase\DataModel\Services\Lookup\EntityLookupException"

Exception caught inside exception handler.

Set $wgShowExceptionDetails = true; at the bottom of LocalSettings.php to show detailed debugging information.

Posting tracebacks from logstash for posterity, this is T231276 basically. This one is for XWwIjgpAICgAAI1nf8IAAABD, but XWwLHwpAAD8AAC1WrNIAAACN

Message
Revision 364082930 belongs to M80917176 instead of expected M81753439
Traceback
#0 /srv/mediawiki/php-1.34.0-wmf.20/extensions/Wikibase/data-access/src/ByTypeDispatchingEntityRevisionLookup.php(54): Wikibase\Lib\Store\Sql\WikiPageEntityRevisionLookup->getEntityRevision(Wikibase\MediaInfo\DataModel\MediaInfoId, integer, string)
#1 /srv/mediawiki/php-1.34.0-wmf.20/extensions/Wikibase/lib/includes/Store/TypeDispatchingEntityRevisionLookup.php(55): Wikibase\DataAccess\ByTypeDispatchingEntityRevisionLookup->getEntityRevision(Wikibase\MediaInfo\DataModel\MediaInfoId, integer, string)
#2 /srv/mediawiki/php-1.34.0-wmf.20/extensions/Wikibase/lib/includes/Store/CachingEntityRevisionLookup.php(104): Wikibase\Lib\Store\TypeDispatchingEntityRevisionLookup->getEntityRevision(Wikibase\MediaInfo\DataModel\MediaInfoId, integer, string)
#3 /srv/mediawiki/php-1.34.0-wmf.20/extensions/Wikibase/lib/includes/Store/CachingEntityRevisionLookup.php(87): Wikibase\Lib\Store\CachingEntityRevisionLookup->fetchEntityRevision(Wikibase\MediaInfo\DataModel\MediaInfoId, integer, string)
#4 /srv/mediawiki/php-1.34.0-wmf.20/extensions/Wikibase/lib/includes/Store/CachingEntityRevisionLookup.php(104): Wikibase\Lib\Store\CachingEntityRevisionLookup->getEntityRevision(Wikibase\MediaInfo\DataModel\MediaInfoId, integer, string)
#5 /srv/mediawiki/php-1.34.0-wmf.20/extensions/Wikibase/lib/includes/Store/CachingEntityRevisionLookup.php(87): Wikibase\Lib\Store\CachingEntityRevisionLookup->fetchEntityRevision(Wikibase\MediaInfo\DataModel\MediaInfoId, integer, string)
#6 /srv/mediawiki/php-1.34.0-wmf.20/extensions/Wikibase/lib/includes/Store/RevisionBasedEntityLookup.php(39): Wikibase\Lib\Store\CachingEntityRevisionLookup->getEntityRevision(Wikibase\MediaInfo\DataModel\MediaInfoId)
#7 /srv/mediawiki/php-1.34.0-wmf.20/vendor/wikibase/data-model-services/src/Lookup/RedirectResolvingEntityLookup.php(51): Wikibase\Lib\Store\RevisionBasedEntityLookup->getEntity(Wikibase\MediaInfo\DataModel\MediaInfoId)
#8 /srv/mediawiki/php-1.34.0-wmf.20/extensions/WikibaseMediaInfo/src/WikibaseMediaInfoHooks.php(287): Wikibase\DataModel\Services\Lookup\RedirectResolvingEntityLookup->getEntity(Wikibase\MediaInfo\DataModel\MediaInfoId)
#9 /srv/mediawiki/php-1.34.0-wmf.20/extensions/WikibaseMediaInfo/src/WikibaseMediaInfoHooks.php(250): Wikibase\MediaInfo\WikibaseMediaInfoHooks->doBeforePageDisplay(OutputPage, boolean, array, Wikibase\Repo\BabelUserLanguageLookup, Wikibase\Repo\ParserOutput\DispatchingEntityViewFactory, array)
#10 /srv/mediawiki/php-1.34.0-wmf.20/includes/Hooks.php(174): Wikibase\MediaInfo\WikibaseMediaInfoHooks::onBeforePageDisplay(OutputPage, SkinVector)
#11 /srv/mediawiki/php-1.34.0-wmf.20/includes/Hooks.php(234): Hooks::callHook(string, array, array, NULL, string)
#12 /srv/mediawiki/php-1.34.0-wmf.20/includes/OutputPage.php(2588): Hooks::runWithoutAbort(string, array)
#13 /srv/mediawiki/php-1.34.0-wmf.20/includes/MediaWiki.php(899): OutputPage->output(boolean)
#14 /srv/mediawiki/php-1.34.0-wmf.20/includes/MediaWiki.php(911): Closure$MediaWiki::main()
#15 /srv/mediawiki/php-1.34.0-wmf.20/includes/MediaWiki.php(523): MediaWiki->main()
#16 /srv/mediawiki/php-1.34.0-wmf.20/index.php(42): MediaWiki->run()
#17 /srv/mediawiki/w/index.php(3): include(string)
#18 {main}

Closing as dupe of T231276. I appreciate creating anyway, it's next to impossible for you to actually realize this is a dupe, and you can't be expected to anyway.

PS: Could not acquire lock for is a temporary one, or at least looks so. It basically means MW wasn't able to lock a file for some reason. Certainly different than the quoted traceback, which is clearly T231276, through, so if that happens too frequently, please create a different report and tag me, I'll do my best to look into that.

In T231757#5457322, @Zoranzoki21 wrote:

@Urbanecm Oh, this is really weird. We get similar reports. Did I add the correct tags?

They make sense as an initial tagging. As a rule of thumb, it's generally not useful to tag SRE, given althrough all SREs (site reliability engineer) can query Logstash, pretty much anyone with valid NDA can do so (see https://tools.wmflabs.org/ldap/group/wmf and https://tools.wmflabs.org/ldap/group/nda for group of staff and volunteeers having that ability). As such, it's usually wise to add only code-specific tags, and add SRE only when you're 90 % sure that only SREs can help. Case for a pretty limited subset of issues, and the majority, if not all, of logs, should be logged into Logstash. Due to their various degree of confidentiality, being able to enter Logstash needs an NDA. In the future, I'd appreciate you tagging with eg. only MediaWiki-File-management (althrough that's in fact only remotely related). If you want to be exteremely helpful, look for messages looking like Fatal exception of type "Wikibase\DataModel\Services\Lookup\EntityLookupException". That suggest the issue is somewhere inside Wikibase, a reason to tag WikibaseMediaInfo and Wikidata, to get the attention of relevant developpers. Wikimedia-production-error is obviously correct as well. It is a tag for any errors, exceptions and the like, being experienced at Wikimedia production. https://phabricator.wikimedia.org/maniphest/task/edit/form/46/ is a good source of information of what to include in a production report, and you can make sure everything mentioned is in the description. It is here, and it is easy for me to query Logstash and post the traceback, which is the core purpose of that guidelines anyway.

Also, it's not weird, but indication of urgency :-).