Page MenuHomePhabricator

[Regression] Move Flow boards is not possible for an admin
Open, Needs TriagePublicBUG REPORT

Description

@Huji reports that he can't move a Flow board. He is an admin, and admins are supposed to be able to rename/move Flow boards.

Event Timeline

Restricted Application added a project: Growth-Team. · View Herald TranscriptSep 2 2019, 7:54 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Bugreporter renamed this task from Move Flow boards is not possible for an admin to Allow some specific users to move Flow boards even if they can not create one.Sep 3 2019, 6:22 AM
Bugreporter added a subscriber: Bugreporter.

Only user who can create flow boards can move them. In wikis where Flow is not widely in use, only stewards can do it.

It used to be possible by admins since September 2017.

This ticket is regression, not a request to provide a new feature to a given role.

Trizek-WMF renamed this task from Allow some specific users to move Flow boards even if they can not create one to [Regression] Move Flow boards is not possible for an admin.Sep 3 2019, 9:51 AM
kostajh moved this task from Inbox to Upcoming Work on the Growth-Team board.Sep 3 2019, 10:56 AM
kostajh changed the subtype of this task from "Task" to "Bug Report".
kostajh added a subscriber: kostajh.

Sounds like should deal with this sooner rather than later.

Huji added a comment.Sep 3 2019, 1:12 PM

This is the part of code that prevented me from moving that flow board. It checks to see if I have the flow-create-board right (which I do not) and I cannot find any way this can be circumvented, as is, outside of giving flow-create-board right to admins (which, I'm not sure is desired or not). The reason I think so is because this permission is checked every time Hooks::onMovePageCheckPermissions() is called, which is literally on every page move.

Bugreporter added a comment.EditedSep 3 2019, 1:46 PM

It used to be possible by admins since September 2017.

This only says "Sysops on wikis that have Structured Discussions as a Beta Feature have the right to create, move and delete Structured Discussions boards." fawiki is not one. Only stewards can create (or move) flow board.

@Trizek-WMF @MMiller_WMF do you have any guidance on what you'd like to have done for this task?

Per T175934 (specifically T175934#3609401) in September 2017 @Catrope deployed code that allowed sysops to move boards on wikis where Flow is a beta feature or where Flow occupies an entire namespace. As @Bugreporter notes above, Flow is not a beta feature on fawiki, nor does it occupy an entire namespace, so whether or not @Huji is a sysop won't make a difference to this particular problem.

Various solutions:

  1. The original request on meta is to archive the flow board and convert to wikitext, then create a redirect. Me, @Tgr or @Catrope could do this manually via a maintenance script on the server.
  2. We could add fawiki to list of wikis where Flow is available as a beta feature, and @Huji could ask a sysop on fawiki to move the board. Probably not a great idea given that we'd end up with a few more Flow boards created by users and we're trying to avoid more Flow deployments at least until Talk Pages project is farther along.
  3. We could deploy configuration granting administrators the flow-create-board right. I'm unsure of the implications of that, though, given that it wasn't done back in 2017, maybe @Catrope has more context about the reasons for that.

My vote would be to do option 1 as a one-off.

@kostajh -- it sounds like you're saying that this issue isn't really a bug -- it's an edge case that is annoying for users of fawiki who have a particular set of configurations. And you're recommending that we just fix this one Flow board? Is that because we don't expect this situation to happen more often?

@Trizek-WMF -- what do you think?

@Trizek-WMF -- what do you think?

I would go for #3.

We can't go for #2, since all deployment are stopped, nor #1 because this is not the request.

I'm confused, why isn't option #1 a valid response to the request? The request on wiki says:

Based on this consensus on fawiki we want to archive fa:ویکی‌پدیا:پرسش‌های متفرقه (which is a flow board), then convert its content type to wikitext and make a redirect to fa:ویکی‌پدیا:درخواست راهنمایی.

Sorry if I misread the comments. #1 is then possible if it is for archiving.

@kostajh -- to make sure I understand, are you saying that this issue isn't really a bug -- it's an edge case that is annoying for users of fawiki who have a particular set of configurations. And you're recommending that we just fix this one Flow board? Is that because we don't expect this situation to happen more often?

to make sure I understand, are you saying that this issue isn't really a bug -- it's an edge case that is annoying for users of fawiki who have a particular set of configurations.

Mostly yes -- it's not per-user configuration, but rather how fawiki was configured to use Flow.

And you're recommending that we just fix this one Flow board? Is that because we don't expect this situation to happen more often?

Yes, and hopefully yes :)

@kostajh -- sounds good, we can do the one-off solution when we have a moment in the coming couple weeks.

De-prioritizing off the sprint board in favor of other priorities.