Page MenuHomePhabricator
Create Task
Maniphest T231786

Error trying to enable 2FA on testwiki: "Call to a member function getSecret() on a non-object (array)"
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Get the following internal error on trying to enable 2FA (via Special:OATH) on Test Wikipedia.

[XWzSlgpAMFgAAJHPyUAAAABG] /w/index.php?title=Special:Manage_Two-factor_authentication&action=enable&module=totp BadMethodCallException from line 36 of /srv/mediawiki/php-1.34.0-wmf.20/extensions/OATHAuth/src/HTMLForm/TOTPEnableForm.php: Call to a member function getSecret() on a non-object (array)

Backtrace:

#0 /srv/mediawiki/php-1.34.0-wmf.20/extensions/OATHAuth/src/HTMLForm/OATHAuthOOUIHTMLForm.php(44): MediaWiki\Extension\OATHAuth\HTMLForm\TOTPEnableForm->getDescriptors()
#1 /srv/mediawiki/php-1.34.0-wmf.20/extensions/OATHAuth/src/Module/TOTP.php(112): MediaWiki\Extension\OATHAuth\HTMLForm\OATHAuthOOUIHTMLForm->__construct(MediaWiki\Extension\OATHAuth\OATHUser, MediaWiki\Extension\OATHAuth\OATHUserRepository, MediaWiki\Extension\OATHAuth\Module\TOTP)
#2 /srv/mediawiki/php-1.34.0-wmf.20/extensions/OATHAuth/src/Special/OATHManage.php(207): MediaWiki\Extension\OATHAuth\Module\TOTP->getManageForm(string, MediaWiki\Extension\OATHAuth\OATHUser, MediaWiki\Extension\OATHAuth\OATHUserRepository)
#3 /srv/mediawiki/php-1.34.0-wmf.20/extensions/OATHAuth/src/Special/OATHManage.php(169): MediaWiki\Extension\OATHAuth\Special\OATHManage->addModuleCustomForm(MediaWiki\Extension\OATHAuth\Module\TOTP, boolean)
#4 /srv/mediawiki/php-1.34.0-wmf.20/extensions/OATHAuth/src/Special/OATHManage.php(154): MediaWiki\Extension\OATHAuth\Special\OATHManage->addModule(MediaWiki\Extension\OATHAuth\Module\TOTP, boolean)
#5 /srv/mediawiki/php-1.34.0-wmf.20/extensions/OATHAuth/src/Special/OATHManage.php(98): MediaWiki\Extension\OATHAuth\Special\OATHManage->addNotEnabledModules()
#6 /srv/mediawiki/php-1.34.0-wmf.20/includes/specialpage/SpecialPage.php(573): MediaWiki\Extension\OATHAuth\Special\OATHManage->execute(NULL)
#7 /srv/mediawiki/php-1.34.0-wmf.20/includes/specialpage/SpecialPageFactory.php(582): SpecialPage->run(NULL)
#8 /srv/mediawiki/php-1.34.0-wmf.20/includes/MediaWiki.php(296): MediaWiki\Special\SpecialPageFactory->executePath(Title, RequestContext)
#9 /srv/mediawiki/php-1.34.0-wmf.20/includes/MediaWiki.php(892): MediaWiki->performRequest()
#10 /srv/mediawiki/php-1.34.0-wmf.20/includes/MediaWiki.php(523): MediaWiki->main()
#11 /srv/mediawiki/php-1.34.0-wmf.20/index.php(42): MediaWiki->run()
#12 /srv/mediawiki/w/index.php(3): include(string)
#13 {main}

Details

SubjectRepoBranchLines +/-
Make sure key is of correct type before running operations on itmediawiki/extensions/OATHAuthmaster+3 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

SD0001 created this task.Sep 2 2019, 8:31 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 2 2019, 8:31 AM
Aklapper renamed this task from Internal error on trying to enable 2FA on testwiki to Error trying to enable 2FA on testwiki: "Call to a member function getSecret() on a non-object (array)".Sep 2 2019, 9:01 AM
Aklapper edited projects, added MediaWiki-extensions-OATHAuth; removed Core Platform Team Initiatives (Two-Factor Authentication (TEC1)).
JJMC89 added a project: Wikimedia-production-error.Sep 2 2019, 9:22 AM
JJMC89 changed the subtype of this task from "Task" to "Production Error".
Reedy added subscribers: ItSpiderman, Osnard.Sep 2 2019, 3:56 PM
Reedy added a parent task: T218214: SO878 Step 3: Finalize settings and user experience.Sep 3 2019, 11:15 AM
Reedy subscribed.Sep 4 2019, 11:04 AM

@ItSpiderman @Osnard Can one of you look at this?

gerritbot added a comment.Sep 4 2019, 11:16 AM

Change 534415 had a related patch set uploaded (by ItSpiderman; owner: ItSpiderman):
[mediawiki/extensions/OATHAuth@master] Make sure key is of correct type before running operations on it

https://gerrit.wikimedia.org/r/534415

gerritbot added a project: Patch-For-Review.Sep 4 2019, 11:16 AM
ItSpiderman added a comment.Sep 4 2019, 11:17 AM

This should do it. Make sure type is actually what we expect, and not just "not null"

gerritbot added a comment.Sep 4 2019, 12:35 PM

Change 534415 merged by jenkins-bot:
[mediawiki/extensions/OATHAuth@master] Make sure key is of correct type before running operations on it

https://gerrit.wikimedia.org/r/534415

Reedy closed this task as Resolved.Sep 4 2019, 12:46 PM
Reedy claimed this task.
Reedy reassigned this task from Reedy to ItSpiderman.
Reedy removed a project: Patch-For-Review.
ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.22; 2019-09-10).Sep 4 2019, 1:01 PM
Reedy mentioned this in T233146: Cannot enable 2FA on testwiki.Sep 17 2019, 10:21 PM
Reedy mentioned this in T222099: Staging release of RESTBagOStuff using Kask.Sep 18 2019, 8:36 PM
SD0001 reopened this task as Open.Oct 5 2019, 10:50 AM

@Reedy, @ItSpiderman can you look into this again, please. While no internal error appears now, I am still unable to to enable 2FA: the message "Failed to validate two-factor credentials" comes up every time. I have tried using both Google Authenticator as well as 2FA Authenticator apps.

Reedy closed this task as Resolved.Oct 5 2019, 12:48 PM
In T231786#5548936, @SD0001 wrote:

@Reedy, @ItSpiderman can you look into this again, please. While no internal error appears now, I am still unable to to enable 2FA: the message "Failed to validate two-factor credentials" comes up every time. I have tried using both Google Authenticator as well as 2FA Authenticator apps.

Yes, we know, that's T233146. It's actually a bigger issue

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits