Page MenuHomePhabricator
Create Task
Maniphest T231796

502 Bad Gateway error in wikiloves images view when passing a user
Closed, ResolvedPublic
Actions

Description

In Wiki Loves Monuments, click on any number in the 'Uploaders' column, then on any number in the 'Images' column. Result is 502 Bad Gateway.

Related Objects

Event Timeline

MichaelMaggs created this task.Sep 2 2019, 10:20 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 2 2019, 10:20 AM
MichaelMaggs updated the task description. (Show Details)Sep 2 2019, 10:23 AM
JeanFred added a comment.Sep 2 2019, 10:38 AM

Thanks for reporting this and giving reproduction steps.

However I can’t reproduce: on https://tools.wmflabs.org/wikiloves/monuments/2019, I can click through to https://tools.wmflabs.org/wikiloves/monuments/2019/Germany/users, https://tools.wmflabs.org/wikiloves/monuments/2019/Russia/users, https://tools.wmflabs.org/wikiloves/monuments/2019/Italy/users, etc.

Same thing on https://tools.wmflabs.org/wikiloves/monuments

@MichaelMaggs Can you please provide the URLs that 502s?

JeanFred added a comment.Sep 2 2019, 10:39 AM

Ah, my bad, I got confused with the steps. The images view does indeed 502.

JeanFred added a comment.Sep 2 2019, 10:41 AM

The images view 502s when providing a username parameter:
https://tools.wmflabs.org/wikiloves/images?event=monuments&year=2019&country=Russia&user=Olga-lisenkova

But without it’s fine
https://tools.wmflabs.org/wikiloves/images?event=monuments&year=2019&country=Russia

Lokal_Profil added subscribers: • AxelPettersson_WMSE, Lokal_Profil.Sep 9 2019, 1:01 PM

Am I missing something obvious or should img_user_text = ? be img_user_text = %s in images.py#L16?

JeanFred renamed this task from 502 Bad Gateway error in WLM to 502 Bad Gateway error in wikiloves images view when passing a user.Sep 18 2019, 8:04 AM
JeanFred merged a task: T233177: Wikiloves tool fails to display images uploaded by a given user.
JeanFred added subscribers: Atsirlin, JeanFred.
Chicocvenancio subscribed.Jan 22 2020, 2:52 AM
Aklapper removed JeanFred as the assignee of this task.Mar 13 2022, 7:44 PM

Removing task assignee due to inactivity, as this open task has been assigned for more than two years. See the email sent to the task assignee on February 06th 2022 (and T295729).

Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be welcome.

If this task has been resolved in the meantime, or should not be worked on ("declined"), please update its task status via "Add Action… 🡒 Change Status".

Also see https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator.

JeanFred merged a task: T316917: 502 error on visiting the user subpage of a competition.Sep 18 2023, 4:07 PM
Stashbot added a comment.Sep 18 2023, 4:11 PM

Mentioned in SAL (#wikimedia-cloud) [2023-09-18T16:11:13Z] <wm-bot> <jeanfred> Deploy ea0a61c and dedd577 (T231796)

JeanFred closed this task as Resolved.Sep 18 2023, 4:12 PM
JeanFred claimed this task.

Four years later, finally took the time to look into it properly :)

In T231796#5474911, @Lokal_Profil wrote:

Am I missing something obvious or should img_user_text = ? be img_user_text = %s in images.py#L16?

Yes indeed, that was the first problem, the syntax was never updated for pymysql.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits