Page MenuHomePhabricator

tool-quickstatements V2 batch mode: "Qualifier to" not more working
Open, Needs TriagePublic

Description

Hi Magnus, in the tool quickstatements V2 in the batch mode "Qualifier to" is not more working. It works in V1 and in in the screen mode of V2. My last succesful batch was batch #16777 (4 August 2019). After this I did not used this qualifier until 31 August 2019. First problems were reported 22 August 2019. ~~~~

Event Timeline

Aklapper added a project: Tools.

Hi @Florentyna, thanks for taking the time to report this and welcome to Wikimedia Phabricator!

This tool does not seem to use Wikimedia Phabricator to track its bug reports.
According to https://www.wikidata.org/wiki/Help:QuickStatements#FAQ , please report this problem to https://bitbucket.org/magnusmanske/wikidata-todo instead. I'm closing this task as invalid here as per https://phabricator.wikimedia.org/tag/tools/ : "Please check first if there is a sub-project, talkpage, or another dedicated place to file bug reports, so you will get the attention of their developers."

Actually, that bitbucket repo is for the _really old version_ (pre-1.0).

The repo for V2 (at https://tools.wmflabs.org/quickstatements/ ) is here: https://phabricator.wikimedia.org/source/tool-quickstatements/

Which makes phabricator the place to be.

@Florentyna it seems to work for me right now. I have restarted your batch https://tools.wmflabs.org/quickstatements/#/batch/17975 and it ran successfully. Can you try another, new one and let me know if it works?

Hi Magnus, thanks a lot for opening this again. You can't use the old batches for testing - all of them I corrected in the screen mode. I now created some new batches and will attach here some more lines for testing. Batches #18012 to #18015 you can use for testing of existing batches. Some more unused lines follow. A mistake can happen, if a team participated twice with a second team in the same championship like HM Petőfi or XIII. ker. Tanács SK. This I will correct manually.
Thanks a lot again.

Q67102838 P1344 Q2493264 P1352 7 S143 Q48183
Q67101443 P1344 Q2493268 P1352 1 S143 Q48183
Q67102822 P1344 Q2493268 P1352 2 S143 Q48183
Q67102753 P1344 Q2493268 P1352 3 S143 Q48183
Q67102792 P1344 Q2493268 P1352 4 S143 Q48183
Q67102838 P1344 Q2493268 P1352 5 S143 Q48183
Q67102919 P1344 Q2493268 P1352 6 S143 Q48183

I believe I fixed the issue in the Rust bot. I had a successful test, but please try it yourself.

For documentation, the cause of the issue was that I switched an underlying Rust crate (wikibase_rs) to use [[Special:EntityData]] for retrieving single items, rather than the API
wbgetentity action (which I still use to get multiple items at once). However, it appears that [[Special:EntityData]] is cached (server-side?). So when Quicktatements adds a statement, reloads the item, and then tries to add a reference or qualifier to that new statement, the statement will not be there, as the cache lags behind the edit that just happened.

The "solution" is to add a random number ?12345 to the [[Special:EntityData]] URL, to force-reload the current state. Ugly, but seems to work.

Special:EntityData also supports the revision parameter - you could use the one you received in the response (lastrevid) of your save request (wbsetclaim or comparable).

Yes, looks good now. Thank you very much. BTW: One can not find this tool here as tag when adding a bug/request. "tool-quickstatements" or simply "quickstatements" is not listed in the tag browsing field below this textbox. That's why Aklapper rejected this task here as invalid.

Actually, that bitbucket repo is for the _really old version_ (pre-1.0).

The repo for V2 (at https://tools.wmflabs.org/quickstatements/ ) is here: https://phabricator.wikimedia.org/source/tool-quickstatements/

Which makes phabricator the place to be.

Side note: I’ve updated the FAQ accordingly, though it would probably be better to have a dedicated tag for QuickStatements issues (for now, the link adds Tools and subscribes @Magnus).

Aklapper added a subscriber: Magnus.

Removing task assignee due to inactivity, as this open task has been assigned for more than two years. See the email sent to the task assignee on February 06th 2022 (and T295729).

Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be welcome.

If this task has been resolved in the meantime, or should not be worked on ("declined"), please update its task status via "Add Action… 🡒 Change Status".

Also see https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator.