The team tried to do a quick backport and it appears it did not work, for that reason I am moving this to the freezer.

For the tests to pass, we would need to at least backport https://gerrit.wikimedia.org/r/c/VisualEditor/VisualEditor/+/468960 to REL1_31. Note that this is in the VE/VE repo and it doesn't even have that branch – so we'd need to create it, backport, then manually bump the submodule in mw/ext/VE repo. And then see if anything else is failing.

We could also just force-merge the change and ignore the failing tests. @Osnard Are you sure that code works correctly on REL1_31?

@matmarex I am pretty sure that it works, as we use REL1_31 of VisualEditor in our current BlueSpice 3.1 Release. But I have to admit, that I didn't test it in a plain "MediaWiki-Core + VisualEditor" setup. Just as part of the whole BlueSpice distribution. We have already "backported" this to our "BlueSpiceVisualEditorConnector" extension [1]. BlueSpice is always build with REL1_31 of MW Core and all extensions. I will ask one of my coworkers (@Intracomof, how about you?) to test it in a plain "MediaWiki-Core + VisualEditor" setup, though.

[1] https://github.com/wikimedia/mediawiki-extensions-BlueSpiceVisualEditorConnector/blob/REL1_31/resources/ve/dm/bs.dm.InternalMediaLinkAnnotation.js

Well, I don't see why it wouldn't work in that case, so let's just do it. Or at least let's see if I have permissions to merge it despite the failing build.