Maniphest T231968

Wikibase OutputPageBeforeHTMLHookHandlerTest::testOutputPageBeforeHTMLHookHandler failing on Travis CI
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	WMDE-leszek
	Sep 4 2019, 8:23 AM

Description

Build turned red on https://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/580466080

Tests failures happen when the wiki language is other than English, see e.g. https://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/jobs/580466081

There was 1 failure:

1) Wikibase\Repo\Tests\Hooks\OutputPageBeforeHTMLHookHandlerTest::testOutputPageBeforeHTMLHookHandler

=== Logs generated by test case

[wfDebug] [debug] IP: 127.0.0.1 {"private":false}

===

Expectation failed for method name is equal to 'getLanguages' when invoked 1 time(s)

Parameter 0 for invocation Wikibase\Repo\Hooks\Helpers\UserPreferredContentLanguagesLookup::getLanguages('ru', User Object (...)) does not match expected value.

Failed asserting that two strings are equal.

--- Expected

+++ Actual

@@ @@

-'en'

+'ru'

/home/travis/build/wikimedia/phase3/extensions/Wikibase/repo/includes/Hooks/OutputPageBeforeHTMLHookHandler.php:277

/home/travis/build/wikimedia/phase3/extensions/Wikibase/repo/includes/Hooks/OutputPageBeforeHTMLHookHandler.php:256

/home/travis/build/wikimedia/phase3/extensions/Wikibase/repo/includes/Hooks/OutputPageBeforeHTMLHookHandler.php:199

/home/travis/build/wikimedia/phase3/extensions/Wikibase/repo/includes/Hooks/OutputPageBeforeHTMLHookHandler.php:175

/home/travis/build/wikimedia/phase3/extensions/Wikibase/repo/tests/phpunit/includes/Hooks/OutputPageBeforeHTMLHookHandlerTest.php:142

/home/travis/build/wikimedia/phase3/maintenance/doMaintenance.php:99

The test was introduced in https://gerrit.wikimedia.org/r/531938, made for T227083

Details

	Subject	Repo	Branch	Lines +/-
	OutputPageBeforeHtmlHookHandlerTest mock RequestContext	mediawiki/extensions/Wikibase	master	+8 -4

Customize query in gerrit

Related Objects

Mentioned Here: T227083: Termbox should hide non-supported languages

Event Timeline

WMDE-leszek created this task.Sep 4 2019, 8:23 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 4 2019, 8:23 AM

Looks like this is because the tests create a real OutputPage object who's language is derived from the RequestContext.

Two

Change 534411 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[mediawiki/extensions/Wikibase@master] OutputPageBeforeHtmlHookHandlerTest mock RequestContext

https://gerrit.wikimedia.org/r/534411

gerritbot added a project: Patch-For-Review.Sep 4 2019, 10:57 AM

Tarrow moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Sep 4 2019, 10:57 AM

• Pablo-WMDE triaged this task as High priority.Sep 5 2019, 9:38 AM

Change 534411 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] OutputPageBeforeHtmlHookHandlerTest mock RequestContext

https://gerrit.wikimedia.org/r/534411

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.22; 2019-09-10).Sep 5 2019, 12:00 PM

Maintenance_bot removed a project: Patch-For-Review.Sep 5 2019, 12:10 PM

• alaa_wmde moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Sep 6 2019, 10:01 AM

WMDE-leszek closed this task as Resolved.Sep 9 2019, 11:21 AM

WMDE-leszek moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.