To reproduce: https://deployment.wikimedia.beta.wmflabs.org/wiki/Special:AbuseFilter/new
'new' has to be taken into account when validating.
Description
Description
Details
Details
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Release | hashar | T220746 1.34.0-wmf.21 deployment blockers | ||
| Resolved | Daimona | T231985 Cannot create new abuse filters |
Event Timeline
Comment Actions
Change 534428 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] Fix filter validation in ViewEdit
Comment Actions
Change 534429 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@wmf/1.34.0-wmf.21] Fix filter validation in ViewEdit
Comment Actions
@Daimona here is where I have a problem with this: we have unit tests that create filters. How come none of them failed with I6436c7d2df8c1f0fc971f4a4079dac9118aa8209 ?
Comment Actions
Because none of them checks the UI... We'd have better luck with selenium for that, at least to ensure basic things work, like creating a new filter, or editing an existing one, or viewing Special:AbuseFilter without fatals.
I had sent https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/AbuseFilter/+/476519/ for that.
Comment Actions
Change 534428 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Fix filter validation in ViewEdit
Comment Actions
Change 534429 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@wmf/1.34.0-wmf.21] Fix filter validation in ViewEdit
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2019-09-04T16:38:46Z] <lucaswerkmeister-wmde@deploy1001> Synchronized php-1.34.0-wmf.21/extensions/AbuseFilter: SWAT: [[gerrit:534429|Fix filter validation in ViewEdit (T231985)]] (duration: 00m 58s)