Page MenuHomePhabricator
Create Task
Maniphest T232004

NamespaceInfo::$canonicalNames is missing NS_MAIN
Closed, ResolvedPublic
Actions

Description

NS_MAIN is missing from NamespaceInfo::$canonicalNames which means that NamespaceInfo::getCommonNamespaces() does not return the correct result.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Add NS_MAIN to NamespaceInfo::$canonicalNamesDbarrattmediawiki/coremaster+1 -0
Customize query in gerrit

Related Objects

Event Timeline

dbarratt created this task.Sep 4 2019, 4:07 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 4 2019, 4:07 PM
dbarratt claimed this task.Sep 4 2019, 4:07 PM
dbarratt moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment-Team (The Letter Song) board.
gerritbot added a comment.Sep 4 2019, 4:09 PM

Change 534477 had a related patch set uploaded (by Dbarratt; owner: Dbarratt):
[mediawiki/core@master] Add NS_MAIN to NamespaceInfo::$canonicalNames

https://gerrit.wikimedia.org/r/534477

gerritbot added a project: Patch-For-Review.Sep 4 2019, 4:09 PM
dbarratt moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment-Team (The Letter Song) board.Sep 4 2019, 4:09 PM
gerritbot added a comment.Sep 4 2019, 5:03 PM

Change 534477 merged by jenkins-bot:
[mediawiki/core@master] Add NS_MAIN to NamespaceInfo::$canonicalNames

https://gerrit.wikimedia.org/r/534477

Maintenance_bot removed a project: Patch-For-Review.Sep 4 2019, 5:10 PM
dbarratt moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment-Team (The Letter Song) board.Sep 4 2019, 5:19 PM
ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.22; 2019-09-10).Sep 4 2019, 6:00 PM
dom_walden moved this task from QA/Testing 🐞 to Done (2019-20: Q2) on the Anti-Harassment-Team (The Letter Song) board.Sep 9 2019, 12:51 PM
dom_walden subscribed.

Checking out the WIP patches from T200938, after this change blocks including the Main namespace are displayed in Special:CentralAuth as a separate bullet point (Main).

Before, it included Main as one of the ...and #n local namespaces.

This change potentially affects the SemanticMediaWiki and ManageWiki extensions. I have raised bugs with the respective developers https://github.com/SemanticMediaWiki/SemanticMediaWiki/issues/4290 and https://phabricator.miraheze.org/T4710.

RhinosF1 subscribed.Sep 9 2019, 2:54 PM
dbarratt closed this task as Resolved.Sep 11 2019, 3:27 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits