Page MenuHomePhabricator

NamespaceInfo::$canonicalNames is missing NS_MAIN
Closed, ResolvedPublic

Description

NS_MAIN is missing from NamespaceInfo::$canonicalNames which means that NamespaceInfo::getCommonNamespaces() does not return the correct result.

Details

Related Gerrit Patches:

Event Timeline

dbarratt created this task.Sep 4 2019, 4:07 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 4 2019, 4:07 PM
dbarratt claimed this task.Sep 4 2019, 4:07 PM
dbarratt moved this task from Ready to In Progress on the Anti-Harassment (The Letter Song) board.

Change 534477 had a related patch set uploaded (by Dbarratt; owner: Dbarratt):
[mediawiki/core@master] Add NS_MAIN to NamespaceInfo::$canonicalNames

https://gerrit.wikimedia.org/r/534477

Change 534477 merged by jenkins-bot:
[mediawiki/core@master] Add NS_MAIN to NamespaceInfo::$canonicalNames

https://gerrit.wikimedia.org/r/534477

dom_walden added a subscriber: dom_walden.

Checking out the WIP patches from T200938, after this change blocks including the Main namespace are displayed in Special:CentralAuth as a separate bullet point (Main).

Before, it included Main as one of the ...and #n local namespaces.

This change potentially affects the SemanticMediaWiki and ManageWiki extensions. I have raised bugs with the respective developers https://github.com/SemanticMediaWiki/SemanticMediaWiki/issues/4290 and https://phabricator.miraheze.org/T4710.

dbarratt closed this task as Resolved.Sep 11 2019, 3:27 PM