Page MenuHomePhabricator
Create Task
Maniphest T232102

Cancel button text not visible after pressing Thanks on Minerva
Closed, ResolvedPublic
Actions

Description

Screenshot 2019-09-05 at 9.45.32 AM.png (219×507 px, 10 KB)

The "Cancel" text is no longer visible after pressing "Thank" on mobile.

Likely caused by T150189
I think this just needs to remove the line in Thanks/modules/ext.thanks.mobilediff.css (possibly can remove all that CSS now Minerva provides default styling for links in toasts)

.mw-thanks-notification a {
	background: #fff;

Details

SubjectRepoBranchLines +/-
Remove unneeded CSS for thanks toast linkmediawiki/extensions/Thanksmaster+2 -2 K
Customize query in gerrit

Related Objects

Event Timeline

kostajh created this task.Sep 5 2019, 2:32 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptSep 5 2019, 2:32 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
kostajh moved this task from Inbox to Q2 2019-20 on the Growth-Team board.Sep 5 2019, 2:46 PM
kostajh added a project: patch-welcome.

Tentatively putting it in Q2, but probably wouldn't be until Q3 given the size of our backlog.

Jdlrobson edited projects, added MinervaNeue (Tracking); removed MinervaNeue.Sep 5 2019, 4:47 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson updated the task description. (Show Details)Sep 5 2019, 4:49 PM
Ammarpad claimed this task.Sep 5 2019, 11:01 PM
gerritbot added a comment.Sep 6 2019, 12:10 AM

Change 534712 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/Thanks@master] Remove unneeded CSS for thanks toast link

https://gerrit.wikimedia.org/r/534712

gerritbot added a project: Patch-For-Review.Sep 6 2019, 12:10 AM
gerritbot added a comment.Sep 9 2019, 10:03 PM

Change 534712 merged by jenkins-bot:
[mediawiki/extensions/Thanks@master] Remove unneeded CSS for thanks toast link

https://gerrit.wikimedia.org/r/534712

Volker_E closed this task as Resolved.Sep 9 2019, 10:09 PM
Volker_E triaged this task as Medium priority.
Volker_E removed a project: Patch-For-Review.
Jdlrobson subscribed.Sep 9 2019, 10:31 PM

Screenshot_20190909-153000_Chrome.jpg (2×1 px, 421 KB)

There is no gap between the ellipsis and the cancel link. I'm guessing there needs to be a space added?

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL