Page MenuHomePhabricator

[Regression] Single tapping on a link is enabling the label editing mode
Closed, ResolvedPublic

Description

Steps to replicate:

  1. Open a page with mobile VE that has a link on it.
  2. Tap on the link, it opens the edit card
  3. Close the edit card by tapping on the cross button
  4. Tap on the link again

Observe that, this time instead of opening the edit card gain it enables the label editing mode. I think at this point it should bring back the edit card instead because the user is doing the same action again and it shouldn't do something different on second time. Double tapping to enable the label editing makes sense but not single tapping.

I originally mentioned this issue in the task T231125 but filing a separate task now for more clarity.

Event Timeline

Double tapping to enable the label editing makes sense but not single tapping.

Note that the behaviour for going into label editing is not necessarily double tapping, but just tapping on an already focused link (this could happen later or in a different part of the word). As the close action doesn't put the focus anywhere else, the tap after closing will still bring up label editing mode.

We could put in a special case for when the link card has been dismissed with the 'x', if this is deemed necessary.

JTannerWMF added a subscriber: JTannerWMF.

In Triage we determined we will move forward with what @Esanders suggested in the last line

In Triage we determined we will move forward with what @Esanders suggested in the last line

awesome!

Change 569663 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Require two clicks on link for label editing after closing context item

https://gerrit.wikimedia.org/r/569663

Change 569663 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Require two clicks on link for label editing after closing context item

https://gerrit.wikimedia.org/r/569663

Change 570686 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (624ec74b7)

https://gerrit.wikimedia.org/r/570686

Change 570686 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (624ec74b7)

https://gerrit.wikimedia.org/r/570686

marcella awarded a token.