| dom_walden | |
| Sep 6 2019, 12:01 PM |
| F30464372: Screen Shot 2019-09-25 at 11.49.10 AM.png | |
| Sep 25 2019, 3:50 PM |
| F30407553: long_username.png | |
| Sep 20 2019, 11:32 AM |
| F30366820: Screenshot_2019-09-16 The Pizza Underground - Wikipedia.png | |
| Sep 16 2019, 2:00 AM |
| F30238831: Screen Shot 2019-09-06 at 3.26.38 PM.png | |
| Sep 6 2019, 7:28 PM |
| F30236774: ipv6.png | |
| Sep 6 2019, 12:01 PM |
The revision details popup is not wide enough, so IPv6 addresses get cut off.
Occurs on both Firefox and Chrome.
The revision details pop-up should adjust to accommodate longer strings, like IP addresses.
For Brexit:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Update OOUI to v0.34.1 | mediawiki/core | master | +121 -42 | |
| Wrap long strings in popups | oojs/ui | master | +2 -0 |
I'm adding this onto the Kanban board, so it can be fixed as well.
We haven't formally estimated this, but we can discuss it in the next standup.
@Prtksxna I don't know if there are any design specifications for this, but I'm tagging you in case you have any thoughts or suggestions around this bug fix.
I advice the developers: overflow-wrap: break-word ;)
Maybe this should be done upstream in OOUI, where it's setting overflow: hidden; for popup widgets? It seems that it'd apply to any popup with long words.
Change 535135 had a related patch set uploaded (by Samwilson; owner: Samwilson):
[oojs/ui@master] Wrap long strings in popups
@Samwilson, I think it would also be alright to increase the width of the pop-up enough to fit IPv6 addresses. There are currently two popups sizes in the Zeplin—250px and 320px. Which one is being used screenshot above?
The proposed change by @Samwilson for OOUI makes sense in edge cases and I'm gonna merge it after reviewing, but I'm with @Prtksxna's proposal as the user friendly solution here.
Change 535763 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] Update OOUI to v0.34.1
The OOUI fix is merged, and the popup width is already the larger size mentioned in T232211#5475208, so I'm not sure what else should be done here. Maybe we can test it with the new text wrapping and see how it feels? It'll look like this:
The text wrapping looks good, I think we can go ahead with it. Thanks for posting the screenshot 👍🏽
Cool. So this has been merged, and the OOUI update merged to MW core, so this will be ready for testing later this week I guess.
Wrapping looks good for IPv6 and long usernames as well.
As this change affects other popups on MediaWiki, I briefly compared the popups in Special:RecentChanges before and after the update to OOUI. I could not see any differences.
It also looks good to me in tests (see screenshot example below). I'm marking this work as Done.
