Page MenuHomePhabricator
Create Task
Maniphest T232223

Replace alternate user icon in Minerva/MF
Closed, ResolvedPublic
Actions

Assigned To
ovasileva
Authored By
• alexhollender_WMF
Sep 6 2019, 4:43 PM
Tags
Referenced Files
F30373978: IMG_0245.PNG
Sep 16 2019, 7:59 PM
F30373970: IMG_0247.PNG
Sep 16 2019, 7:59 PM
F30373973: IMG_0248.PNG
Sep 16 2019, 7:59 PM
F30308463: Screenshot 2019-09-12 at 8.14.15 AM.png
Sep 12 2019, 3:14 PM
F30308451: Screenshot 2019-09-12 at 8.05.53 AM.png
Sep 12 2019, 3:12 PM
F30303233: Screenshot 2019-09-11 at 4.09.33 PM.png
Sep 11 2019, 11:53 PM
F30303641: Screenshot 2019-09-11 at 4.26.02 PM.png
Sep 11 2019, 11:53 PM
F30300058: image.png
Sep 11 2019, 5:52 PM
View All 25 Files
Subscribers
Aklapper
• alexhollender_WMF
Jdlrobson

Description

Description

Currently we use this square smiley face icon to represent users on Contributions, History, and potentially elsewhere. There are two aspects to this task:

  • replace the square smiley with the default user avatar icon
  • use the anon-user icon for IP users

Design

currentupdatedicon color
History
image.png (669×377 px, 57 KB)
image.png (669×377 px, 56 KB)
#72777d
Contributions
image.png (669×377 px, 88 KB)
image.png (669×377 px, 88 KB)
#72777d
Contributions (anon)
image.png (669×377 px, 86 KB)
image.png (669×377 px, 85 KB)
#72777d
Diff
image.png (669×377 px, 102 KB)
image.png (669×377 px, 101 KB)
#54595d
Diff (anon)
image.png (669×377 px, 101 KB)
image.png (669×377 px, 101 KB)
#54595d

userAnonymous.svg304 BDownload

Acceptance criteria

  • user icon has been updated on History, Contributions (normal & anon), Diff (normal & anon)

You can use this page to verify: https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:History/BeforeEach-name-0.014682941226368484-Iñtërnâtiônàlizætiøn

Details

SubjectRepoBranchLines +/-
userAvatar on diff page different variant from contributionsmediawiki/extensions/MobileFrontendmaster+9 -3
Update mobile special page user iconsmediawiki/extensions/MobileFrontendmaster+14 -13
Customize query in gerrit

Event Timeline

• alexhollender_WMF created this task.Sep 6 2019, 4:43 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 6 2019, 4:43 PM
• alexhollender_WMF renamed this task from Replace user icon in Minerva/MF to Replace alternate user icon in Minerva/MF.Sep 6 2019, 4:43 PM

I don't think this needs to be done in conjunction with the current icon work.

• alexhollender_WMF updated the task description. (Show Details)Sep 6 2019, 4:45 PM
Aklapper added projects: MobileFrontend, MinervaNeue.Sep 9 2019, 10:10 AM

@alexhollender: Assuming this task is about MobileFrontend/MinervaNeue, hence adding project tag so others can find this task when searching for tasks in that project.

gerritbot added a comment.Sep 9 2019, 9:32 PM

Change 535294 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Update mobile special page user icons

https://gerrit.wikimedia.org/r/535294

gerritbot added a project: Patch-For-Review.Sep 9 2019, 9:32 PM
Volker_E triaged this task as Medium priority.Sep 9 2019, 9:33 PM
Volker_E added a project: UI-Standardization.
Jdlrobson subscribed.Sep 9 2019, 9:33 PM

New icons:

Screenshot 2019-09-09 at 2.31.01 PM.png (588×348 px, 52 KB)

Screenshot 2019-09-09 at 2.30.37 PM.png (562×341 px, 45 KB)

Screenshot 2019-09-09 at 2.30.11 PM.png (547×377 px, 69 KB)

Screenshot 2019-09-09 at 2.33.25 PM.png (587×350 px, 57 KB)

Jdlrobson edited projects, added Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1); removed Web-Team-Backlog.Sep 9 2019, 9:37 PM
gerritbot added a comment.Sep 9 2019, 10:48 PM

Change 535294 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Update mobile special page user icons

https://gerrit.wikimedia.org/r/535294

Jdlrobson assigned this task to • alexhollender_WMF.Sep 9 2019, 10:49 PM
Jdlrobson moved this task from Needs Analysis to Needs Design Review on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Jdlrobson added a comment.Sep 9 2019, 10:59 PM

URLs to test on:
https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Contributions/Jdlrobson
https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:MobileDiff/397062
https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:MobileDiff/397130
https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:History/Spain

Move to sign off when satisfied!

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.22; 2019-09-10).Sep 9 2019, 11:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 9 2019, 11:10 PM
Volker_E moved this task from Unsorted to Icons standardization on the UI-Standardization board.Sep 10 2019, 5:18 AM
• alexhollender_WMF updated the task description. (Show Details)Sep 11 2019, 5:52 PM
• alexhollender_WMF moved this task from Needs Design Review to Needs More Work on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.

@Jdlrobson apologies for not clarifying this initially: on History and Contributions the user icon should be #72777d. On the diffs page it's good as is.

gerritbot added a comment.Sep 11 2019, 9:03 PM

Change 535933 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Update userAvatar default color to #72777d

https://gerrit.wikimedia.org/r/535933

gerritbot added a project: Patch-For-Review.Sep 11 2019, 9:03 PM
Jdlrobson added a comment.Sep 11 2019, 9:03 PM
This comment was removed by Jdlrobson.
Jdlrobson moved this task from Needs More Work to Needs Code Review on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.Sep 11 2019, 9:07 PM
Jdlrobson added a comment.Sep 11 2019, 11:53 PM

Some issues during code review through storybook testing:

Problem 1:
Seen on CTADrawer component after https://gerrit.wikimedia.org/r/535835 patch:
Arrow not centered

Screenshot 2019-09-11 at 4.09.33 PM.png (203×682 px, 39 KB)

Problem 2:
TalkOverlay action in top right has been impacted (seen after https://gerrit.wikimedia.org/r/533360 patch):

Screenshot 2019-09-11 at 4.26.02 PM.png (388×1 px, 31 KB)

Jdlrobson raised the priority of this task from Medium to High.Sep 12 2019, 12:02 AM

Time is not on our side so bumping to high to make clear this is important in relation to other things we have on.

gerritbot added a comment.Sep 12 2019, 1:04 AM

Change 535933 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] userAvatar on diff page different variant from contributions

https://gerrit.wikimedia.org/r/535933

Jdlrobson moved this task from Needs Code Review to Needs Design Review on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.Sep 12 2019, 1:08 AM

New icons should be updated on the beta cluster now @alexhollender

Maintenance_bot removed a project: Patch-For-Review.Sep 12 2019, 1:10 AM
ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.23; 2019-09-17); removed MW-1.34-notes (1.34.0-wmf.22; 2019-09-10).Sep 12 2019, 2:00 AM
Jdlrobson added a comment.Sep 12 2019, 3:12 PM
This comment was removed by Jdlrobson.
• alexhollender_WMF reassigned this task from • alexhollender_WMF to ovasileva.Sep 16 2019, 7:59 PM
• alexhollender_WMF moved this task from Needs Design Review to Ready for Signoff on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.

Colors have been fixed. This doesn't require addition QA.

HistoryContributionsContributions (anon)
IMG_0247.PNG (1×750 px, 87 KB)
IMG_0248.PNG (1×750 px, 124 KB)
IMG_0245.PNG (1×750 px, 112 KB)
• alexhollender_WMF updated the task description. (Show Details)Sep 16 2019, 8:01 PM
ovasileva closed this task as Resolved.Sep 17 2019, 8:18 AM

Looks good!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL