Page MenuHomePhabricator

Replace alternate user icon in Minerva/MF
Closed, ResolvedPublic

Description

Description

Currently we use this square smiley face icon to represent users on Contributions, History, and potentially elsewhere. There are two aspects to this task:

  • replace the square smiley with the default user avatar icon
  • use the anon-user icon for IP users

Design

currentupdatedicon color
History
#72777d
Contributions
#72777d
Contributions (anon)
#72777d
Diff
#54595d
Diff (anon)
#54595d

Acceptance criteria

  • user icon has been updated on History, Contributions (normal & anon), Diff (normal & anon)

You can use this page to verify: https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:History/BeforeEach-name-0.014682941226368484-Iñtërnâtiônàlizætiøn

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFri, Sep 6, 4:43 PM
alexhollender renamed this task from Replace user icon in Minerva/MF to Replace alternate user icon in Minerva/MF.Fri, Sep 6, 4:43 PM

I don't think this needs to be done in conjunction with the current icon work.

alexhollender updated the task description. (Show Details)Fri, Sep 6, 4:45 PM

@alexhollender: Assuming this task is about MobileFrontend/MinervaNeue, hence adding project tag so others can find this task when searching for tasks in that project.

Change 535294 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Update mobile special page user icons

https://gerrit.wikimedia.org/r/535294

Volker_E triaged this task as Normal priority.Mon, Sep 9, 9:33 PM
Volker_E added a project: UI-Standardization.

Change 535294 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Update mobile special page user icons

https://gerrit.wikimedia.org/r/535294

@Jdlrobson apologies for not clarifying this initially: on History and Contributions the user icon should be #72777d. On the diffs page it's good as is.

Change 535933 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Update userAvatar default color to #72777d

https://gerrit.wikimedia.org/r/535933

This comment was removed by Jdlrobson.

Some issues during code review through storybook testing:

Problem 1:
Seen on CTADrawer component after https://gerrit.wikimedia.org/r/535835 patch:
Arrow not centered

Problem 2:
TalkOverlay action in top right has been impacted (seen after https://gerrit.wikimedia.org/r/533360 patch):

Jdlrobson raised the priority of this task from Normal to High.Thu, Sep 12, 12:02 AM

Time is not on our side so bumping to high to make clear this is important in relation to other things we have on.

Change 535933 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] userAvatar on diff page different variant from contributions

https://gerrit.wikimedia.org/r/535933

This comment was removed by Jdlrobson.

Colors have been fixed. This doesn't require addition QA.

HistoryContributionsContributions (anon)
ovasileva closed this task as Resolved.Tue, Sep 17, 8:18 AM

Looks good!