| Volker_E | |
| Sep 6 2019, 9:51 PM |
| F34006251: en.m.wikipedia.org_wiki_Main_Page(iPhone 11 Pro Max).png | |
| Jan 18 2021, 5:10 AM |
| F34006253: Screen Shot 2021-01-17 at 9.08.08 PM.png | |
| Jan 18 2021, 5:10 AM |
| F34006244: en.m.wikipedia.beta.wmflabs.org_wiki_Selenium_diff_test_0.4435485606817703(iPhone 11 Pro Max).png | |
| Jan 18 2021, 5:06 AM |
| F34006246: Screen Shot 2021-01-17 at 9.04.42 PM.png | |
| Jan 18 2021, 5:06 AM |
| F34001727: en.m.wikipedia.beta.wmflabs.org_w_index.php_title=Special_MobileOptions&returnto=Main+Page(iPhone 11 Pro Max).png | |
| Jan 14 2021, 6:46 PM |
| F34000911: Screen Shot 2021-01-14 at 11.17.45 AM.png | |
| Jan 14 2021, 4:18 PM |
| F34000859: 20210114_123939.jpg | |
| Jan 14 2021, 3:41 PM |
| F31674369: image.png | |
| Mar 10 2020, 3:55 PM |
PageList component:
https://doc.wikimedia.org/MobileFrontend/master/js/ui/?path=/story/pagelist--default
The wikidata descriptions are too small and no line height is applied.
font-size: 13px (or 0.8125em)
line-height: 19px (or 1.5)
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T232229#6754229 |
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T232229#6754231 |
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Change font and line height Pagelist description | mediawiki/extensions/MobileFrontend | master | +5 -5 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Volker_E | T136748 Address interface sizing issues on different base font size calculations for thorough consistency in MediaWiki projects | |||
| Resolved | Volker_E | T229568 Apply consistent small font-sizes in MobileFrontend/MinervaNeue | |||
| Resolved | ovasileva | T232229 PageList descriptions too small font and line height |
@Volker_E as we've discussed a more comprehensive review of font-sizes in mobile front end is needed, however this issue seems worth addressing in the meantime.
A quick survey of possible reference points for what font-size we could use for the PageList descriptions:
13px font looks correct to me (which I believe should also be used for the description text on the "RELATED ARTICLES" cards):
| current | 13px font / 18px line-height | 14px font / 19px line height |
 |  |  |
Not sure I understand the question. Please clarify.
Hi @Srk224, have you already made yourself comfortable with contributing to Wikimedia products. https://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_hacker is a good introduction.
Hi All,
I am new to open source and would like to work on this task.
I have set up MediaWiki-Docker and MinervaNeue
@Prernaswarna: Hi and welcome! Feel free to do so; also see https://www.mediawiki.org/wiki/New_Developers/Communication_tips - thanks!
Change 652395 had a related patch set uploaded (by Prernaswarna; owner: Prernaswarna):
[mediawiki/extensions/MobileFrontend@master] Change font and line height Pagelist description
You'll be able to sign off on the design on https://en.m.wikipedia.beta.wmflabs.org/wiki/Main_Page shortly.
Change 652395 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Change font and line height Pagelist description
Status: ✅ PASS
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: iPhone X
Test Artifact(s):
✅ AC1: The wikidata descriptions should appear as the image in design steps in the task description with the following specs:
font-size: 13px (or 0.8125em)
line-height: 19px (or 1.5)
 |  |
Status: ✅ PASS
Environment: enwiki
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: iPhone X
Test Artifact(s):
✅ AC1: The wikidata descriptions should appear as the image in design steps in the task description with the following specs:
font-size: 13px (or 0.8125em)
line-height: 19px (or 1.5)
 |  |
