Page MenuHomePhabricator

update.php should maybe run cleanupUsersWithNoId.php
Closed, DeclinedPublic


I'm not all that familiar with actor migration, so i might be misinterpreting.

We've recently had some complaints on project:support_desk ( ) about stuff going missing on upgrade involving users with id 0. I think the issue is that update.php doesn't run cleanupUsersWithNoId.php prior to running migrateActors.php. At a glance, I don't see why we wouldn't do this.

Event Timeline

AnnGuy changed the task status from Open to In Progress.Jan 2 2023, 5:23 PM


Zabe changed the task status from In Progress to Open.Jan 2 2023, 5:26 PM

When run manually, you can decide whether users with 0 ID but a locally existing name should be merged into the local user, and what interwiki prefix should be used for non-merged users.

I guess selecting no / some unique prefix like migrated is non-destructive so the automated migration could do that, but it would then be nice if the user could manually change those choices later (ie. tell the migration script to merge all migrated>... users into the local equivalent and/or change the prefix name, which is sometimes used as an actual interwiki prefix when linking the the user).

matmarex assigned this task to tstarling.
matmarex added a subscriber: matmarex.

Script has been deleted in before we got around to fixing this problem with it.