Page MenuHomePhabricator
Create Task
Maniphest T232313

Language-tagged template transformation stops too early on labeled "pipe" wikilinks
Closed, ResolvedPublic3 Estimated Story PointsBUG REPORT
Actions

Description

We received a bug report saying that the language-tagged text on an import was broken. The final import text seems to have been manually corrected, see here:
https://commons.wikimedia.org/wiki/Special:Diff/364855386

Steps to reproduce/demo:

Bug
|Description = {{en|Test description with a [[:test2wiki:w:en:Link}}|link]] to the English Wikipedia.
Fixed
|Description = {{en|Test description with a [[:test2wiki:w:en:Link|link]] to the English Wikipedia.}}

The relevant rule being used is one with an @ sign here: https://commons.wikimedia.beta.wmflabs.org/wiki/Extension:FileImporter/Data/en.wikipedia#Transfer

Details

SubjectRepoBranchLines +/-
Fix WikitextContentCleaner failing on [[labeled|links]]mediawiki/extensions/FileImportermaster+19 -7
Customize query in gerrit

Related Objects

Event Timeline

awight created this task.Sep 9 2019, 8:51 AM
Restricted Application added a project: TCB-Team (now WMDE-TechWish). · View Herald TranscriptSep 9 2019, 8:51 AM
awight changed the subtype of this task from "Task" to "Bug Report".Sep 10 2019, 10:01 PM
gerritbot added a comment.Sep 20 2019, 9:03 AM

Change 538166 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/FileImporter@master] [WIP] Fix WikitextContentCleaner failing on [[labeled|links]]

https://gerrit.wikimedia.org/r/538166

gerritbot added a project: Patch-For-Review.Sep 20 2019, 9:03 AM
thiemowmde moved this task from Backlog to Tickets ready for pickup on the Move-Files-To-Commons board.Sep 20 2019, 9:06 AM
thiemowmde subscribed.

This is indeed a bug, caused by my incomplete attempt to parse wikitext. https://gerrit.wikimedia.org/r/538166 demonstrates the issue with a currently failing test. I would like to teach our parser to skip pairs of [[…]] possibly including pipes. This is just not a one-liner and will take a little while, possibly worth 3 story points.

thiemowmde claimed this task.Sep 24 2019, 8:02 AM
thiemowmde moved this task from Incoming to In QWERTY sprint on the TCB-Team (now WMDE-TechWish) board.
thiemowmde added a project: WMDE-QWERTY-Sprint-2019-09-10.
thiemowmde set the point value for this task to 3.
thiemowmde moved this task from Sprint Backlog to Review on the WMDE-QWERTY-Sprint-2019-09-10 board.
thiemowmde moved this task from Tickets ready for pickup to Tickets in sprint on the Move-Files-To-Commons board.
thiemowmde added a subscriber: JStrodt_WMDE.
gerritbot added a comment.Sep 24 2019, 12:14 PM

Change 538166 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Fix WikitextContentCleaner failing on [[labeled|links]]

https://gerrit.wikimedia.org/r/538166

awight mentioned this in rEFLIf3aa1616cf97: Fix WikitextContentCleaner failing on [[labeled|links]].Sep 24 2019, 12:16 PM
ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.24; 2019-09-24).Sep 24 2019, 1:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 24 2019, 1:10 PM
thiemowmde added a project: WMDE-QWERTY-Sprint-2019-09-25.Sep 25 2019, 12:59 PM
thiemowmde moved this task from Sprint Backlog to Demo on the WMDE-QWERTY-Sprint-2019-09-25 board.
thiemowmde mentioned this in rEFLI9cae897ba280: Restructure WikitextContentCleaner to use if() instead of switch.Sep 26 2019, 1:18 PM
thiemowmde updated the task description. (Show Details)Sep 27 2019, 9:50 AM
Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptSep 27 2019, 9:50 AM
thiemowmde renamed this task from Language-tagged template transformation may be causing problems to Language-tagged template transformation stops to early on labeled "pipe" wikilinks.Sep 27 2019, 9:52 AM
awight renamed this task from Language-tagged template transformation stops to early on labeled "pipe" wikilinks to Language-tagged template transformation stops too early on labeled "pipe" wikilinks.Oct 1 2019, 8:47 AM
thiemowmde closed this task as Resolved.Oct 9 2019, 2:14 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL