Page MenuHomePhabricator
Create Task
Maniphest T232337

[BlueSpiceVisualEditorConnector] missing message 'bs-visualeditorconnector-ve-table-width-option'
Closed, ResolvedPublic
Actions

Description

BlueSpiceVisualEditorConnector defines OOJSPlus as a requirement in extension.json. I have added that dependency in CI via c3b957c4c8a17a509fb387fa55d8f45e69e96d76

When validating the modification with a dummy change (Gerrit #474654, the test suite fails:

There was 1 failure:

1) ResourcesTest::testMissingMessages
Message 'bs-visualeditorconnector-ve-table-width-option' required by 'ext.bluespice.visualEditorConnector.tablestyleplugin' must exist
Failed asserting that false is true.

/workspace/src/tests/phpunit/structure/ResourcesTest.php:91
/workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:454
/workspace/src/maintenance/doMaintenance.php:99

Related Objects

Event Timeline

hashar created this task.Sep 9 2019, 1:55 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 9 2019, 1:55 PM
Pwirth claimed this task.Sep 12 2019, 3:15 AM
gerritbot added a comment.Sep 12 2019, 3:16 AM

Change 535986 had a related patch set uploaded (by Pwirth; owner: Pwirth):
[mediawiki/extensions/BlueSpiceVisualEditorConnector@master] Remove unused/undefined message bs-visualeditorconnector-ve-table-width-option. T232337

https://gerrit.wikimedia.org/r/535986

gerritbot added a project: Patch-For-Review.Sep 12 2019, 3:16 AM
gerritbot added a comment.Sep 12 2019, 6:50 AM

Change 536004 had a related patch set uploaded (by Mglaser; owner: Pwirth):
[mediawiki/extensions/BlueSpiceVisualEditorConnector@REL1_31_dev] Remove unused/undefined message bs-visualeditorconnector-ve-table-width-option. T232337

https://gerrit.wikimedia.org/r/536004

gerritbot added a comment.Sep 12 2019, 6:59 AM

Change 535986 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceVisualEditorConnector@master] Remove unused/undefined message bs-visualeditorconnector-ve-table-width-option. T232337

https://gerrit.wikimedia.org/r/535986

Pwirth mentioned this in rEBUA0987e0421622: Remove unused/undefined message bs-visualeditorconnector-ve-table-width-option..Sep 12 2019, 7:00 AM
gerritbot added a comment.Sep 12 2019, 8:12 AM

Change 536004 merged by Pwirth:
[mediawiki/extensions/BlueSpiceVisualEditorConnector@REL1_31_dev] Remove unused/undefined message bs-visualeditorconnector-ve-table-width-option. T232337

https://gerrit.wikimedia.org/r/536004

Pwirth closed this task as Resolved.Sep 12 2019, 8:13 AM
Mglaser mentioned this in rEBUA45c7bf9a6625: Remove unused/undefined message bs-visualeditorconnector-ve-table-width-option..Sep 12 2019, 8:14 AM
Maintenance_bot removed a project: Patch-For-Review.Sep 12 2019, 9:10 AM
hashar added a comment.Sep 12 2019, 9:30 AM

Thank you @Pwirth!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL