Mobile Visual Editor on iOS has a suppressed error after saving
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	DLynch
	Sep 9 2019, 2:51 PM

Description

Edit an article on mobile on iOS, then save it. After the save this will be in the console:

VM32 jquery.js:3819 jQuery.Deferred exception: Cannot read property 'getView' of null TypeError: Cannot read property 'getView' of null
    at VeInitMwMobileArticleTarget.ve.init.mw.MobileArticleTarget.onSurfaceScroll (http://dev.wiki.local.wmftest.net:8080/w/extensions/VisualEditor/modules/ve-mw/init/targets/ve.init.mw.MobileArticleTarget.js?215d9:249:38)
    at VeUiMWSurface.oo.EventEmitter.emit (http://dev.wiki.local.wmftest.net:8080/w/resources/lib/oojs/oojs.jquery.js?b1631:824:12)
    at http://dev.wiki.local.wmftest.net:8080/w/extensions/VisualEditor/lib/ve/src/ui/ve.ui.Surface.js?afd47:560:12
    at mightThrow (http://dev.wiki.local.wmftest.net:8080/w/resources/lib/jquery/jquery.js?6fb03:3535:29)
    at process (http://dev.wiki.local.wmftest.net:8080/w/resources/lib/jquery/jquery.js?6fb03:3603:12) undefined

Details

	Subject	Repo	Branch	Lines +/-
	MobileArticleTarget: don't access the surface after it's destroyed	mediawiki/extensions/VisualEditor	master	+1 -1

Customize query in gerrit

Event Timeline

DLynch created this task.Sep 9 2019, 2:51 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 9 2019, 2:51 PM

DLynch added a project: VisualEditor-MediaWiki-Mobile.Sep 9 2019, 2:51 PM

DLynch moved this task from Incoming to In progress on the VisualEditor (Current work) board.

Change 535207 had a related patch set uploaded (by DLynch; owner: DLynch):
[mediawiki/extensions/VisualEditor@master] MobileArticleTarget: don't access the surface after it's destroyed

https://gerrit.wikimedia.org/r/535207

gerritbot added a project: Patch-For-Review.Sep 9 2019, 3:01 PM

DLynch moved this task from In progress to Code review on the VisualEditor (Current work) board.Sep 9 2019, 3:02 PM

Change 535207 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] MobileArticleTarget: don't access the surface after it's destroyed

https://gerrit.wikimedia.org/r/535207

matmarex moved this task from Code review to QA on the VisualEditor (Current work) board.Sep 9 2019, 4:38 PM

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.22; 2019-09-10).Sep 9 2019, 5:00 PM

Maintenance_bot removed a project: Patch-For-Review.Sep 9 2019, 5:10 PM

matmarex added a project: Editing QA.Sep 9 2019, 10:55 PM

matmarex moved this task from Inbox to Low Priority on the Editing QA board.Sep 9 2019, 10:57 PM

Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.Sep 10 2019, 11:04 PM

Ryasmeen edited projects, added Verified; removed Editing QA.

• ppelberg closed this task as Resolved.Oct 22 2019, 12:43 AM