Page MenuHomePhabricator

Fix formatting of cascade protection sources above structured data panel
Closed, ResolvedPublic


See screenshot - The syntax is a bit off when cascade sources are listed in the cascading protection message shown to users, causing some extraneous characters (\n) to print and disrupting the bullet formatting.

Acceptance Criteria:

  • Files with cascading protection show a message detailing the source(s) of the protection and this text is formatted properly

During development, please test the following:

  • Test this feature while logged in AND logged out
  • Test this feature on at least one mobile browser
  • Test that this feature works on the file page AND the Add Data step on UploadWizard (if applicable, some features only exist on one or the other)


Related Gerrit Patches:
mediawiki/extensions/WikibaseMediaInfo : masterFix newlines in cascade protection message

Event Timeline

AnneT created this task.Sep 9 2019, 5:53 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 9 2019, 5:53 PM

Change 535258 had a related patch set uploaded (by Anne Tomasevich; owner: Anne Tomasevich):
[mediawiki/extensions/WikibaseMediaInfo@master] Fix newlines in cascade protection message

Change 535258 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Fix newlines in cascade protection message

Ramsey-WMF closed this task as Resolved.Sep 19 2019, 9:00 PM
Ramsey-WMF added a subscriber: Ramsey-WMF.

Tested on production with multiple protected files using multiple transclusions. All good.