Page MenuHomePhabricator
Create Task
Maniphest T232414

`.previewnote p` should be replaced by semantic message classes as `.warningbox` and `.messagebox`
Closed, ResolvedPublic
Actions

Assigned To
Volker_E
Authored By
Volker_E
Sep 9 2019, 11:03 PM
Project Tags
Referenced Files
F30295347: image.png
Sep 10 2019, 11:11 PM
F30284947: Screenshot 2019-09-09 at 2.59.28 PM.png
Sep 9 2019, 11:07 PM
F30284946: Screenshot 2019-09-09 at 2.59.45 PM.png
Sep 9 2019, 11:07 PM
F30285635: image.png
Sep 9 2019, 11:03 PM
Subscribers
Aklapper
• alexhollender_WMF
Dvorapa
Fito
Jdlrobson
Jdrewniak
Masumrezarock100
View All 10 Subscribers

Description

Current treatment of .previewnote (and .previewnote p) is not aligned with Design Style Guide message treatment.

.previewnote p main usage is a warning to non-JS users when previewing an edited article:

Vector, Timeless, etc. through shared.css
image.png (1,622×474 px, 90 KB)

Usage of .previewnote class across repos:
https://codesearch.wmflabs.org/search/?q=.previewnote&i=nope&files=&repos=

Apart from main usage there are two other occurrences in MW core:

  • includes/actions/McrUndoAction.php – unclear what the usage is
  • includes/specials/SpecialExpandTemplates.php
Expected result

Show a warningbox style visual treatment

Proposed:

Screenshot 2019-09-09 at 2.59.45 PM.png (566×468 px, 82 KB)

Screenshot 2019-09-09 at 2.59.28 PM.png (551×425 px, 81 KB)

Dev notes
  • Verify other usages of 'previewnote' in core and extensions on possible breakage.
    • McrUndoAction.php uses a copy of EditPage.php implementation and should use a .messagebox class instead of .previewnote.
    • SpecialExpandTemplates.php should have ..errorbox assigned instead. Proposed:
      image.png (2,024×274 px, 63 KB)
Extensions affected
Skins affected

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Remove obsolete `.previewnote p` selectorVolkerEmediawiki/extensions/MobileFrontendmaster+12 -20
Standardise preview warning boxVolkerEmediawiki/extensions/TwoColConflictmaster+2 -2
Standardise preview warning box when using ?action=editJdlrobsonmediawiki/coremaster+8 -11
Remove obsolete `.previewnote p` selectorVolkerEmediawiki/skins/MinervaNeuemaster+0 -1
Standardise preview error and warning messagesVolkerEmediawiki/extensions/TemplateSandboxmaster+6 -3
SpecialExpandTemplates: Add semantic 'errorbox' class to errorVolkerEmediawiki/coremaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Volker_E created this task.Sep 9 2019, 11:03 PM
Jdlrobson added a comment.Sep 9 2019, 11:07 PM

proposed:

Screenshot 2019-09-09 at 2.59.45 PM.png (566×468 px, 82 KB)

Screenshot 2019-09-09 at 2.59.28 PM.png (551×425 px, 81 KB)

gerritbot added a comment.Sep 9 2019, 11:07 PM

Change 535300 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/core@master] Standardise preview warning box when using ?action=edit

https://gerrit.wikimedia.org/r/535300

gerritbot added a project: Patch-For-Review.Sep 9 2019, 11:07 PM
gerritbot added a comment.Sep 9 2019, 11:38 PM

Change 535313 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/MobileFrontend@master] Remove obsolete .previewnote p selector

https://gerrit.wikimedia.org/r/535313

gerritbot added a comment.Sep 10 2019, 12:00 AM

Change 535315 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/skins/MinervaNeue@master] Remove obsolete .previewnote p selector

https://gerrit.wikimedia.org/r/535315

Volker_E added a comment.Sep 10 2019, 12:08 AM

TwoColConflict seems to need additional class as well as of
https://gerrit.wikimedia.org/g/mediawiki/extensions/TwoColConflict/+/55ddeccf63816305556a183e9866cc1a80b9d97a/modules/SplitTwoColConflict/ext.TwoColConflict.Split.init.js

Volker_E renamed this task from previewnote should be a warningbox message to `.previewnote p` should be a `.warningbox` message.Sep 10 2019, 12:09 AM
Volker_E updated the task description. (Show Details)
Volker_E updated the task description. (Show Details)
Volker_E updated the task description. (Show Details)Sep 10 2019, 12:13 AM
Volker_E added a project: MediaWiki-General.
Volker_E updated the task description. (Show Details)Sep 10 2019, 11:11 PM
gerritbot added a comment.Sep 10 2019, 11:18 PM

Change 535735 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] SpecialExpandTemplates: Add semantic 'errorbox' class to error

https://gerrit.wikimedia.org/r/535735

Volker_E renamed this task from `.previewnote p` should be a `.warningbox` message to `.previewnote p` should be replaced by semantic message classes as `.warningbox` and `.messagebox`.Sep 10 2019, 11:30 PM
gerritbot added a comment.Sep 11 2019, 12:14 AM

Change 535735 merged by jenkins-bot:
[mediawiki/core@master] SpecialExpandTemplates: Add semantic 'errorbox' class to error

https://gerrit.wikimedia.org/r/535735

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.23; 2019-09-17).Sep 11 2019, 1:00 AM
Volker_E triaged this task as Medium priority.Sep 13 2019, 12:01 AM
Volker_E updated the task description. (Show Details)
Volker_E updated the task description. (Show Details)
gerritbot added a comment.Sep 13 2019, 12:29 AM

Change 536383 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/TwoColConflict@master] Standardise preview warning box

https://gerrit.wikimedia.org/r/536383

Volker_E updated the task description. (Show Details)Sep 13 2019, 7:31 PM
gerritbot added a comment.Sep 13 2019, 8:10 PM

Change 536675 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/TemplateSandbox@master] Standardise preview error and warning messages

https://gerrit.wikimedia.org/r/536675

Volker_E updated the task description. (Show Details)Sep 13 2019, 8:13 PM
Volker_E updated the task description. (Show Details)
gerritbot added a comment.Sep 17 2019, 2:06 AM

Change 535300 merged by jenkins-bot:
[mediawiki/core@master] Standardise preview warning box when using ?action=edit

https://gerrit.wikimedia.org/r/535300

gerritbot added a comment.Sep 17 2019, 2:07 AM

Change 536675 merged by jenkins-bot:
[mediawiki/extensions/TemplateSandbox@master] Standardise preview error and warning messages

https://gerrit.wikimedia.org/r/536675

gerritbot added a comment.Sep 17 2019, 2:07 AM

Change 535315 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Remove obsolete .previewnote p selector

https://gerrit.wikimedia.org/r/535315

Restricted Repository Identity mentioned this in rETSA4ecdca1a4374: Standardise preview error and warning messages.Sep 17 2019, 2:08 AM
Restricted Repository Identity mentioned this in rSKINccf05ad4209b: Update git submodules.Sep 17 2019, 2:09 AM
gerritbot added a comment.Sep 17 2019, 11:25 AM

Change 536383 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@master] Standardise preview warning box

https://gerrit.wikimedia.org/r/536383

gerritbot added a comment.Sep 17 2019, 6:29 PM

Change 535313 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Remove obsolete .previewnote p selector

https://gerrit.wikimedia.org/r/535313

Maintenance_bot removed a project: Patch-For-Review.Sep 17 2019, 7:11 PM
Volker_E closed this task as Resolved.Sep 17 2019, 9:29 PM
Volker_E claimed this task.
Volker_E updated the task description. (Show Details)
Volker_E closed subtask T232553: Add `.messagebox` to shared.css and MinervaNeue as Resolved.
Xaosflux subscribed.Sep 20 2019, 2:29 PM
Dvorapa subscribed.Sep 20 2019, 5:13 PM
• matmarex awarded a token.Sep 20 2019, 10:13 PM
Pppery awarded a token.Sep 22 2019, 9:58 PM
Fito subscribed.Jan 18 2020, 1:52 AM

I find it too jarring.

Restricted Application added a subscriber: Masumrezarock100. · View Herald TranscriptJan 18 2020, 1:53 AM
SomeRandomDeveloper mentioned this in T414742: Display the preview note as a notice instead of a warning.Jan 15 2026, 9:49 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits