Page MenuHomePhabricator

Newcomer tasks: homepage changes based on initiation (desktop)
Open, Needs TriagePublic

Description

When the user initiates the suggested edits module, as described in T232419, the homepage modules rearrange to make room for the suggested edits module. The start module also changes because a newcomer completed initiating the suggested edits module.

This task is about desktop only. Mobile will require a separate design and separate task.

Mockup: https://wikimedia.invisionapp.com/share/FUTVMSLV24X#/screens/383472077

Specifically, once the user completes the difficulty overlay from T232419...

  • ...the suggested edits submodule disappears from the start module, and the other three submodules (account creation, email, and tutorial) stretch out to fit the start module’s container. They should not be in thirds -- the "account creation" submodule will be less wide than "email" and "tutorial".
  • ...the suggested edits module appears on the homepage in the slot that previously contained the impact module.
  • ...the impact module moves to the right to the slot that previously contained the mentorship module.
  • ...the mentorship module moves to the upper right to the slot that previously contained the help module.
  • ...the help module moves down under the mentorship module in the same column.
BeforeAfterAfter (with collapsible start module)

It is worth noting that it may be easy to develop this task alongside of T219391, about the collapsible start module. But that task is not required for newcomer tasks.

Event Timeline

MMiller_WMF assigned this task to RHo.Sep 10 2019, 12:25 AM
MMiller_WMF created this task.

This is going to "Needs Design" because @RHo is still finalizing what happens to the start module once suggested edits is initialized.

MMiller_WMF renamed this task from Newcomer tasks: homepage changes based on initiation to Newcomer tasks: homepage changes based on initiation (desktop).Sep 10 2019, 6:15 PM
MMiller_WMF updated the task description. (Show Details)
MMiller_WMF updated the task description. (Show Details)Sep 13 2019, 8:51 PM
MMiller_WMF removed RHo as the assignee of this task.Sep 13 2019, 9:50 PM
MMiller_WMF removed a project: Growth Design.

This is ready for development. It is worth noting that it may be easy to develop this task alongside of T219391, about the collapsible start module. But that task is not required for newcomer tasks.

MMiller_WMF updated the task description. (Show Details)Sep 13 2019, 9:50 PM
Tgr claimed this task.Tue, Oct 1, 7:37 PM
Tgr updated the task description. (Show Details)

Change 540229 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/GrowthExperiments@master] Add SuggestedEdits module skeleton

https://gerrit.wikimedia.org/r/540229

Change 540229 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Add SuggestedEdits module skeleton

https://gerrit.wikimedia.org/r/540229

Tgr added a comment.Wed, Oct 2, 12:35 PM

The merged patch is good enough to unblock client-side work, but the responsive flexbox behavior probably needs a bit more tweaking.

I am adding the desktop tag here.

Change 540501 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/GrowthExperiments@master] Fix SuggestedEdits module positioning

https://gerrit.wikimedia.org/r/540501

New layout on <1024px screens:

Change 540501 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Fix SuggestedEdits module positioning

https://gerrit.wikimedia.org/r/540501

@Tgr - In betalabs (for both Chrome and FireFox), the Start module after clicking on "See suggested edits" displays a lot of empty space:

Tgr added a comment.Tue, Oct 8, 2:47 PM

The sidebar is longer than the main column so the boxes in the main column are stretched to fill out the space. What would be the correct behavior? Do not try to align them or make only the lower row stretch?

no stretchonly lower row stretches

@RHo any thoughts?

Tgr added a comment.Tue, Oct 8, 2:48 PM

I guess the former since that's what the collapsible start module mockup shows?

RHo added a comment.Tue, Oct 8, 3:11 PM

I guess the former since that's what the collapsible start module mockup shows?

Hi @Tgr - yes, confirming that the former (no stretch) is expected. Thanks!

Change 541663 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/GrowthExperiments@master] Do not align the bottom of the homepage columns

https://gerrit.wikimedia.org/r/541663

Change 541663 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Do not align the bottom of the homepage columns

https://gerrit.wikimedia.org/r/541663

MMiller_WMF updated the task description. (Show Details)Wed, Oct 9, 12:57 AM

For Design review:
Desktop

  • too much empty space in Start module
  • Mentorship module text gets stretched vertically after activating Suggested edits (the last screenshot)

Mobile:

  • too much empty space in Start module

For Design review:
Desktop

  • too much empty space in Start module
  • Mentorship module text gets stretched vertically after activating Suggested edits (the last screenshot)

Mobile:

  • too much empty space in Start module

Thanks @Etonkovidova for highlighting the above design issues. Unfortunately/Fortunately, they will be resolved in wholesale visual style updates to the homepage as part of this T232546 after the initial V1.0 release :)

On to @MMiller_WMF for review

Tgr added a comment.Fri, Oct 18, 12:59 PM

Hm, I was sure there was a pending request for this task (something about column layout within the start module) but now I can't find anything like that. I'll move it back to PM review, sorry for the confusion.