Page MenuHomePhabricator

Multiple edit buttons shown on clicking next/prev page in PDF files
Closed, ResolvedPublic

Description

When clicking next/prev page on PDF file, next "edit" button on "file information" tab is added. There can be as many edit buttons as many I click prev/next page on the right to the slide preview.

Event Timeline

I’ve also seen similar problems when editing a page with VisualEditor (without reloading it after save), though I can’t seem to reproduce it right now.

Ramsey-WMF subscribed.

Anne to look into this and see how much effort is involved in the fix.

Hey @Wargo, I've been unable to reproduce this so far. Could you please try to reproduce it again and, if you can, provide the following info?

  • Browser version and OS
  • A filepage you've tested this on
  • Exact steps to reproduce

Thanks!

Primary issue seems outdated and is not present now.

Behaviour after visual editing changed: structured descriptions dissappear under the tab and when clicked on "structured data" tab button to add statement is displayed twice.

  1. Edit file description page using visualeditor
  2. Change something and save
  3. Do not reload page after clicking save
  4. Look at structured descriptions, try to read them
  5. Click the second tab from structured data panel and count buttons "add statement"

Change 556486 had a related patch set uploaded (by Anne Tomasevich; owner: Anne Tomasevich):
[mediawiki/extensions/WikibaseMediaInfo@master] Avoid duplicating link notice and add property widgets

https://gerrit.wikimedia.org/r/556486

Change 556486 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Avoid duplicating link notice and add property widgets

https://gerrit.wikimedia.org/r/556486

Both the original problem and the later one mentioned in the thread seem to have been fixed on production.