T150418 strips references pasted directed from read mode to VE, but if they are pasted into a third-party editor, it is possible the HTML will be sufficiently mangled that our selector won't work, e.g.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Add another looser selector for catching pasted references | mediawiki/extensions/VisualEditor | master | +8 -1 |
Change 535556 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Add another looser selector for catching pasted references
Change 535556 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Add another looser selector for catching pasted references
For future reference, this can be caught at https://en.wikipedia.org/w/index.php?title=Special:AbuseLog&wpSearchFilter=861
@Esanders: Is the expected result here, it will strip references pasted from LO to VE as well. For now, what I see is nothing gets pasted into VE when I copy-paste the reference from LO after step 4.
Yes, that is the expected behavior. We currently have no way to preserve the content of the reference, and pasting just the link is useless and annoying, so we paste nothing.
What's led us to think pasting nothing is better than pasting the plaintext of what is being copied (e.g. "[1]")?
I wonder whether the current behavior (pasting nothing) will confuse contributors [2] as the lack of feedback communicates nothing about VE's support – or lack thereof – pasting references from read mode.
@iamjessklein, are you able to share your opinion about whether the following behavior is okay to you?
Behavior this patch creates
I share @ppelberg's concern, if we are not doing anything after an action, at the very least an explicit feedback is usually expected.
The task as filed is fixed, so we should probably move the discussion around keeping the plain text "[1]" or providing some other feedback into a new task.