Page MenuHomePhabricator
Create Task
Maniphest T232487

1.34.0-wmf.22 PHP Warning: curl_multi_setopt():Invalid curl multi configuration option
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error message
[{exception_id}] {exception_url}   ErrorException from line 423 of /srv/mediawiki/php-1.34.0-wmf.22/includes/libs/http/MultiHttpClient.php:
PHP Warning: curl_multi_setopt():Invalid curl multi configuration option
Impact

That broke the canary check when promoting group0 to 1.34.0-wmf.22 and thus I have cancelled the promotion.

Notes

…

Details

Stack Trace
#0 /srv/mediawiki/php-1.34.0-wmf.22/includes/libs/http/MultiHttpClient.php(423): MWExceptionHandler::handleError(integer, string, string, integer, array, array)
#1 /srv/mediawiki/php-1.34.0-wmf.22/includes/libs/http/MultiHttpClient.php(203): MultiHttpClient->getCurlMulti(array)
#2 /srv/mediawiki/php-1.34.0-wmf.22/includes/libs/http/MultiHttpClient.php(169): MultiHttpClient->runMultiCurl(array, array)
#3 /srv/mediawiki/php-1.34.0-wmf.22/includes/libs/http/MultiHttpClient.php(132): MultiHttpClient->runMulti(array, array)
#4 /srv/mediawiki/php-1.34.0-wmf.22/extensions/EventBus/includes/EventBus.php(153): MultiHttpClient->run(array, array)
#5 /srv/mediawiki/php-1.34.0-wmf.22/extensions/EventBus/includes/adapters/monolog/EventBusMonologHandler.php(61): EventBus->send(array)
#6 /srv/mediawiki/php-1.34.0-wmf.22/includes/deferred/MWCallableUpdate.php(38): Closure$EventBusMonologHandler::write()
#7 /srv/mediawiki/php-1.34.0-wmf.22/includes/deferred/DeferredUpdates.php(383): MWCallableUpdate->doUpdate()
#8 /srv/mediawiki/php-1.34.0-wmf.22/includes/deferred/DeferredUpdates.php(281): DeferredUpdates::attemptUpdate(MWCallableUpdate, Wikimedia\Rdbms\LBFactoryMulti)
#9 /srv/mediawiki/php-1.34.0-wmf.22/includes/deferred/DeferredUpdates.php(234): DeferredUpdates::run(MWCallableUpdate, Wikimedia\Rdbms\LBFactoryMulti, Monolog\Logger, BufferingStatsdDataFactory, string)
#10 /srv/mediawiki/php-1.34.0-wmf.22/includes/deferred/DeferredUpdates.php(149): DeferredUpdates::handleUpdateQueue(array, string, integer)
#11 /srv/mediawiki/php-1.34.0-wmf.22/includes/MediaWiki.php(934): DeferredUpdates::doUpdates(string)
#12 /srv/mediawiki/php-1.34.0-wmf.22/includes/MediaWiki.php(758): MediaWiki->restInPeace(string, boolean)
#13 [internal function]: Closure$MediaWiki::doPostOutputShutdown()
#14 {main}
Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Revert "Improve MultiHttpClient connection concurrency and reuse"mediawiki/coremaster+56 -43
Revert "Improve MultiHttpClient connection concurrency and reuse"mediawiki/corewmf/1.34.0-wmf.22+56 -43
Group0 to 1.34.0-wmf.22operations/mediawiki-configmaster+130 -130
Customize query in gerrit

Related Objects
Search...

Event Timeline

hashar created this task.Sep 10 2019, 2:53 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 10 2019, 2:53 PM
hashar triaged this task as Unbreak Now! priority.Sep 10 2019, 2:54 PM
hashar added a project: Event-Platform.

Seems to be in Event-Platform?

Restricted Application added a project: Analytics. · View Herald TranscriptSep 10 2019, 2:54 PM
Restricted Application added a subscriber: Liuxinyu970226. · View Herald Transcript
Reedy subscribed.Sep 10 2019, 2:55 PM

https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/534642/

hashar added a comment.Sep 10 2019, 2:55 PM

Another:

#0 /srv/mediawiki/php-1.34.0-wmf.22/includes/libs/http/MultiHttpClient.php(423): MWExceptionHandler::handleError(integer, string, string, integer, array, array)
#1 /srv/mediawiki/php-1.34.0-wmf.22/includes/libs/http/MultiHttpClient.php(203): MultiHttpClient->getCurlMulti(array)
#2 /srv/mediawiki/php-1.34.0-wmf.22/includes/libs/http/MultiHttpClient.php(169): MultiHttpClient->runMultiCurl(array, array)
#3 /srv/mediawiki/php-1.34.0-wmf.22/includes/libs/http/MultiHttpClient.php(132): MultiHttpClient->runMulti(array, array)
#4 /srv/mediawiki/php-1.34.0-wmf.22/extensions/EventBus/includes/EventBus.php(153): MultiHttpClient->run(array, array)
#5 /srv/mediawiki/php-1.34.0-wmf.22/extensions/EventBus/includes/adapters/monolog/EventBusMonologHandler.php(61): EventBus->send(array)
#6 /srv/mediawiki/php-1.34.0-wmf.22/includes/deferred/MWCallableUpdate.php(38): Closure$EventBusMonologHandler::write()
#7 /srv/mediawiki/php-1.34.0-wmf.22/includes/deferred/DeferredUpdates.php(383): MWCallableUpdate->doUpdate()
#8 /srv/mediawiki/php-1.34.0-wmf.22/includes/deferred/DeferredUpdates.php(281): DeferredUpdates::attemptUpdate(MWCallableUpdate, Wikimedia\Rdbms\LBFactoryMulti)
#9 /srv/mediawiki/php-1.34.0-wmf.22/includes/deferred/DeferredUpdates.php(234): DeferredUpdates::run(MWCallableUpdate, Wikimedia\Rdbms\LBFactoryMulti, Monolog\Logger, BufferingStatsdDataFactory, string)
#10 /srv/mediawiki/php-1.34.0-wmf.22/includes/deferred/DeferredUpdates.php(149): DeferredUpdates::handleUpdateQueue(array, string, integer)
#11 /srv/mediawiki/php-1.34.0-wmf.22/includes/MediaWiki.php(934): DeferredUpdates::doUpdates(string)
#12 /srv/mediawiki/php-1.34.0-wmf.22/includes/MediaWiki.php(758): MediaWiki->restInPeace(string, boolean)
#13 [internal function]: Closure$MediaWiki::doPostOutputShutdown()
#14 {main}

21a95eb0-d3da-11e9-b447-15c577a7f50b

gerritbot added a comment.Sep 10 2019, 2:56 PM

Change 535621 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@master] Revert "Improve MultiHttpClient connection concurrency and reuse"

https://gerrit.wikimedia.org/r/535621

gerritbot added a project: Patch-For-Review.Sep 10 2019, 2:56 PM

Change 535622 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@wmf/1.34.0-wmf.22] Revert "Improve MultiHttpClient connection concurrency and reuse"

https://gerrit.wikimedia.org/r/535622

• mobrovac edited projects, added MediaWiki-General, Platform Team Workboards (Clinic Duty Team); removed Event-Platform.Sep 10 2019, 2:58 PM
Reedy added a comment.Sep 10 2019, 2:58 PM

Ping T232128: Make MultiHttpClient use CURLMOPT_MAX_HOST_CONNECTIONS and reuse connections

• mobrovac subscribed.Sep 10 2019, 3:07 PM

It turns out CURLMOPT_MAX_HOST_CONNECTIONS was introduced in PHP 7, so there's no support for it on HHVM. Sorry about missing that.

gerritbot added a comment.Sep 10 2019, 3:30 PM

Change 535622 merged by jenkins-bot:
[mediawiki/core@wmf/1.34.0-wmf.22] Revert "Improve MultiHttpClient connection concurrency and reuse"

https://gerrit.wikimedia.org/r/535622

Stashbot added a comment.Sep 10 2019, 3:33 PM

Mentioned in SAL (#wikimedia-operations) [2019-09-10T15:33:03Z] <reedy@deploy1001> Synchronized php-1.34.0-wmf.22/includes/libs/http/MultiHttpClient.php: T232487 (duration: 00m 55s)

Stashbot added a comment.Sep 10 2019, 3:35 PM

Mentioned in SAL (#wikimedia-operations) [2019-09-10T15:35:37Z] <hashar@deploy1001> Synchronized php-1.34.0-wmf.22/includes/libs/http/MultiHttpClient.php: Revert "Improve MultiHttpClient connection concurrency and reuse" - T232487 (duration: 00m 55s)

gerritbot added a comment.Sep 10 2019, 3:37 PM

Change 535629 had a related patch set uploaded (by Hashar; owner: Hashar):
[operations/mediawiki-config@master] Group0 to 1.34.0-wmf.22

https://gerrit.wikimedia.org/r/535629

gerritbot added a comment.Sep 10 2019, 3:38 PM

Change 535629 merged by jenkins-bot:
[operations/mediawiki-config@master] Group0 to 1.34.0-wmf.22

https://gerrit.wikimedia.org/r/535629

gerritbot added a comment.Sep 10 2019, 3:39 PM

Change 535621 merged by jenkins-bot:
[mediawiki/core@master] Revert "Improve MultiHttpClient connection concurrency and reuse"

https://gerrit.wikimedia.org/r/535621

Reedy closed this task as Resolved.Sep 10 2019, 3:39 PM
Reedy claimed this task.
Reedy removed a project: Patch-For-Review.
hashar added a comment.Sep 10 2019, 3:40 PM

Fixed on production by reverting the faulty patch. Thank you @mobrovac and @Reedy !

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.23; 2019-09-17).Sep 10 2019, 5:01 PM
aaron subscribed.Sep 10 2019, 11:32 PM

Odd, the constant seems to be there.

aaron@deployment-deploy01:~$ mwscript eval.php aawiki
> echo CURLMOPT_MAX_HOST_CONNECTIONS;
7
> echo phpversion();
5.6.99-hhvm
>
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits