Page MenuHomePhabricator

Provide mechanism for users to opt in to statement the copy functionality
Open, Needs TriagePublic

Description

User story: As an uploader, I want a way to apply my structured data edits to all files, so that I can avoid having to add data to each file manually when I do a batch upload.

We have this:
There's existing functionality, but it's hidden behind config that is turned off by default and can only be enabled in campaigns: T231225
We want to explore rolling this out more widely, so let's build something that would allow people to opt in to that functionality.

We want this:
When a certain value is present in the UploadWizard querystring (e.g. ?allowCopy=1), enable/disable the copy functionality

Acceptance Criteria:

  • When a certain value is present in the UploadWizard querystring (e.g. ?allowCopy=1), the copy functionality is enabled/disabled accordingly

Details

Related Gerrit Patches:
mediawiki/extensions/UploadWizard : masterFix copy-statement functionality
mediawiki/extensions/WikibaseMediaInfo : masterUse valueType instead of propertyType
mediawiki/extensions/UploadWizard : masterAllow enabling the copy-statements button from a querystring param

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 10 2019, 4:39 PM
matthiasmullie moved this task from To Do to Doing on the Structured Data Engineering board.

Change 538871 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/UploadWizard@master] Allow enabling the copy-statements button from a querystring param

https://gerrit.wikimedia.org/r/538871

Change 538871 merged by jenkins-bot:
[mediawiki/extensions/UploadWizard@master] Allow enabling the copy-statements button from a querystring param

https://gerrit.wikimedia.org/r/538871

Ramsey-WMF added a subscriber: Ramsey-WMF.EditedOct 24 2019, 12:21 AM

@matthiasmullie On production, this half works. The Copy to All files button does appear, but when clicking it to apply statements, those statements do not appear on the other files

Matthias to re-test on production this week.

Change 559707 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] Use valueType instead of propertyType

https://gerrit.wikimedia.org/r/559707

Change 559709 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/UploadWizard@master] Fix copy-statement functionality

https://gerrit.wikimedia.org/r/559709

This has indeed broken! Patches are up, but will take some time to land with the holidays.

Change 559707 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Use valueType instead of propertyType

https://gerrit.wikimedia.org/r/559707

This code was supposed to be merged, but it's still not working on Beta. The copy to all button appears but does not actually copy the data

There are 2 parts to this ticket, and only the WikibaseMediaInfo patch has been merged thus far. There is still a patch for UploadWizard (https://gerrit.wikimedia.org/r/c/mediawiki/extensions/UploadWizard/+/559709) in code review.

Change 559709 merged by jenkins-bot:
[mediawiki/extensions/UploadWizard@master] Fix copy-statement functionality

https://gerrit.wikimedia.org/r/559709

Tested on Beta and it works! Hopefully it works on prod :)