Page MenuHomePhabricator
Create Task
Maniphest T232499

Provide mechanism for users to opt in to statement the copy functionality
Closed, ResolvedPublic
Actions

Description

User story: As an uploader, I want a way to apply my structured data edits to all files, so that I can avoid having to add data to each file manually when I do a batch upload.

We have this:
There's existing functionality, but it's hidden behind config that is turned off by default and can only be enabled in campaigns: T231225
We want to explore rolling this out more widely, so let's build something that would allow people to opt in to that functionality.

We want this:
When a certain value is present in the UploadWizard querystring (e.g. ?allowCopy=1), enable/disable the copy functionality

Acceptance Criteria:

  • When a certain value is present in the UploadWizard querystring (e.g. ?allowCopy=1), the copy functionality is enabled/disabled accordingly

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/UploadWizardmaster+57 -34Fix copy-statement functionality
mediawiki/extensions/WikibaseMediaInfomaster+25 -17Use valueType instead of propertyType
mediawiki/extensions/UploadWizardmaster+4 -2Allow enabling the copy-statements button from a querystring param
Customize query in gerrit

Related Objects

Event Timeline

matthiasmullie created this task.Sep 10 2019, 4:39 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 10 2019, 4:39 PM
matthiasmullie added a project: UploadWizard.Sep 10 2019, 4:40 PM
matthiasmullie claimed this task.Sep 23 2019, 4:28 PM
matthiasmullie moved this task from To Do to Doing on the Structured Data Engineering board.
gerritbot added a comment.Sep 24 2019, 12:09 PM

Change 538871 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/UploadWizard@master] Allow enabling the copy-statements button from a querystring param

https://gerrit.wikimedia.org/r/538871

gerritbot added a project: Patch-For-Review.Sep 24 2019, 12:09 PM
matthiasmullie moved this task from Incoming to Code Review on the Structured-Data-Backlog (Current Work) board.Sep 24 2019, 12:10 PM
gerritbot added a comment.Oct 8 2019, 10:52 AM

Change 538871 merged by jenkins-bot:
[mediawiki/extensions/UploadWizard@master] Allow enabling the copy-statements button from a querystring param

https://gerrit.wikimedia.org/r/538871

matthiasmullie moved this task from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.Oct 8 2019, 10:53 AM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.1; 2019-10-08).Oct 8 2019, 11:00 AM
Maintenance_bot removed a project: Patch-For-Review.Oct 8 2019, 11:10 AM
Ramsey-WMF added a subscriber: Ramsey-WMF.EditedOct 24 2019, 12:21 AM

@matthiasmullie On production, this half works. The Copy to All files button does appear, but when clicking it to apply statements, those statements do not appear on the other files

Ramsey-WMF added a comment.Dec 16 2019, 5:48 PM

Matthias to re-test on production this week.

gerritbot added a comment.Dec 20 2019, 9:23 AM

Change 559707 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] Use valueType instead of propertyType

https://gerrit.wikimedia.org/r/559707

gerritbot added a project: Patch-For-Review.Dec 20 2019, 9:23 AM
gerritbot added a comment.Dec 20 2019, 9:35 AM

Change 559709 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/UploadWizard@master] Fix copy-statement functionality

https://gerrit.wikimedia.org/r/559709

matthiasmullie added a comment.Dec 20 2019, 9:36 AM

This has indeed broken! Patches are up, but will take some time to land with the holidays.

Ramsey-WMF moved this task from Needs QA to Code Review on the Structured-Data-Backlog (Current Work) board.Dec 20 2019, 5:57 PM
gerritbot added a comment.Jan 8 2020, 4:31 PM

Change 559707 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Use valueType instead of propertyType

https://gerrit.wikimedia.org/r/559707

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.15; 2020-01-14); removed MW-1.35-notes (1.35.0-wmf.1; 2019-10-08).Jan 8 2020, 5:00 PM
Ramsey-WMF moved this task from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.Jan 13 2020, 5:34 PM
Ramsey-WMF added a comment.Jan 14 2020, 2:41 AM

This code was supposed to be merged, but it's still not working on Beta. The copy to all button appears but does not actually copy the data

matthiasmullie added a comment.Jan 14 2020, 8:18 AM

There are 2 parts to this ticket, and only the WikibaseMediaInfo patch has been merged thus far. There is still a patch for UploadWizard (https://gerrit.wikimedia.org/r/c/mediawiki/extensions/UploadWizard/+/559709) in code review.

matthiasmullie moved this task from Needs QA to Code Review on the Structured-Data-Backlog (Current Work) board.Jan 14 2020, 8:19 AM
gerritbot added a comment.Jan 14 2020, 11:50 AM

Change 559709 merged by jenkins-bot:
[mediawiki/extensions/UploadWizard@master] Fix copy-statement functionality

https://gerrit.wikimedia.org/r/559709

Maintenance_bot removed a project: Patch-For-Review.Jan 14 2020, 12:10 PM
matthiasmullie moved this task from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.Jan 16 2020, 8:28 AM
Ramsey-WMF moved this task from Needs QA to Verify on Production on the Structured-Data-Backlog (Current Work) board.Jan 17 2020, 1:51 AM

Tested on Beta and it works! Hopefully it works on prod :)

Ramsey-WMF closed this task as Resolved.Feb 6 2020, 9:30 PM

Tested on production and works.

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL