Page MenuHomePhabricator

GB credit card form - Postal code field wraps to next line
Closed, ResolvedPublic

Description

For the GB credit card form, both control and the new labels variant the Postal code field is wrapping onto the next line instead of being to the right of the City field. Confirmed on Chrome, Firefox, Safari.

This is odd, as these fields look to have the same "halfwidth" styles as the First name and Last name fields which are positioned as expected.

Not sure if this was introduced in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/531941 or https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/531766

Event Timeline

Pcoombe created this task.Sep 10 2019, 5:35 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 10 2019, 5:35 PM

Change 535662 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@master] Trim trailing spaces from mustache partials

https://gerrit.wikimedia.org/r/535662

Ejegg claimed this task.Sep 10 2019, 6:24 PM
Ejegg triaged this task as High priority.
Ejegg moved this task from Triage to Current Sprint on the Fundraising-Backlog board.

Change 535662 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Trim trailing newlines from mustache partials

https://gerrit.wikimedia.org/r/535662

Ejegg closed this task as Resolved.Sep 10 2019, 8:46 PM

OK, deployed a tiny patch to trim trailing newlines from the partial templates, and it seems to have fixed the wrapping issue. Thanks for spotting this @Pcoombe !