Page MenuHomePhabricator

Watchstar should not extend the Icon class
Closed, ResolvedPublic


The Watchstar confusingly is not an Icon - it contains logic for handling clicks to the watchstar.

We also have an icons.watchIcon helper class which is uses.

The icons.watchIcon helper should accept parameters, and the entire Watchstar class should become a function that creates and manages a watchIcon and watchedIcon.

Developer notes

Experimented with this here: WIP: Replace Watchstar class with an icon helper

Event Timeline

Jdlrobson renamed this task from Watchstar is not an Icon to Watchstar should not extend the Icon class.Sep 10 2019, 7:02 PM
Jdlrobson created this task.