Page MenuHomePhabricator
Create Task
Maniphest T232528

Pasting multiple list items in VisualEditor in Firefox results in incorrect display and saving
Open, Needs TriagePublic
Actions

Description

Steps to reproduce

  1. Create an unordered list.
  2. Open an empty list item by pressing return at the end of one of the lines.
  3. Copy multiple existing list items and paste it into the new empty one.
  4. The editor displays the pasted list items as a sublist, but with an incorrect double bullet:
    Screen Shot 2019-09-11 at 01.39.59.png (348×228 px, 14 KB)
  5. Save the page.
  6. The two pasted list items have disappeared; instead, only an empty list item (wikitext *) has been saved:
    Screen Shot 2019-09-11 at 01.43.54.png (678×2 px, 100 KB)

Found in Firefox 70.0b5 on macOS 10.14.6

Related Objects

Event Timeline

nshahquinn created this task.Sep 10 2019, 8:19 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 10 2019, 8:19 PM
nshahquinn mentioned this in T124730: Pasting list items in VisualEditor results in confusing behavior.Sep 10 2019, 8:20 PM
Esanders added a project: VisualEditor-ContentEditable.Sep 16 2019, 12:26 PM
Esanders added subscribers: dchan, Esanders.

This happens when the selection starts in the slug above the list. Such a selection can't be created in Chrome, but in FF you can create it by selecting backwards and ending your selection above the list. The selection then starts at offset 0.

Esanders added a comment.Sep 16 2019, 1:56 PM

Indeed in this situation an exception is thrown on copy

TypeError: startNode is null ve.dm.Document.js:535:14
    shallowCloneFromRange http://localhost/VisualEditor/lib/ve/src/dm/ve.dm.Document.js:535
    shallowCloneFromSelection http://localhost/VisualEditor/lib/ve/src/dm/ve.dm.Document.js:446
    onCopy http://localhost/VisualEditor/lib/ve/src/ce/ve.ce.Surface.js:1929
ppelberg moved this task from To Triage to FY 19-20 on the VisualEditor board.Oct 22 2019, 3:35 PM
Jdlrobson added a project: Wikimedia-production-error.Oct 14 2020, 7:05 PM
Jdlrobson subscribed.

In logstash: https://logstash.wikimedia.org/app/kibana#/doc/logstash-*/logstash-2020.10.14/clienterror/?id=AXUnsIFv1pGl6xFMEDqf

Krinkle moved this task from Untriaged to Oct 2020 on the Wikimedia-production-error board.Oct 23 2020, 7:49 PM
Krinkle moved this task from Oct 2020 to Sep 2020 on the Wikimedia-production-error board.
Krinkle moved this task from Sep 2020 to Oct 2020 on the Wikimedia-production-error board.
matmarex mentioned this in T279321: TypeError: Cannot read property 'isWrapped' of null in shallowCloneFromRange.Dec 16 2021, 8:03 PM
Krinkle moved this task from Oct 2020 to Older on the Wikimedia-production-error board.Sep 8 2022, 4:23 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits