Page MenuHomePhabricator

Civi: restore search settings to pre-September update
Closed, ResolvedPublic

Description

DS agents are reporting some unhelpful changes in search after the recent update:

1 - Civi no longer removes trailing spaces (and initial ?) in email search terms. It would be great if it could go back to accepting "mbeattie@wikimedia.org " and if possible to also accept " mbeattie@wikimedia.org"

2 - “two surnames, and normally if you plug the just first surname in, it will find the match anyway, but in this case it didn’t.” Please remove the exact match requirement in name search field, it's super helpful to find "Beattie Gomez" just by searching for "Beattie", for example

3 - One very strange inconsistency is that DS agent cid=21041858 is unable to locate this donor, cid=22001704, by "surname, first name". We did a hangout to troubleshoot this, and I am able to find them by "surname, first name". She tried logging out and back in, and tried variations using CAPS etc, but it literally just will not appear; she can find them via email but any suggestions to what's going on would be helpful.

Event Timeline

Change 535746 had a related patch set uploaded (by Eileen; owner: Eileen):
[wikimedia/fundraising/crm/civicrm@master] Trim values entered in email (& similar) fields when treating as LIKE

https://gerrit.wikimedia.org/r/535746

@MBeat33 I have a patch in review that I think will fix one and 2

Was 3 already deleted when you were testing?

Change 535746 merged by jenkins-bot:
[wikimedia/fundraising/crm/civicrm@master] Trim values entered in email (& similar) fields when treating as LIKE

https://gerrit.wikimedia.org/r/535746

@MBeat33 I've deployed a fix that I think will work for 1 & 2 - for 3 the contact is deleted so I'm not quite sure what to make of it. Maybe she had an extra space like 1 & 2?

Thank you @Eileenmcnaughton. The search by surname, firstname should find cid=35133991 which is the same donor. We tried every combination of search terms we could, with and without spaces. I will ask her to see if it's still not appearing in the results: if so, would clearing the browser cache possibly help?

Yes please - can you confirm it's still a thing today

Ok, she's able to use the search now, so I think this is all set. Thanks for the patches.

good to hear - that was definitely confusing