Page MenuHomePhabricator

Solve run-job lockfile name collision
Closed, ResolvedPublic1 Story Points

Description

In process-control, lockfile names contain the username and the filename of the script, but not the path. So when the audit/astropay/download_nightly script was hung up, the presence of the jenkins-download_nightly.lock file was preventing us from running audit/paypal/download_nightly even though that's a different script.

Figure out a smarter way to name the lockfile.

Event Timeline

Ejegg created this task.Wed, Sep 11, 3:02 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptWed, Sep 11, 3:02 PM

Oops, this is not the lockfile created by process-control, but the lock file created by tools scripts.

Maybe we can replace at least one of these download_nightly scripts with the bash script written by @cwdent

Change 536362 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/tools@master] Rename download jobs to avoid lock collision

https://gerrit.wikimedia.org/r/536362

Change 536362 merged by jenkins-bot:
[wikimedia/fundraising/tools@master] Rename download jobs to avoid lock collision

https://gerrit.wikimedia.org/r/536362

Ejegg closed this task as Resolved.Sat, Sep 14, 1:17 AM
Ejegg claimed this task.
Ejegg triaged this task as Normal priority.
Ejegg set the point value for this task to 1.

Deployed a workaround, just renaming the two scripts that were colliding. Since this is in the old tools lockfile code, let's not touch it further.