Page MenuHomePhabricator

Add Extension:Patroller to translatewiki.net
Closed, DeclinedPublic

Description

Extension:Patroller has translations currently in its files, but not available on translatewiki.

Event Timeline

For the records, I'm wondering how actively maintained this extension is: https://phabricator.wikimedia.org/T232985#5495572

I am still supporting this extension actively :)

From a quick look I think some message keys at https://github.com/wikimedia/mediawiki-extensions-Patroller/blob/master/i18n/en.json conflict with already-existing keys both in MediaWiki core and translatewiki.net extensions. I'm not sure that'd be a blocker here. Ping @Raymond.

From a quick look I think some message keys at https://github.com/wikimedia/mediawiki-extensions-Patroller/blob/master/i18n/en.json conflict with already-existing keys both in MediaWiki core and translatewiki.net extensions. I'm not sure that'd be a blocker here. Ping @Raymond.

Message keys need to be unique over core and all extensions. I suggest to change non-unique keys.

@MarcoAurelio I just did a quick search over on translatewiki for "patrol", and can't seem to find any keys that would match this.

Are you able to confirm if there are any?

None of the keys seems to conflict now. There are pages like https://translatewiki.net/wiki/MediaWiki:Patrol-revert-reason/en but they seem to be a previous import of this code in 2008 and are not currently used.

>>> $keys = explode( ' ', 'patrol patrol-desc patrol-endorse patrol-revert patrol-revert-reason patrol-skip patrol-reverting patrol-nonefound patrol-endorsed-ok patrol-endorsed-failed patrol-reverted-ok patrol-reverted-failed patrol-skipped-ok patrol-reasons patrol-another patrol-stopped patrol-resume group-patroller group-patroller-member grouppage-patroller action-patroller right-patroller group-patroller.css group-patroller.js' );
=> [
     "patrol",
     "patrol-desc",
     "patrol-endorse",
     "patrol-revert",
     "patrol-revert-reason",
     "patrol-skip",
     "patrol-reverting",
     "patrol-nonefound",
     "patrol-endorsed-ok",
     "patrol-endorsed-failed",
     "patrol-reverted-ok",
     "patrol-reverted-failed",
     "patrol-skipped-ok",
     "patrol-reasons",
     "patrol-another",
     "patrol-stopped",
     "patrol-resume",
     "group-patroller",
     "group-patroller-member",
     "grouppage-patroller",
     "action-patroller",
     "right-patroller",
     "group-patroller.css",
     "group-patroller.js",
   ]
>>> foreach ( $keys as $key ) { $title = Title::makeTitleSafe( NS_MEDIAWIKI, $key ); var_dump( $key, ( new MessageHandle( $title ) )->getGroupIds() ); }
string(6) "patrol"
array(0) {
}
string(11) "patrol-desc"
array(0) {
}
string(14) "patrol-endorse"
array(0) {
}
string(13) "patrol-revert"
array(0) {
}
string(20) "patrol-revert-reason"
array(0) {
}
string(11) "patrol-skip"
array(0) {
}
string(16) "patrol-reverting"
array(0) {
}
string(16) "patrol-nonefound"
array(0) {
}
string(18) "patrol-endorsed-ok"
array(0) {
}
string(22) "patrol-endorsed-failed"
array(0) {
}
string(18) "patrol-reverted-ok"
array(0) {
}
string(22) "patrol-reverted-failed"
array(0) {
}
string(17) "patrol-skipped-ok"
array(0) {
}
string(14) "patrol-reasons"
array(0) {
}
string(14) "patrol-another"
array(0) {
}
string(14) "patrol-stopped"
array(0) {
}
string(13) "patrol-resume"
array(0) {
}
string(15) "group-patroller"
array(0) {
}
string(22) "group-patroller-member"
array(0) {
}
string(19) "grouppage-patroller"
array(0) {
}
string(16) "action-patroller"
array(0) {
}
string(15) "right-patroller"
array(0) {
}
string(19) "group-patroller.css"
array(0) {
}
string(18) "group-patroller.js"
array(0) {
}

@Raymond Are there any other blockers for adding this extension?

@Raymond Are there any other blockers for adding this extension?

No, just the prefix of the message keys should be changed form "patrol-" to "patroller-"

Nikerabbit changed the task status from Open to Stalled.Jan 18 2022, 2:19 PM

Closing due to lack of response. Feel free to reopen once the messages are prefixed.