Mobile logout should not involve an interstitial
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	Tgr
	Sep 12 2019, 12:00 PM

Description

Without Javascript, clicking on the logout link on desktop will take you to an interstitial where you have to press a button to log out. (This is to avoid writes on a GET request, and to some extent for CSRF security.) With Javascript, the logout happens via an AJAX request (added in T222626) and the user does not see the interstitial.

For mobile the same thing was not done - clicking logout takes the user to the interstitial (regardless of Javascript being enabled/disabled), which is not great UX.

Developer notes

Per the direction in T232734#5501722 we will copy/pasta the code from core into Minerva.

Code that has to be used here can be found here: https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/506386/

Details

Project	Branch	Lines +/-	Subject
mediawiki/skins/MinervaNeue	master	+46 -10	Logout users via API Ajax call to prevent extra step on Special:Logout
mediawiki/skins/MinervaNeue	master	+88 -180	Hygiene: Remove PageActionMenuEntry
mediawiki/skins/MinervaNeue	master	+63 -36	Hygiene: Drop optional parameters from SingleMenuEntry constructor

Customize query in gerrit

Related Objects

Mentioned In: T222626: Turn logout link into a POST API call with refresh
T225879: The logout link on Special::UserLogout doesn't respect mobile domain
Mentioned Here: T111565: Enable collapsible templates (including infoboxes) on mobile
T222626: Turn logout link into a POST API call with refresh

Event Timeline

Tgr created this task.Sep 12 2019, 12:00 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 12 2019, 12:00 PM

Tgr mentioned this in T225879: The logout link on Special::UserLogout doesn't respect mobile domain.Sep 12 2019, 12:01 PM

Tgr mentioned this in T222626: Turn logout link into a POST API call with refresh.

Looks like the code uses mediawiki.page.ready which is not loaded on mobile for various reasons. @Ladsgroup Can that code be made available in its own dedicated module?

Jdlrobson assigned this task to ovasileva.Sep 17 2019, 5:02 PM

Jdlrobson moved this task from Incoming to Needs Prioritization on the Readers-Web-Backlog board.

In T232734#5497639, @Jdlrobson wrote:

Looks like the code uses mediawiki.page.ready which is not loaded on mobile for various reasons. @Ladsgroup Can that code be made available in its own dedicated module?

We decided against putting the code in shared place given the overhead of registering new modules. The code is so short that copy-pasting it should not that bad. Thoughts @Krinkle ?

Indeed, the code is a trivial 1-line API call. Should be fine for minerva to use directly in its own code, probably also easier to maintain that way. See T111565 for the larger task of sharing this module between desktop and mobile.

@alexhollender - any thoughts here?

For clarification are we talking about this screen?

en.m.wikipedia.org_w_index.php_title=Special_UserLogout&returnto=Comparison+of+functional+programming+languages&logoutToken=feb3ebebd55a208c99462c41177e0cd05da5d6db%2B%5C(iPhone 6_7_8).png (1×750 px, 66 KB)

I am seeing this even with Javascript enabled (@Jdlrobson you once mentioned that this was due to something that was implemented during the Prague hackathon). I agree that (in both cases) we don't need a confirmation screen for logging out.

This task is about removing that screen altogether by making logout a single click. This screen is a regression from a change in core that we've never prioritised and the fix is pretty straightforward.

In T232734#5575398, @Jdlrobson wrote:

This task is about removing that screen altogether by making logout a single click. This screen is a regression from a chance in core that we've never prioritised and the fix is pretty straightforward.

Sounds good.

alexhollender_WMF updated the task description. (Show Details)Oct 15 2019, 2:37 PM

I think this is one of our more damaging but easy to fix open bugs and im a bit worried it will be forgotten in triaged but future.

In T232734#5575656, @Jdlrobson wrote:

I think this is one of our more damaging but easy to fix open bugs and im a bit worried it will be forgotten in triaged but future.

Logout rates are actually pretty low, but if it's an easy fix let's do it.

ovasileva removed ovasileva as the assignee of this task.Oct 15 2019, 4:01 PM

ovasileva added a subscriber: ovasileva.

Jdlrobson updated the task description. (Show Details)Oct 15 2019, 5:33 PM

Restricted Application added a subscriber: Masumrezarock100. · View Herald TranscriptOct 15 2019, 5:33 PM

Jdlrobson moved this task from Needs Analysis to Upcoming on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.Oct 15 2019, 5:33 PM

ovasileva set the point value for this task to 2.Oct 17 2019, 5:28 PM

ovasileva moved this task from Upcoming to Ready for Development on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.

• pmiazga updated the task description. (Show Details)Oct 17 2019, 5:34 PM

• pmiazga claimed this task.Oct 22 2019, 3:13 PM

• pmiazga moved this task from Ready for Development to Doing on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.

Change 545392 had a related patch set uploaded (by Pmiazga; owner: Pmiazga):
[mediawiki/skins/MinervaNeue@master] Logout users via API Ajax call to prevent extra step on Special:Logout

https://gerrit.wikimedia.org/r/545392

gerritbot added a project: Patch-For-Review.Oct 22 2019, 9:07 PM

• pmiazga removed • pmiazga as the assignee of this task.Oct 23 2019, 5:06 PM

• pmiazga moved this task from Doing to Needs Code Review on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.

• pmiazga added a subscriber: • pmiazga.

Jdlrobson moved this task from Needs Code Review to Needs More Work on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.Oct 24 2019, 7:31 PM

Krinkle removed a subscriber: Krinkle.Oct 25 2019, 12:26 AM

Jdlrobson moved this task from Needs More Work to Ready for Signoff on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.Oct 30 2019, 5:09 PM

ovasileva moved this task from Ready for Signoff to Blocked on Others on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.Oct 30 2019, 5:09 PM

We are going to wait till @pmiazga gets back to do this one.

Jdlrobson assigned this task to • pmiazga.Oct 30 2019, 5:13 PM

• pmiazga moved this task from Blocked on Others to Doing on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.Nov 4 2019, 6:04 PM

Jdlrobson moved this task from Doing to Blocked on Others on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.Nov 5 2019, 6:21 PM

• pmiazga moved this task from Blocked on Others to Doing on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.Nov 6 2019, 6:04 PM

Change 549642 had a related patch set uploaded (by Pmiazga; owner: Pmiazga):
[mediawiki/skins/MinervaNeue@master] Hygiene: Drop optional parameters from SingleMenuEntry constructor

https://gerrit.wikimedia.org/r/549642

Change 549643 had a related patch set uploaded (by Pmiazga; owner: Pmiazga):
[mediawiki/skins/MinervaNeue@master] Hygiene: Remove PageActionMenuEntry

https://gerrit.wikimedia.org/r/549643

• pmiazga moved this task from Doing to Needs Code Review on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.Nov 7 2019, 10:03 PM

Change 549642 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Hygiene: Drop optional parameters from SingleMenuEntry constructor

https://gerrit.wikimedia.org/r/549642

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.8; 2019-11-26).Nov 11 2019, 10:00 PM

Jdlrobson moved this task from Needs Code Review to Needs QA on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.Nov 26 2019, 10:35 PM

Change 549643 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Hygiene: Remove PageActionMenuEntry

https://gerrit.wikimedia.org/r/549643

Change 545392 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Logout users via API Ajax call to prevent extra step on Special:Logout

https://gerrit.wikimedia.org/r/545392

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.10; 2019-12-10); removed MW-1.35-notes (1.35.0-wmf.8; 2019-11-26).Nov 26 2019, 11:00 PM

Maintenance_bot removed a project: Patch-For-Review.Nov 26 2019, 11:10 PM

Tested on Beta cluster - works as expected

• pmiazga removed • pmiazga as the assignee of this task.Dec 9 2019, 6:15 PM

Thanks @pmiazga, resolving this now.

	F30721252: en.m.wikipedia.org_w_index.php_title=Special_UserLogout&returnto=Comparison+of+functional+programming+languages&logoutToken=feb3ebebd55a208c99462c41177e0cd05da5d6db%2B%5C(iPhone 6_7_8).png
	Oct 15 2019, 2:29 PM

Mobile logout should not involve an interstitialClosed, ResolvedPublic2 Estimated Story PointsActions