Several tests in Wikibase CI failing with “Invalid argument supplied for foreach()” in PermissionManager
Closed, ResolvedPublic
Actions

Description

Example change: https://gerrit.wikimedia.org/r/536137
Example log: https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php72-docker/19112/console

13:44:29 Invalid argument supplied for foreach()
13:44:29 
13:44:29 /workspace/src/includes/Permissions/PermissionManager.php:1373
13:44:29 /workspace/src/includes/Permissions/PermissionManager.php:1271
13:44:29 /workspace/src/includes/Permissions/PermissionManager.php:1216
13:44:29 /workspace/src/includes/specialpage/SpecialPage.php:297
13:44:29 /workspace/src/includes/specialpage/SpecialPage.php:316
13:44:29 /workspace/src/includes/specialpage/SpecialPage.php:623
13:44:29 /workspace/src/extensions/WikibaseLexeme/src/MediaWiki/Specials/SpecialNewLexeme.php:94
13:44:29 /workspace/src/tests/phpunit/includes/specials/SpecialPageExecutor.php:108
13:44:29 /workspace/src/tests/phpunit/includes/specials/SpecialPageExecutor.php:36
13:44:29 /workspace/src/tests/phpunit/includes/specials/SpecialPageTestBase.php:70
13:44:29 /workspace/src/extensions/WikibaseLexeme/tests/phpunit/mediawiki/Specials/SpecialNewLexemeTest.php:124
13:44:29 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:454
13:44:29 /workspace/src/maintenance/doMaintenance.php:99

Happens three times, all in SpecialNewLexemeTest (L104, L113, L124).

I suspect it’s due to I2341e6f1d1 (part of T220191).

Details

	Subject	Repo	Branch	Lines +/-
	Fix SpecialNewLexemeTest after permissions update	mediawiki/extensions/WikibaseLexeme	master	+25 -36

Customize query in gerrit

Related Objects

Mentioned Here: T220191: Remove calls to deprecated methods in Title and User with calls to the new PermissionManager service.

Event Timeline

Lucas_Werkmeister_WMDE created this task.Sep 12 2019, 2:21 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 12 2019, 2:21 PM

Lucas_Werkmeister_WMDE added subscribers: • Pchelolo, daniel.Sep 12 2019, 2:22 PM

Call chain:

PermissionManager.php

$this->usersRights[ $rightsCacheKey ] = $this->getGroupPermissions(
	$user->getEffectiveGroups()
);

PermissionManager.php

public function getGroupPermissions( $groups ) {
	$rights = [];
	// grant every granted permission first
	foreach ( $groups as $group ) {

I guess it’s because this method of SpecialNewLexemeTest doesn’t mock the user’s groups:

	private function getMockBlockedUser( $block ) {
		$user = $this->getMockBuilder( \User::class )
			->disableOriginalConstructor()
			->getMock();
		$user->method( 'getBlock' )
			->willReturn( $block );
		$user->method( 'isAllowed' )
			->willReturn( true );

		return $user;
	}

(I wonder if there’s a reason why this doesn’t use $this->getTestUser()?)

Lucas_Werkmeister_WMDE claimed this task.Sep 12 2019, 2:45 PM

Change 536212 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Fix SpecialNewLexemeTest after permissions update

https://gerrit.wikimedia.org/r/536212

gerritbot added a project: Patch-For-Review.Sep 12 2019, 3:02 PM

Lucas_Werkmeister_WMDE added a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)).Sep 12 2019, 3:03 PM

Lucas_Werkmeister_WMDE moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

Change 536212 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Fix SpecialNewLexemeTest after permissions update

https://gerrit.wikimedia.org/r/536212

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.23; 2019-09-17).Sep 12 2019, 5:00 PM

Maintenance_bot removed a project: Patch-For-Review.Sep 12 2019, 5:10 PM

Some other changes were successfully merged, so it looks like this was fixed successfully :)

Several tests in Wikibase CI failing with “Invalid argument supplied for foreach()” in PermissionManagerClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Several tests in Wikibase CI failing with “Invalid argument supplied for foreach()” in PermissionManager
Closed, ResolvedPublic
Actions