Updated the task description to include the events we need to test and the instructions for testing them.

@DLynch before handing this over to @Ryasmeen, can you confirm the "Actions and events" section is accurate and exhaustive? I was largely pulling from the table you posted in T229079#5475532 (this was helpful – thank you).

Updating the "Instructions" portion of the task description to not make mention of particular schemas.

@ppelberg: I went ahead and gave it a round of testing. I have noted my observations. The only thing is, for all events the word save. is not appended. And the last two events are firing twice.

If these issues are expected, I will mark it as verified :)

It should all be mwSave as the feature and then the dialog-whatever as the action.

In T232790#5520979, @Ryasmeen wrote:

@ppelberg: I went ahead and gave it a round of testing. I have noted my observations. The only thing is, for all events the word save. is not appended. And the last two events are firing twice.

If these issues are expected, I will mark it as verified :)

Thanks, Rummana. As to whether the observation you made are expected or not, I'm going to ask David to confirm...

@DLynch, I've updated the events in the "Event that should fire" column in the task description to follow the naming pattern you shared in T232790#5521207: for each row in the table in the task description, can you confirm whether what Rummana experienced is expected or not? And if not, what she should expect to see?

Everything Rummana saw looks correct, it's just a confusion about what the event name is. For the VisualEditorFeatureUse events it's two-part, there's a feature and action component, with the name being written here as [feature].[action].

e.g. this console log shows the mwSave.checkbox-wpWatchthis event:

That said, the "Yes, but it's getting fired twice" shouldn't be firing twice. But I can't reproduce that myself, so I might need more information.

That said, the "Yes, but it's getting fired twice" shouldn't be firing twice. But I can't reproduce that myself, so I might need more information.

Never mind, worked it out, patch incoming.

Change 540628 had a related patch set uploaded (by DLynch; owner: DLynch):
[mediawiki/extensions/VisualEditor@master] ui.MWSaveDialog: checkbox tracking was getting duplicated on every setup

https://gerrit.wikimedia.org/r/540628

Change 540628 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] ui.MWSaveDialog: checkbox tracking was getting duplicated on every setup

https://gerrit.wikimedia.org/r/540628

In T232790#5544653, @DLynch wrote:

Everything Rummana saw looks correct, it's just a confusion about what the event name is. For the VisualEditorFeatureUse events it's two-part, there's a feature and action component, with the name being written here as [feature].[action].

e.g. this console log shows the mwSave.checkbox-wpWatchthis event:

Got it. Thank you for demonstrating this and for updating the task description accordingly, David.

In T232790#5544672, @DLynch wrote:

That said, the "Yes, but it's getting fired twice" shouldn't be firing twice. But I can't reproduce that myself, so I might need more information.

Never mind, worked it out, patch incoming.

Excellent.

Next steps...

• @Ryasmeen, all that's left now is to test the two actions in the table below that you correctly identified as being fired twice in your initial testing:

@ppelberg and @DLynch : I am working on the post deployment data checks and had a few queries.

1. Can you please confirm if this scenario is working as expected ?

2. Can you please also clarify what do we expect to get here ?

When does the dialog-review vs dialog-preview get fired ?

In T232790#5545449, @ppelberg wrote:

In T232790#5544653, @DLynch wrote:

Everything Rummana saw looks correct, it's just a confusion about what the event name is. For the VisualEditorFeatureUse events it's two-part, there's a feature and action component, with the name being written here as [feature].[action].

e.g. this console log shows the mwSave.checkbox-wpWatchthis event:

Got it. Thank you for demonstrating this and for updating the task description accordingly, David.

In T232790#5544672, @DLynch wrote:

That said, the "Yes, but it's getting fired twice" shouldn't be firing twice. But I can't reproduce that myself, so I might need more information.

Never mind, worked it out, patch incoming.

Excellent.

Next steps...

• @Ryasmeen, all that's left now is to test the two actions in the table below that you correctly identified as being fired twice in your initial testing:

Action	Event that should fire	Did event fire? Y/N	Notes
tap "This is a minor edit" checkbox in the "Save your changes" screen	VisualEditorFeatureUse: mwSave.checkbox-wpMinoredit	Yes, but it's getting fired twice
tap the "Watch this page" checkbox in the "Save your changes" screen	VisualEditorFeatureUse: mwSave.checkbox-wpWatchthis	Yes, but it's getting fired twice

@ppelberg: Checked just now, both the events are now firing once as expected :)