| • nray | |
| Sep 12 2019, 11:39 PM |
| F30398400: T232798.png | |
| Sep 19 2019, 3:34 PM |
| F30381445: image.png | |
| Sep 17 2019, 5:28 PM |
| F30313187: Screen Shot 2019-09-12 at 5.31.03 PM.png | |
| Sep 12 2019, 11:39 PM |
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T232798#5506616 |
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| mobile.init/fakeToolbar: Update styles for icon changes | mediawiki/extensions/MobileFrontend | master | +4 -6 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | ovasileva | T226562 AMC - display labels for toolbar actions on larger screens | |||
| Resolved | • alexhollender_WMF | T229440 [EPIC] Refactor icon sizing in MF/Minerva to achieve consistency | |||
| Resolved | BUG REPORT | ovasileva | T232798 [Regression] ICONS "Close" text appears below close icon when loading editor overlay |
Change 536386 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/MobileFrontend@master] mobile.init/fakeToolbar: Update styles for icon changes
Change 536386 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] mobile.init/fakeToolbar: Update styles for icon changes
There is still an issue with this element, however the issue described in the task has been fixed so I suggest we close this and I will open a new task to address the gap at the bottom of the header, which may be related to T215426, and the fact that the "Loading" element is not vertically centered.
Status: ✅ PASS
OS: macOS Mojave
Browser: Chrome
Device: MBP
Emulated Device: iPhoneX, Galaxy S5, iPad Pro, Google Pixel 2, Galaxy Note 3
Test Artifact(s):
✅ AC1 - Login button is centered in container.
