Page MenuHomePhabricator
Create Task
Maniphest T232800

Regression: ICONS - last modified bar background doesn't cover entire element
Closed, ResolvedPublic
Actions

Assigned To
ovasileva
Authored By
Jdlrobson
Sep 12 2019, 11:44 PM
Tags
Referenced Files
F30398270: T232800.png
Sep 19 2019, 2:28 PM
F30381469: image.png
Sep 17 2019, 5:38 PM
F30318476: image.png
Sep 13 2019, 4:28 PM
F30313153: Screen Shot 2019-09-13 at 01.32.41.png
Sep 12 2019, 11:44 PM
Subscribers
Aklapper
• alexhollender_WMF
DannyS712
Edtadros
Jdlrobson

Description

Visit a page and edit it. When freshly edited the last modifier bar is green.

Screen Shot 2019-09-13 at 01.32.41.png (1×2 px, 742 KB)

Expected: Green background covers entire element
Actual: Green bar not full width.

QA Results

ACStatusDetails
1✅T232800#5506371

Details

SubjectRepoBranchLines +/-
Last modified bar background should fill entire barmediawiki/skins/MinervaNeuemaster+1 -0
Fix truncated text showing through icons & last-modified barmediawiki/skins/MinervaNeuemaster+30 -15
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Sep 12 2019, 11:44 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 12 2019, 11:44 PM
Jdlrobson mentioned this in T232792: [Regression] ICONS: Not compatible with truncated text (last modified and logout button).Sep 12 2019, 11:44 PM

I think this just needs a `.last-modified-bar.active { margin: 0; | `

gerritbot added a comment.Sep 12 2019, 11:50 PM

Change 536381 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Last modified bar background should fill entire bar

https://gerrit.wikimedia.org/r/536381

gerritbot added a project: Patch-For-Review.Sep 12 2019, 11:50 PM
Jdlrobson moved this task from Upcoming to Needs Code Review on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.Sep 12 2019, 11:52 PM
Jdlrobson triaged this task as High priority.Sep 12 2019, 11:57 PM
Jdlrobson mentioned this in T229440: [EPIC] Refactor icon sizing in MF/Minerva to achieve consistency.Sep 13 2019, 12:00 AM
phuedx added a parent task: T229440: [EPIC] Refactor icon sizing in MF/Minerva to achieve consistency.Sep 13 2019, 9:12 AM
Aklapper added a project: MinervaNeue.Sep 13 2019, 11:55 AM

Assuming this task is about MinervaNeue hence adding project tag so others can find this task when searching for tasks under that project.

Jdlrobson assigned this task to • alexhollender_WMF.Sep 13 2019, 4:09 PM
Jdlrobson moved this task from Needs Code Review to Needs Design Review on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
• alexhollender_WMF added a comment.Sep 13 2019, 4:28 PM

@Jdlrobson also seeing it like this sometimes

image.png (1×750 px, 80 KB)

gerritbot added a comment.Sep 13 2019, 5:49 PM

Change 536381 abandoned by Jdlrobson:
Last modified bar background should fill entire bar

https://gerrit.wikimedia.org/r/536381

gerritbot added a comment.Sep 13 2019, 5:51 PM

Change 536380 had a related patch set uploaded (by Jdlrobson; owner: Jdrewniak):
[mediawiki/skins/MinervaNeue@master] Fix truncated text showing through icons & last-modified bar

https://gerrit.wikimedia.org/r/536380

gerritbot added a comment.Sep 13 2019, 9:53 PM

Change 536380 merged by Jdlrobson:
[mediawiki/skins/MinervaNeue@master] Fix truncated text showing through icons & last-modified bar

https://gerrit.wikimedia.org/r/536380

Restricted Repository Identity mentioned this in rSKIN4cfdb1a9b1af: Update git submodules.Sep 13 2019, 9:55 PM
ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.23; 2019-09-17).Sep 13 2019, 10:00 PM
gerritbot added a comment.Sep 13 2019, 10:09 PM

Change 536381 restored by Jdlrobson:
Last modified bar background should fill entire bar

https://gerrit.wikimedia.org/r/536381

gerritbot added a comment.Sep 13 2019, 11:20 PM

Change 536381 merged by Jdlrobson:
[mediawiki/skins/MinervaNeue@master] Last modified bar background should fill entire bar

https://gerrit.wikimedia.org/r/536381

Restricted Repository Identity mentioned this in rSKINdc537321f594: Update git submodules.Sep 13 2019, 11:22 PM
Jdlrobson moved this task from Needs Design Review to Needs More Work on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.Sep 16 2019, 6:31 PM
Jdlrobson moved this task from Needs More Work to Needs Design Review on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.Sep 17 2019, 5:04 PM
• alexhollender_WMF reassigned this task from • alexhollender_WMF to Edtadros.Sep 17 2019, 5:38 PM
• alexhollender_WMF moved this task from Needs Design Review to Needs QA on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
• alexhollender_WMF added subscribers: Edtadros, • alexhollender_WMF.

@Edtadros as you pointed out there's a new issue with this element, however since the issue described here has been fixed I suggest we resolve this task. I will create a new one to deal with the alignment issue you noted:

image.png (2×1 px, 223 KB)

Edtadros reassigned this task from Edtadros to ovasileva.Sep 19 2019, 2:28 PM
Edtadros moved this task from Needs QA to Ready for Signoff on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.

Test Result

Status: ✅ PASS
OS: macOS Mojave
Browser: Chrome
Device: MBP
Emulated Device: iPhoneX, Galaxy S5, iPad Pro, Google Pixel 2, Galaxy Note 3

Test Artifact(s):
✅ AC1 - Login button is centered in container.

T232800.png (2×1 px, 203 KB)

Edtadros updated the task description. (Show Details)Sep 19 2019, 2:29 PM
ovasileva closed this task as Resolved.Sep 20 2019, 9:21 AM
DannyS712 removed a project: Patch-For-Review.Nov 18 2019, 11:35 AM
DannyS712 subscribed.

[batch] remove patch for review tag from resolved tasks

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL