Page MenuHomePhabricator

Design: Provide Mockup Example of COI Alert
Closed, ResolvedPublic

Description

Acceptance Criteria:

  • Develop a mockup example for the NPP request T207757, based on the following criteria:
    • We indicate if there is a match between the username and article title (within the article record) in red text at top (i.e. not "Potential Issues").
    • The symbols in the New Pages Feed (such as the green checkmark) should remain the same and be unaffected by this work.
    • Users are able to filter for this match in search results.
    • We don’t indicate if there is a match between the username and external links in the article.
    • Since this work will specifically check one form of potential abuse, we think this feature should be renamed. Rather than calling it “Potential COI” alert, we can call it “Username in title."

Event Timeline

I am not familiar with some of the standards around the current NPP design, so, I had two queries:

  1. What is the difference between the red text that shows up after the title like "No Citations", "Orphan" etc. and Potential issues like 'Copyvio'? I don't understand the conceptual difference between the two.
  2. I see a few different icons before the title: , , . Should this change if the username is in the article?

As red textAs Potential issueFrom Set filter
Screenshot 2019-09-16 at 10.09.15 PM.png (246×1 px, 73 KB)
Screenshot 2019-09-16 at 10.12.40 PM.png (248×1 px, 71 KB)
Screenshot 2019-09-16 at 10.15.20 PM.png (1×1 px, 279 KB)

Pinging @MusikAnimal, so we can hear his opinions on the questions posed by Prateek above.

Also, here are my preliminary thoughts:

  • Q1 Response: It appears that red text indicates information that we know to be true (such as "No Citations"), whereas "Potential Issues" merely flag issues that *may* true, based on certain criteria (however, we're not completely sure). Since, we're changing this feature to be a specific check (rather than a potential issue/COI alert), it probably makes more sense for it to be red text.
  • Q2 Response: I imagine that the icons shouldn't change. This is because the icons you specified indicate review status or review options, which are independent of the alerts listed in the record record.

It appears that red text indicates information that we know to be true (such as "No Citations"), whereas "Potential Issues" merely flag issues that *may* true

That is my understanding as well. Incidentally "possible issues" are not stored in PageTriage as "tags" (as in the pagetriage_page_tags table), instead are live queries.

I imagine that the icons shouldn't change. This is because the icons you specified indicate review status or review options, which are independent of the alerts listed in the record record.

Yes, green check = reviewed, blue info = unreviewed, trash = tagged for deletion

we're changing this feature to be a specific check (rather than a potential issue/COI alert), it probably makes more sense for it to be red text.

Potential issues are in red too, but I agree this probably belongs in the metadata section (as it is called in the code), next to "No citations", etc. However, note the UI is getting a bit cluttered. Perhaps "Username in title" (without the word "article") would suffice?

Thanks for the feedback, @MusikAnimal!

In that case, I will update the requirements in the following way:

  • Shorten name to be 'Username in title' (I agree with this suggestion)
  • Specify that the 'Username in title' should be in red text at top (i.e. not "Potential Issues")
  • The icons in the article record should remain unchanged
ifried updated the task description. (Show Details)

Thanks @ifried and @MusikAnimal 🤩

In that case, I will update the requirements in the following way:

  • Shorten name to be 'Username in title' (I agree with this suggestion)
  • Specify that the 'Username in title' should be in red text at top (i.e. not "Potential Issues")
  • The icons in the article record should remain unchanged

Sounds good. Here is the updated screenshot:

npp.jpg (246×1 px, 22 KB)

Looks great, @Prtksxna. Thanks! I have created a new ticket for this work, which the team will estimate later today: T233115.