Small fixes needed for Campaign fallback
Closed, ResolvedPublic
Actions

Description

Just three small changes needed before campaign fallback can be merged:

Rename the new config setting to wgCentralNoticeMaxFallbackIterations... (Or maybe wgCentralNoticeMaxCampaignFallback? Anyway, at least, it needs to be more specific and clear than what's in the current latest patch set. Long is fine.)
Reduce default value to 5.
Add documentation of the new setting to the README.

As discussed, we can just upload a new patch set to the existing Gerrit change, then someone can +2 the whole thing. For more details, please see the comment on extension.json for Patch Set 39 from September 10th:

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralNotice/+/517931

Thanks!!!!

Details

	Subject	Repo	Branch	Lines +/-
	Change name, default value, and document CentralNoticeMaxCampaignFallback	mediawiki/extensions/CentralNotice	master	+14 -8

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T124969 Can we allow fallback to alternative campaign if mixin would hide this one
		Resolved		• mepps	T232859 Small fixes needed for Campaign fallback

Event Timeline

• DStrine created this task.Sep 13 2019, 4:55 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 13 2019, 4:55 PM

• DStrine moved this task from Triage to Sprint +1 on the Fundraising-Backlog board.Sep 13 2019, 4:55 PM

• DStrine moved this task from Sprint +1 to Current Sprint on the Fundraising-Backlog board.Sep 17 2019, 8:03 PM

• DStrine added a project: Fundraising Sprint Sysadmin Kane.Sep 17 2019, 8:13 PM

AndyRussG renamed this task from Tiny text change and release Campaign fallback to Small fixes needed for Campaign fallback.Sep 20 2019, 5:20 PM

AndyRussG updated the task description. (Show Details)

I went with MaxCampaignFallback because I thought it had a better ring to it than using Iterations. I also noticed there's another config variable named FallbackHideCookieDuration which seems unrelated to Campaign Fallback so this name might be more clear than MaxFallbackIterations. Another options is MaxFallbackCampaign but I might be overthinking it :).

• mepps moved this task from Backlog to Review on the Fundraising Sprint Sysadmin Kane board.Sep 24 2019, 8:39 PM

Change 538967 had a related patch set uploaded (by Mepps; owner: Mepps):
[mediawiki/extensions/CentralNotice@master] Change name, default, and add documentation for MaxCampaignFallback

https://gerrit.wikimedia.org/r/538967

gerritbot added a project: Patch-For-Review.Sep 25 2019, 1:08 PM

Ejegg added a project: Fundraising Sprint Trojan Horse Wisperer.Oct 1 2019, 8:46 PM

AndyRussG moved this task from Backlog to Review on the Fundraising Sprint Trojan Horse Wisperer board.Oct 5 2019, 8:50 PM

AndyRussG assigned this task to • mepps.Oct 8 2019, 6:19 PM

Change 538967 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@master] Change name, default value, and document CentralNoticeMaxCampaignFallback

https://gerrit.wikimedia.org/r/538967

Maintenance_bot removed a project: Patch-For-Review.Oct 10 2019, 5:10 PM

AndyRussG moved this task from Review to Pending Deployment on the Fundraising Sprint Trojan Horse Wisperer board.Oct 15 2019, 7:54 PM

• DStrine added a project: Fundraising Sprint Usual Subscripts.Oct 15 2019, 8:30 PM

AndyRussG moved this task from Backlog to Pending Deployment on the Fundraising Sprint Usual Subscripts board.Oct 16 2019, 4:26 PM

• Jseddon added a parent task: T124969: Can we allow fallback to alternative campaign if mixin would hide this one.Oct 21 2019, 2:09 PM

• DStrine closed this task as Resolved.Oct 29 2019, 8:37 PM