Page MenuHomePhabricator
Create Task
Maniphest T232915

Red-green in PHPUnit code coverage are hard to read
Open, LowPublic
Actions

Description

Inspired by T232893, this is something I've always wanted to report. Our coverage reports on doc.wikimedia.org (example) uses a red/green combination that's very hard to discern. As partly colorblind, I can guarantee that:

  • The page is hard to read on a decent monitor
  • The page is impossible to read on a monitor with not-so-good colors (I tried a cheap laptop, and there really was no difference between the colors)

The colors seem to be decided by a bootstrap CSS file included directly by PHPUnit; hence, I'm going to open an upstream bug report. Nevertheless, I wonder whether we can change the color for our reports, before we will eventually upgrade to a newer version of php-code-coverage.

Upstream task https://github.com/sebastianbergmann/php-code-coverage/issues/556

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
OpenNoneT232915 Red-green in PHPUnit code coverage are hard to read
OpenNoneT328919 Upgrade PHPUnit in MediaWiki code to PHPUnit 10
· · ·

Event Timeline

Daimona created this task.Sep 14 2019, 8:55 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 14 2019, 8:55 AM
Daimona added a comment.Sep 14 2019, 9:45 AM

FTR: https://github.com/sebastianbergmann/php-code-coverage/issues/698. Note that we use an old version of php-code-coverage, and the current one (7.0.7) is slightly different. Red and green are the same, though.

MarcoAurelio awarded a token.Sep 14 2019, 9:57 AM
Aklapper added a project: WMF-General-or-Unknown.Sep 14 2019, 11:54 AM
Krinkle renamed this task from Red-green in code coverage are hard to read to Red-green in PHPUnit code coverage are hard to read.Sep 14 2019, 3:30 PM
Krinkle edited projects, added Continuous-Integration-Config; removed WMF-General-or-Unknown.
hashar moved this task from Backlog to Reported Upstream on the Upstream board.Sep 14 2019, 9:08 PM
hashar updated the task description. (Show Details)
Daimona added a subscriber: Legoktm.Sep 15 2019, 8:00 AM

CC @Legoktm per comments at https://github.com/sebastianbergmann/php-code-coverage/issues/556.

Volker_E moved this task from Unsorted to Colors on the Accessibility board.Sep 16 2019, 5:40 PM
Legoktm added a comment.Sep 18 2019, 10:29 AM

I didn't find the upstream response of allowing for custom CSS super satisfying, but I guess it's what we got. If someone writes a stylesheet, we just need to have CI copy it into .css/custom.css before rsyncing it to the docs server.

I used to have a stylesheet loaded via stylish or one of those browser extensions, but I lost that a while back and didn't really back it up.

hashar triaged this task as Low priority.May 3 2020, 9:21 AM
hashar subscribed.

Revisiting this task. From the upstream issue #556, php-code-coverage 6.0.5 now has an empty custom.css that one can override after the report has completed.

https://github.com/sebastianbergmann/php-code-coverage/commit/5626697ba169fc6bd56d38d83b478682f279bf7b

That is not really configurable, one has to manually copy the stylesheet after the report has been generated:

cp ./tests/coverage-style.css ./report/_css/custom.css
Daimona added a comment.Sep 2 2023, 8:43 PM

Quick note that in PHPUnit 10 we have config options for these colors: https://github.com/sebastianbergmann/phpunit/commit/68f929067281464087764b1533b31f9a098726cb

These can be specified in the PHPUnit config file, which presumably makes them easier to use.{{cn}}

TheDJ moved this task from Reported Upstream to Patch released upstream on the Upstream board.Sat, Jan 24, 4:42 PM
Jdforrester-WMF added a subtask: T328919: Upgrade PHPUnit in MediaWiki code to PHPUnit 10.Mon, Jan 26, 3:20 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits