Syntax highlighting shifts the page image below the text on Wikisource
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Ruthven
	Sep 14 2019, 11:28 AM

Description

When using the syntax highlighting in edit mode in a page for Wikisource, it shifts the image, misaligning it with the text. See image below:

Screen Shot 2019-09-14 at 13.10.10.png (795×1 px, 376 KB)

Steps to Reproduce:

Open a Wikisource article in Page ns in edit mode
Select the icon for the "syntax highlighting" (the little pencil)
Reload the page

Possible solution:

The element <div class="CodeMirror cm-s-default CodeMirror-wrap ui-resizable" ....> (without an unique id btw) should be placed as first element of <div class="prp-page-content"> rather than after <div class=wikiEditor-ui-text>.

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/CodeMirror	master	+10 -1	Make enableCodeMirror() start after ProofreadPage module load

Customize query in gerrit

Related Objects

Mentioned Here: T288141: ProofreadPage: use OpenSeadragon for the Page NS image viewer

Event Timeline

Ruthven created this task.Sep 14 2019, 11:28 AM

Restricted Application added a project: Community-Tech. · View Herald TranscriptSep 14 2019, 11:28 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Including an example link is always welcome, as it makes it way easier for someone else to try to reproduce the problem.
Seems to be https://nap.wikisource.org/wiki/Paggena:%27e_Tre_guappe_ammartenate.djvu/2?action=edit here. Confirming.

Removing Wikimedia-Site-requests as this does not look like a request to change the configuration (not: code) of a Wikimedia website.

TheDJ added a project: ProofreadPage.Feb 24 2020, 8:18 PM

Inductiveload added a subscriber: Inductiveload.Jul 15 2020, 11:35 AM

Soda merged a task: T247698: Syntax highlighter in Firefox disorders the Proofread page sections with either webpage or Preview mode of refresh.Aug 7 2020, 4:06 PM

Soda added a subscriber: Ineuw.

Soda added a subscriber: Soda.

Aklapper merged tasks: T261070: Vertical layout breaks in Wikisource editing mode when SyntaxHighlight is enabled, T241521: Syntax highlighter forces the header and footer to end up at the bottom of the proofread page..Aug 23 2020, 4:09 PM

Aklapper added subscribers: Cryptex, TheDJ.

Change 621954 had a related patch set uploaded (by Sohom Datta; owner: Sohom Datta):
[mediawiki/extensions/CodeMirror@master] Make enableCodeMirror() start after ProofreadPage module load

https://gerrit.wikimedia.org/r/621954

gerritbot added a project: Patch-For-Review.Aug 23 2020, 6:01 PM

Soda merged a task: T266950: Wikisource Source Edit page loads differently in Chrome on Ubuntu.Nov 1 2020, 4:58 AM

Soda added a subscriber: Nasirkhan.

MJL moved this task from Backlog to Next-up on the All-and-every-Wikisource board.Nov 8 2020, 6:23 PM

It looks like this issue has been fixed (at least, I'm not able to reproduce it anywhere now).

Hi @Samwilson, I cannot reproduce it either. Very probably, the usage of OpenSeadragon for the Page image viewer had some positive side effect wrt this task T288141.
Let's close it?

Yes, I think you're right.

Change 621954 abandoned by Sohom Datta:

[mediawiki/extensions/CodeMirror@master] Make enableCodeMirror() start after ProofreadPage module load

Reason:

appears to be fixed

https://gerrit.wikimedia.org/r/621954

Maintenance_bot removed a project: Patch-For-Review.Feb 10 2022, 4:11 PM

Izno moved this task from Backlog to Done on the MediaWiki-extensions-CodeMirror board.Mar 29 2022, 9:37 PM

	F30338810: Screen Shot 2019-09-14 at 13.10.10.png
	Sep 14 2019, 11:28 AM

Syntax highlighting shifts the page image below the text on WikisourceClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Syntax highlighting shifts the page image below the text on Wikisource
Closed, ResolvedPublic
Actions