Page MenuHomePhabricator
Create Task
Maniphest T232918

Syntax highlighting shifts the page image below the text on Wikisource
Open, Needs TriagePublic
Actions

Description

When using the syntax highlighting in edit mode in a page for Wikisource, it shifts the image, misaligning it with the text. See image below:

Screen Shot 2019-09-14 at 13.10.10.png (795×1 px, 376 KB)

Steps to Reproduce:

  1. Open a Wikisource article in Page ns in edit mode
  2. Select the icon for the "syntax highlighting" (the little pencil)
  3. Reload the page

Possible solution:

  • The element <div class="CodeMirror cm-s-default CodeMirror-wrap ui-resizable" ....> (without an unique id btw) should be placed as first element of <div class="prp-page-content"> rather than after <div class=wikiEditor-ui-text>.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/CodeMirrormaster+10 -1Make enableCodeMirror() start after ProofreadPage module load
Customize query in gerrit

Related Objects

Event Timeline

Ruthven created this task.Sep 14 2019, 11:28 AM
Restricted Application added a project: Community-Tech. · View Herald TranscriptSep 14 2019, 11:28 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Aklapper removed a project: Wikimedia-Site-requests.Sep 14 2019, 12:04 PM

Including an example link is always welcome, as it makes it way easier for someone else to try to reproduce the problem.
Seems to be https://nap.wikisource.org/wiki/Paggena:%27e_Tre_guappe_ammartenate.djvu/2?action=edit here. Confirming.

Removing Wikimedia-Site-requests as this does not look like a request to change the configuration (not: code) of a Wikimedia website.

TheDJ added a project: ProofreadPage.Feb 24 2020, 8:18 PM
Inductiveload added a subscriber: Inductiveload.Jul 15 2020, 11:35 AM
Soda merged a task: T247698: Syntax highlighter in Firefox disorders the Proofread page sections with either webpage or Preview mode of refresh.Aug 7 2020, 4:06 PM
Soda added a subscriber: Ineuw.
Soda added a subscriber: Soda.
Aklapper merged tasks: T261070: Vertical layout breaks in Wikisource editing mode when SyntaxHighlight is enabled, T241521: Syntax highlighter forces the header and footer to end up at the bottom of the proofread page..Aug 23 2020, 4:09 PM
Aklapper added subscribers: Cryptex, TheDJ.
gerritbot added a comment.Aug 23 2020, 6:01 PM

Change 621954 had a related patch set uploaded (by Sohom Datta; owner: Sohom Datta):
[mediawiki/extensions/CodeMirror@master] Make enableCodeMirror() start after ProofreadPage module load

https://gerrit.wikimedia.org/r/621954

gerritbot added a project: Patch-For-Review.Aug 23 2020, 6:01 PM
Soda merged a task: T266950: Wikisource Source Edit page loads differently in Chrome on Ubuntu.Nov 1 2020, 4:58 AM
Soda added a subscriber: Nasirkhan.
MJL moved this task from Backlog to Next-up on the All-and-every-Wikisource board.Nov 8 2020, 6:23 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL