Page MenuHomePhabricator

Syntax highlighting shifts the page image below the text on Wikisource
Open, Needs TriagePublic

Description

When using the syntax highlighting in edit mode in a page for Wikisource, it shifts the image, misaligning it with the text. See image below:

Screen Shot 2019-09-14 at 13.10.10.png (795×1 px, 376 KB)

Steps to Reproduce:

  1. Open a Wikisource article in Page ns in edit mode
  2. Select the icon for the "syntax highlighting" (the little pencil)
  3. Reload the page

Possible solution:

  • The element <div class="CodeMirror cm-s-default CodeMirror-wrap ui-resizable" ....> (without an unique id btw) should be placed as first element of <div class="prp-page-content"> rather than after <div class=wikiEditor-ui-text>.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Including an example link is always welcome, as it makes it way easier for someone else to try to reproduce the problem.
Seems to be https://nap.wikisource.org/wiki/Paggena:%27e_Tre_guappe_ammartenate.djvu/2?action=edit here. Confirming.

Removing Wikimedia-Site-requests as this does not look like a request to change the configuration (not: code) of a Wikimedia website.

Change 621954 had a related patch set uploaded (by Sohom Datta; owner: Sohom Datta):
[mediawiki/extensions/CodeMirror@master] Make enableCodeMirror() start after ProofreadPage module load

https://gerrit.wikimedia.org/r/621954