Change or remove email address help text should, but looks not to, conditioned on site settings
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	Whelkmy
	Sep 14 2019, 8:33 PM

Description

With settings as in https://git.archlinux.org/vhosts/wiki.archlinux.org.git/tree/LocalSettings.archlinux.org.php#n230, an https://wiki.archlinux.org user examining his Preferences/User profile/Email options is guided that

Email address is required. You can also choose to let others contact you by email through a link on your user or talk page. Your email address is not revealed when other users contact you

But when he clicks to Set an email address at that page, another page gets loaded. Within that new page, the surrounding text is

Complete this form to change your email address. If you would like to remove the association of any email address from your account, leave the new email address blank when submitting the form.
Current email address:
(Probably extracted from the site db)
New email address:
(To be filled by the user)
This field should be left blank if you want to remove your email address. You will not be able to reset a forgotten password and will not receive emails from this wiki if the email address is removed.

Can the user email left blank or not? No, it can not be left blank. Probably the guidance text for allowing a blank email address field should, but currently not, conditioned on the site settings.

Event Timeline

Whelkmy created this task.Sep 14 2019, 8:33 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 14 2019, 8:33 PM

Reedy added a project: MediaWiki-Core-Preferences.Sep 14 2019, 8:35 PM

Lahwaacz subscribed.Sep 14 2019, 9:01 PM

Hi @Whelkmy, thanks for taking the time to report this and welcome to Wikimedia Phabricator!

It would be very welcome if you could provide a clear list of steps to reproduce, what you expect to happen, and what happens instead, plus provide MediaWiki version information. Please see and follow https://www.mediawiki.org/wiki/How_to_report_a_bug - thanks!

As for the version, by the first line of https://git.archlinux.org/vhosts/wiki.archlinux.org.git/tree/LocalSettings.archlinux.org.php#n230 it might be MediaWiki 1.19.0. Perhaps Lahwaacz, who is also subscribed to this report, will fix me.

As for steps to reproduce and my expectations:
I have an account on https://wiki.archlinux.org. It would be nice to try the following with an account. Hopefully, the screenshots I am uploading can be used instead.

Start by going to https://wiki.archlinux.org/index.php?title=Special:UserLogin&returnto=Main+page. Check in Keep me logged in.
Click Log in. A username and a password is required to actually log in. After a successful login, the main page of the wiki is displayed. This is the same page as anyone going to https://wiki.archlinux.org/index.php/Main_page would get, except that a logged in user will see
near the bottom of the page. While anyone else will see
instead.
Now click on Preferences. One is taken to https://wiki.archlinux.org/index.php/Special:Preferences. I attached only a small portion of the resulted screen to save on what I think are redundant details.
The configured email address is hidden in this report by the black rectangle. Note the user is told an email address is required.
Next click to Change or remove email address. One is then asked to verify his identity by re log in.
Once again, I only uploaded part of the resulted screen.
Here too I hide the configured email address with a black rectangle. As you can see, both the title and the surrounding text tells the user there is no problem with leaving the email address blank. Which is not the case, and also contradicts the explicit requirement for an email address from step 3. I think the surrounding text here should be further conditioned on the settings of the site. How did it knew in step 3 an email address is required, and is not optional?

The version is 1.33.0, see https://wiki.archlinux.org/index.php/Special:Version

Everything else is clearly stated in the original report, the important setting (hidden behind the first link) is $wgEmailConfirmToEdit = true;.

Whelkmy renamed this task from Wiki user Preferences/User profile/Email options should, but currently not, conditioned on site settings to Wiki user Preferences/User profile/Email options/Change or remove email address should, but looks not to, conditioned on site settings.Sep 16 2019, 10:12 AM

Whelkmy renamed this task from Wiki user Preferences/User profile/Email options/Change or remove email address should, but looks not to, conditioned on site settings to Wiki user Preferences/User profile/Email options/Change or remove email address help text should, but looks not to, conditioned on site settings.

	F30360267: Screenshot_2019-09-15 ArchWiki.png
	Sep 15 2019, 5:08 PM

	F30360268: Screenshot_2019-09-15 ArchWiki(1).png
	Sep 15 2019, 5:08 PM

	F30360348: Screenshot_2019-09-15 Preferences - ArchWiki.png
	Sep 15 2019, 5:08 PM

	F30360381: Screenshot_2019-09-15 Change or remove email address - ArchWiki(1).png
	Sep 15 2019, 5:08 PM

Wiki user Preferences/User profile/Email options/Change or remove email address help text should, but looks not to, conditioned on site settingsOpen, Needs TriagePublicActions

Description

Event Timeline

Wiki user Preferences/User profile/Email options/Change or remove email address help text should, but looks not to, conditioned on site settings
Open, Needs TriagePublic
Actions