Page MenuHomePhabricator

CentralAuth hooks function `onAbuseFilterShouldFilterAction` should be static
Closed, ResolvedPublic

Description

Not being static causes errors with AbuseFilter builds, discovered in https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/AbuseFilter/+/536755/ as part of T231756: Blockautopromote duration should be configurable per wiki

Errors:
Non-static method CentralAuthHooks::onAbuseFilterShouldFilterAction() should not be called statically

Background: T212082: Do not block page moves with AbuseFilter on LocalRenameJob page moves

Event Timeline

Restricted Application added a project: User-DannyS712. · View Herald TranscriptSep 15 2019, 5:05 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 536756 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/CentralAuth@master] Make onAbuseFilterShouldFilterAction static

https://gerrit.wikimedia.org/r/536756

DannyS712 moved this task from Backlog to Internal bugs on the AbuseFilter board.Sep 15 2019, 5:07 AM
DannyS712 added a project: GlobalRename.
DannyS712 moved this task from Backlog to Review requested on the GlobalRename board.
DannyS712 moved this task from Incoming to GlobalRename on the MediaWiki-extensions-CentralAuth board.
DannyS712 moved this task from Unsorted to Abuse Filter on the User-DannyS712 board.
Daimona closed this task as Resolved.Sep 15 2019, 7:59 AM
Daimona removed a project: Patch-For-Review.

Change 536756 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@master] Make onAbuseFilterShouldFilterAction static

https://gerrit.wikimedia.org/r/536756