Page MenuHomePhabricator

AbuseFilterViewEdit: Show "Test this filter against recent edits" to all users who can use it
Closed, ResolvedPublic

Description

Currently, the testbatch feature is available to users who can modify filters or view private filters, but the link to test filters is only shown to those who can modify them.
Instead of checking AbuseFilter::canEdit( $user ) to determine if the link should be shown, AbuseFilter::canViewPrivate( $user ) should be called
Patch coming momentarily

Event Timeline

Restricted Application added a project: User-DannyS712. · View Herald TranscriptSep 15 2019, 10:02 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 536789 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/AbuseFilter@master] Show link to test filter to all users who can use it

https://gerrit.wikimedia.org/r/536789

Daimona closed this task as Resolved.Sep 16 2019, 10:03 AM
Daimona removed a project: Patch-For-Review.

Change 536789 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Show link to test filter to all users who can use it

https://gerrit.wikimedia.org/r/536789