Translate "Data Bridge" string in ProcessDialog component
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Lucas_Werkmeister_WMDE
	Sep 16 2019, 11:48 AM

Description

create Messages.ts with enum of message keys available in application
add "data-bridge-title" message to Wikibase client i18n
model dependency of app to this message in Resources.php
use message in ProcessDialog through message plugin/mixin (T232993)

Details

Project	Branch	Lines +/-	Subject
mediawiki/extensions/Wikibase	master	+153 -75	bridge: use message to render bridge header title
mediawiki/extensions/Wikibase	master	+8 -0	bridge: add Messages defintions
mediawiki/extensions/Wikibase	master	+4 -2	bridge: add title message

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Lydia_Pintscher	T224833 first client edit for simple typo
Resolved	Lydia_Pintscher	T228259 Adapt buttons' texts to the user interface language
Resolved	• Matthias_Geisler_WMDE	T232994 Translate "Data Bridge" string in ProcessDialog component

Event Timeline

Lucas_Werkmeister_WMDE created this task.Sep 16 2019, 11:48 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 16 2019, 11:48 AM

add "data-bridge-title" message to Wikibase client i18n

We also considered having a separate i18n directory for Data Bridge, but for now it’s probably not necessary. We’ll use data-bridge or some similar static component in the message keys, though, so they’re easily distinguished and can be extracted later if necessary.

• Matthias_Geisler_WMDE edited projects, added Wikidata-Bridge-Sprint-5; removed Wikidata-Bridge.Sep 16 2019, 2:50 PM

• Matthias_Geisler_WMDE claimed this task.Sep 16 2019, 2:54 PM

• Matthias_Geisler_WMDE moved this task from To do to Doing on the Wikidata-Bridge-Sprint-5 board.

Change 537136 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[mediawiki/extensions/Wikibase@master] bridge: add title message

https://gerrit.wikimedia.org/r/537136

gerritbot added a project: Patch-For-Review.Sep 16 2019, 3:07 PM

Change 537137 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[mediawiki/extensions/Wikibase@master] bridge: add Messages defintions

https://gerrit.wikimedia.org/r/537137

Please note: Make usage of the title is only possible if the other tasks are done.

Where does this “Data Bridge” string actually comes from? The parent task talks about buttons, not the title, and the Figma mockups have “Edit property” as the title, not “Data Bridge”.

Change 537136 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: add title message

https://gerrit.wikimedia.org/r/537136

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.24; 2019-09-24).Sep 19 2019, 12:00 PM

Change 537137 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: add Messages defintions

https://gerrit.wikimedia.org/r/537137

Maintenance_bot removed a project: Patch-For-Review.Sep 19 2019, 3:10 PM

Change 538271 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: use message to render bridge header title

https://gerrit.wikimedia.org/r/538271

gerritbot added a project: Patch-For-Review.Sep 20 2019, 2:27 PM

Change 538271 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: use message to render bridge header title

https://gerrit.wikimedia.org/r/538271

Maintenance_bot removed a project: Patch-For-Review.Sep 23 2019, 10:10 AM

Michael moved this task from Peer Review to Verification on the Wikidata-Bridge-Sprint-5 board.Sep 23 2019, 10:13 AM

• Matthias_Geisler_WMDE closed this task as Resolved.Sep 24 2019, 8:01 AM

• Matthias_Geisler_WMDE mentioned this in T233295: Step 1: Add label of property to header message (impact: low).

• Matthias_Geisler_WMDE moved this task from Verification to Done on the Wikidata-Bridge-Sprint-5 board.