Page MenuHomePhabricator

Translate "Data Bridge" string in ProcessDialog component
Closed, ResolvedPublic

Description

  • create Messages.ts with enum of message keys available in application
  • add "data-bridge-title" message to Wikibase client i18n
  • model dependency of app to this message in Resources.php
  • use message in ProcessDialog through message plugin/mixin (T232993)

Details

Related Gerrit Patches:
mediawiki/extensions/Wikibase : masterbridge: use message to render bridge header title
mediawiki/extensions/Wikibase : masterbridge: add Messages defintions
mediawiki/extensions/Wikibase : masterbridge: add title message

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 16 2019, 11:48 AM

add "data-bridge-title" message to Wikibase client i18n

We also considered having a separate i18n directory for Data Bridge, but for now it’s probably not necessary. We’ll use data-bridge or some similar static component in the message keys, though, so they’re easily distinguished and can be extracted later if necessary.

Change 537136 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[mediawiki/extensions/Wikibase@master] bridge: add title message

https://gerrit.wikimedia.org/r/537136

Change 537137 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[mediawiki/extensions/Wikibase@master] bridge: add Messages defintions

https://gerrit.wikimedia.org/r/537137

Please note: Make usage of the title is only possible if the other tasks are done.

Where does this “Data Bridge” string actually comes from? The parent task talks about buttons, not the title, and the Figma mockups have “Edit property” as the title, not “Data Bridge”.

Change 537136 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: add title message

https://gerrit.wikimedia.org/r/537136

Change 537137 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: add Messages defintions

https://gerrit.wikimedia.org/r/537137

Change 538271 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: use message to render bridge header title

https://gerrit.wikimedia.org/r/538271

Change 538271 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: use message to render bridge header title

https://gerrit.wikimedia.org/r/538271