Page MenuHomePhabricator
Create Task
Maniphest T233004

Update CheckUser for actor and comment table
Closed, ResolvedPublic
Actions

Description

Current CheckUser extension does not use actor table and comment table.

Related tasks:

Details

SubjectRepoBranchLines +/-
SECURITY: api: Only add actor table to table list when querying from itmediawiki/extensions/CheckUserREL1_40+10 -1
Drop default from cuc_actor and cuc_comment_idmediawiki/extensions/CheckUsermaster+321 -8
stop setting checkuser actor/comment migration variablesoperations/mediawiki-configmaster+0 -11
Remove CheckUserActorMigration as cu_changes actor migration is donemediawiki/extensions/CheckUsermaster+42 -116
Remove cuc_comment from cu_changesmediawiki/extensions/CheckUsermaster+325 -10
Remove cul_reason comment table migration codemediawiki/extensions/CheckUserwmf/1.40.0-wmf.21+10 -21
Remove CheckUserCommentStore as cu_changes comment migration is donemediawiki/extensions/CheckUsermaster+67 -70
Use core's CommentStoremediawiki/extensions/Flowmaster+8 -4
Remove CheckUserLogCommentStore as cu_log comment migration is donemediawiki/extensions/CheckUsermaster+30 -83
Drop cuc_comment_id migration variablemediawiki/extensions/CheckUsermaster+13 -48
Remove default from cu_log comment table ID fieldsmediawiki/extensions/CheckUsermaster+266 -10
Remove cuc_user and cuc_user_text from cu_changesmediawiki/extensions/CheckUsermaster+341 -28
Remove cul_reason column from cu_logmediawiki/extensions/CheckUsermaster+160 -53
Stop writing to cuc_comment_id in group0 wikisoperations/mediawiki-configmaster+1 -0
Remove cul_reason comment table migration codemediawiki/extensions/CheckUsermaster+58 -151
Drop cuc_actor migration codemediawiki/extensions/CheckUsermaster+115 -276
Stop writing to cuc_comment everywhereoperations/mediawiki-configmaster+1 -4
Disable write old for CheckUserLog reason everywhereoperations/mediawiki-configmaster+1 -4
Stop writing to cuc_user and cuc_user_text everywhereoperations/mediawiki-configmaster+1 -4
Stop writing to cuc_comment in group1 wikisoperations/mediawiki-configmaster+1 -0
Stop writing to cuc_user and cuc_user_text in group1 wikisoperations/mediawiki-configmaster+1 -0
Disable write old for CheckUserLog reason on group 0operations/mediawiki-configmaster+1 -1
Stop writing to cuc_comment in testwikioperations/mediawiki-configmaster+1 -0
Stop writing to cuc_user and cuc_user_text in group0 wikisoperations/mediawiki-configmaster+1 -0
Disable write old for CheckUserLog reason field for testwikioperations/mediawiki-configmaster+1 -1
Stop writing to cuc_user and cuc_user_text in testwikioperations/mediawiki-configmaster+1 -0
Drop default value from cul_actormediawiki/extensions/CheckUsermaster+282 -5
Add support to turn off write old for cu_log reason migrationmediawiki/extensions/CheckUsermaster+18 -2
Specify default for cul_reason to support turning off write oldmediawiki/extensions/CheckUsermaster+284 -4
Update for CheckUser comment migrationmediawiki/extensions/Flowmaster+10 -4
Add write new support for cuc_comment_id migrationmediawiki/extensions/CheckUsermaster+12 -4
Update for CheckUser actor migrationmediawiki/extensions/AccountInfomaster+2 -2
Stop setting cul_actor migration varoperations/mediawiki-configmaster+0 -3
Drop cul_user and cul_user_text from cu_logmediawiki/extensions/CheckUsermaster+43 -90
Enable write new for CheckUserLog comment fields everywhereoperations/mediawiki-configmaster+1 -1
Enable write new for CheckUserLog comment fields on group 0 and 1operations/mediawiki-configmaster+2 -2
Add write new support for cuc_actor migrationmediawiki/extensions/CheckUsermaster+23 -9
Enable write new for CheckUserLog comment fields on testwikisoperations/mediawiki-configmaster+1 -1
Start reading from cuc_comment_id on wikidatawikioperations/mediawiki-configmaster+0 -1
Update for CheckUser actor migrationmediawiki/extensions/LoginNotifymaster+18 -17
Drop cul_user from 'selectFields' in CheckUserLogPagermediawiki/extensions/CheckUsermaster+2 -2
Drop cul_actor migration codemediawiki/extensions/CheckUsermaster+20 -122
Start reading from cuc_comment_id everywhere except wikidatawikioperations/mediawiki-configmaster+2 -6
Add ability to start from cuc_id to populateCucCommentmediawiki/extensions/CheckUserwmf/1.40.0-wmf.19+12 -5
Add ability to start from cuc_id to populateCucCommentmediawiki/extensions/CheckUsermaster+12 -5
Add read new support for cu_log comment ID columnsmediawiki/extensions/CheckUsermaster+149 -15
Write to cul_reason[_plaintext]_id everywhereoperations/mediawiki-configmaster+1 -1
Start reading from cuc_comment_id from a few wikisoperations/mediawiki-configmaster+4 -0
Start reading from cuc_comment_id on testwikioperations/mediawiki-configmaster+1 -0
Start reading from cuc_actor everywhereoperations/mediawiki-configmaster+1 -7
Revert "Revert "Start writing to cul_reason[_plaintext]_id on group0 and group1 wikis""operations/mediawiki-configmaster+2 -0
Stop writing to cul_user and cul_user_text everywhereoperations/mediawiki-configmaster+1 -6
Add read new support for cu_log comment ID columnsmediawiki/extensions/CheckUsermaster+121 -17
Start writing to cul_reason[_plaintext]_id on group0 and group1 wikisoperations/mediawiki-configmaster+2 -0
Start writing to cul_reason_id and cul_reason_plaintext_id on testwikioperations/mediawiki-configmaster+1 -0
Add read new support for cuc_comment_idmediawiki/extensions/CheckUsermaster+31 -16
Add maintenance script to populate cu_log comment ID columnsmediawiki/extensions/CheckUsermaster+157 -1
Stop writing to cul_user and cul_user_text on a few wikisoperations/mediawiki-configmaster+4 -0
Stop writing to cul_user and cul_user_text on testwikioperations/mediawiki-configmaster+1 -0
Start reading from cuc_actor on group0 and group1 wikisoperations/mediawiki-configmaster+2 -0
Start reading from cul_actor everywhereoperations/mediawiki-configmaster+1 -7
Start reading from cuc_actor on test wikisoperations/mediawiki-configmaster+4 -0
Start reading from cul_actor on group1 wikisoperations/mediawiki-configmaster+1 -0
Start reading from cul_actor on remaining test wikis and group0 wikisoperations/mediawiki-configmaster+4 -0
SECURITY: api: Only add actor table to table list when querying from itmediawiki/extensions/CheckUsermaster+2 -1
Investigate: Add read new support for cuc_actormediawiki/extensions/CheckUsermaster+143 -22
Pager: clarify which table the 'use index' option is formediawiki/extensions/CheckUsermaster+11 -4
Pager: Add read new support for cuc_actormediawiki/extensions/CheckUsermaster+44 -16
Hooks: Add read new support for cuc_actormediawiki/extensions/CheckUsermaster+11 -2
ApiQueryCheckUser: Add read new support for cuc_actormediawiki/extensions/CheckUsermaster+17 -8
Start writing to cuc_comment_id everywhereoperations/mediawiki-configmaster+1 -7
Add write new support for cul_actormediawiki/extensions/CheckUsermaster+17 -6
Start writing to cuc_comment_id on group0 and group1 wikisoperations/mediawiki-configmaster+2 -0
Use correct migration variablemediawiki/extensions/CheckUsermaster+1 -1
Use correct migration variablemediawiki/extensions/CheckUserREL1_39+1 -1
Start reading from cul_actor on testwikioperations/mediawiki-configmaster+1 -0
Add population script for cuc_comment_idmediawiki/extensions/CheckUsermaster+147 -0
Change cu_changes comment migration to write bothmediawiki/extensions/CheckUsermaster+1 -1
Start writing to cuc_comment_id on test wikisoperations/mediawiki-configmaster+4 -0
Pin cu_changes comment migration to old schemaoperations/mediawiki-configmaster+3 -0
Update populateCulActor.php update keymediawiki/extensions/CheckUserREL1_39+1 -1
Update populateCulActor.php update keymediawiki/extensions/CheckUsermaster+1 -1
Add comment migration code for SCHEMA_COMPAT_WRITE_BOTHmediawiki/extensions/CheckUsermaster+17 -2
Introduce CheckUserCommentStoremediawiki/extensions/CheckUsermaster+54 -0
Send CheckUser the IP address on account creationmediawiki/extensions/AbuseFilterREL1_38+9 -0
Send CheckUser the IP address on account creationmediawiki/extensions/AbuseFilterREL1_35+309 -0
Split a base class out of CommentStoremediawiki/coremaster+233 -90
Add default values to cul_user(_text)mediawiki/extensions/CheckUsermaster+320 -8
SpecialCheckUser: add support for actor migration read newmediawiki/extensions/CheckUsermaster+17 -8
Add read new support for cul_actormediawiki/extensions/CheckUsermaster+57 -17
Query actor table instead of user tablemediawiki/extensions/CheckUsermaster+6 -6
populateCulActor: fetch user name from user idmediawiki/extensions/CheckUserREL1_39+3 -2
populateCulActor: fetch user name from user idmediawiki/extensions/CheckUserREL1_38+140 -0
populateCulActor: fetch user name from user idmediawiki/extensions/CheckUsermaster+3 -2
Start writing to cul_actor everywhereoperations/mediawiki-configmaster+1 -5
Start writing to cul_actor on test wikisoperations/mediawiki-configmaster+4 -0
Start writing to cuc_actor everywhereoperations/mediawiki-configmaster+0 -4
Start writing to cuc_actor on s8operations/mediawiki-configmaster+0 -3
Pin wgCheckUserLogReasonMigrationStage to read and write oldoperations/mediawiki-configmaster+3 -0
Start writing to cuc_actor everywhere except s4 and s8operations/mediawiki-configmaster+8 -4
Start writing to cuc_actor on test wikisoperations/mediawiki-configmaster+3 -0
Send CheckUser the IP address on account creationmediawiki/extensions/AbuseFiltermaster+13 -4
Add population script for cul_actormediawiki/extensions/CheckUsermaster+140 -1
Change cu_log actor migration to write bothmediawiki/extensions/CheckUsermaster+1 -1
Pin cu_log actor migration to old schemaoperations/mediawiki-configmaster+3 -0
Add checkuser log actor migration code for SCHEMA_COMPAT_WRITE_BOTHmediawiki/extensions/CheckUsermaster+35 -5
Add cul_actor to cu_logmediawiki/extensions/CheckUsermaster+333 -2
Add cuc_actor and cuc_comment_id in sqlite aswellmediawiki/extensions/CheckUsermaster+12 -0
Stop writing to cuc_actor on all wikisoperations/mediawiki-configmaster+1 -90
Revert "Start writing to cuc_actor everywhere except s4 and s8"operations/mediawiki-configmaster+82 -0
Start writing to cuc_actor everywhere except s4 and s8operations/mediawiki-configmaster+0 -82
Add CheckUserActorMigration servicemediawiki/extensions/CheckUsermaster+66 -0
Acquire fresh actor idmediawiki/extensions/CheckUserwmf/1.39.0-wmf.12+2 -2
Revert "Revert "Start writing to cuc_actor in s3, kcgwiki and labtestwiki""operations/mediawiki-configmaster+90 -6
Acquire fresh actor idmediawiki/extensions/CheckUserwmf/1.39.0-wmf.13+2 -2
Acquire fresh actor idmediawiki/extensions/CheckUsermaster+2 -2
Revert "Start writing to cuc_actor in s3, kcgwiki and labtestwiki"operations/mediawiki-configmaster+6 -90
Start writing to cuc_actor in s3, kcgwiki and labtestwikioperations/mediawiki-configmaster+90 -6
Start writing to cuc_actor in test wikisoperations/mediawiki-configmaster+3 -0
Revert "Revert "Start writing to cuc_actor in guwwiki and shnwikivoyage""operations/mediawiki-configmaster+2 -0
Acquire fresh actor id for anonsmediawiki/extensions/CheckUsermaster+5 -1
Start writing to cuc_actor in guwwiki and shnwikivoyageoperations/mediawiki-configmaster+2 -0
Add population script for cuc_actormediawiki/extensions/CheckUsermaster+147 -1
Change actor migration to write bothmediawiki/extensions/CheckUsermaster+1 -1
Pin CheckUser actor migration to old schemaoperations/mediawiki-configmaster+5 -0
Use ActorStore to fetch actor idmediawiki/extensions/CheckUsermaster+7 -3
Add actor migration code for SCHEMA_COMPAT_WRITE_BOTHmediawiki/extensions/CheckUsermaster+97 -19
Schema change: Add columns cuc_log_id and ActorMigrate, CommentStore relatedmediawiki/extensions/CheckUsermaster+208 -38
Add actor and comment columns to cu_changesmediawiki/extensions/CheckUsermaster+31 -2
Show related patches Customize query in gerrit

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
ResolvedNoneT227047 Complete actor table and comment table migration
OpenNoneT6716 Edit summary box should be a multiline input
StalledNoneT174043 Deploy Multi-Content Revisions
OpenNoneT174022 Implement multi-content revisions
OpendanielT196087 Refactored implementation of MCR page update interface
OpenNoneT204741 Remove undo and restore functionality from SubmitEntityAction
ResolvedZabeT233004 Update CheckUser for actor and comment table
ResolvedLadsgroupT303603 Add actor and comment columns to cu_changes
ResolvedBUG REPORTZabeT306045 Column 'cuc_actor' cannot be null (localhost) when logging in with incorrect creds
ResolvedPRODUCTION ERRORZabeT309148 Wikimedia\Rdbms\DBQueryError: Error 1048: Column 'cuc_actor' cannot be nullFunction: MediaWiki\CheckUser\Hooks::updateCheckUserDataQuery: INSERT INTO `cu_changes` (cuc_namespace,cuc_title,cuc_minor,cuc_user,cuc_user_text,cuc_
ResolvedDreamy_JazzT309454 cul_reason in cu_log should use the comment table
DeclinedNoneT309982 Add cu_log.cul_reason_id, cu_log.cul_reason_plaintext_id and cu_log.cul_actor to the cu_log table
ResolvedPRODUCTION ERRORZabeT316661 CannotCreateActorException: Cannot create an actor for a usable name that is not an existing user: user_name="Contact Form on Meta"
ResolvedNoneT321391 Add new column cu_log.cul_reason_id and cu_log.cul_reason_plaintext_id to wmf wikis
ResolvedMarosteguiT321126 Add column 'cul_actor' and index cul_actor_time to cu_log on wmf wikis
ResolvedZabeT325484 Run PopulateCulActor on all wikis
ResolvedMarosteguiT326011 Add default values to cul_user and cul_user_text
ResolvedNoneT326330 Update sqoop for CheckUser table
ResolvedZabeT327290 Run PopulateCulComment on all wikis
ResolvedMarosteguiT328086 Drop cul_user and cul_user_text from cu_log on wmf wikis
ResolvedMarosteguiT328236 Add default value to cul_reason on WMF wikis
ResolvedMarosteguiT328373 Drop default value from cul_actor on wmf wikis
ResolvedMarosteguiT328807 Drop cul_reason from cu_log on wmf wikis
ResolvedMarosteguiT328817 Drop cuc_user and cuc_user_text from cu_changes in wmf wikis
ResolvedMarosteguiT328828 Remove default on cul_reason_id and cul_reason_plaintext_id in the cu_log table on wmf wikis
ResolvedDreamy_JazzT328849 Error 1265: Data truncated for column 'cul_reason_id' at row 1
ResolvedBUG REPORTDreamy_JazzT328851 Removal of columns causes sqlite updates that have temporary tables to fail
ResolvedBUG REPORTDreamy_JazzT328855 Removal of columns causes 1.39 postgres updates to fail
ResolvedPRODUCTION ERRORZabeT329151 Wikimedia\Rdbms\DBQueryError: Error 1054: Unknown column 'cul_reason' in 'field list'Function: IndexPager::buildQueryInfo (MediaWiki\CheckUser\CheckUser\Pagers\CheckUserLogPager)Query: SELECT cul_id,cul_timestamp,cul_reason,
ResolvedMarosteguiT329260 Drop cuc_comment from cu_changes in wmf wikis
ResolvedMarosteguiT329684 Drop default value from cuc_actor and cuc_comment_id on wmf wikis
· · ·

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
gerritbot added a comment.Feb 1 2023, 11:36 PM

Change 885908 merged by jenkins-bot:

[operations/mediawiki-config@master] Stop writing to cuc_user and cuc_user_text in group1 wikis

https://gerrit.wikimedia.org/r/885908

Stashbot added a comment.Feb 1 2023, 11:37 PM

Mentioned in SAL (#wikimedia-operations) [2023-02-01T23:37:37Z] <zabe@deploy1002> Started scap: Backport for [[gerrit:885908|Stop writing to cuc_user and cuc_user_text in group1 wikis (T233004)]]

Stashbot added a comment.Feb 1 2023, 11:39 PM

Mentioned in SAL (#wikimedia-operations) [2023-02-01T23:39:28Z] <zabe@deploy1002> zabe: Backport for [[gerrit:885908|Stop writing to cuc_user and cuc_user_text in group1 wikis (T233004)]] synced to the testservers: mwdebug2002.codfw.wmnet, mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug1001.eqiad.wmnet

Stashbot added a comment.Feb 1 2023, 11:45 PM

Mentioned in SAL (#wikimedia-operations) [2023-02-01T23:45:45Z] <zabe@deploy1002> Finished scap: Backport for [[gerrit:885908|Stop writing to cuc_user and cuc_user_text in group1 wikis (T233004)]] (duration: 08m 07s)

gerritbot added a comment.Feb 2 2023, 12:02 AM

Change 885911 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/CheckUser@master] Drop cuc_actor migration code

https://gerrit.wikimedia.org/r/885911

gerritbot added a comment.Feb 2 2023, 6:26 PM

Change 886127 had a related patch set uploaded (by Zabe; author: Zabe):

[operations/mediawiki-config@master] Stop writing to cuc_comment in group1 wikis

https://gerrit.wikimedia.org/r/886127

gerritbot added a comment.Feb 2 2023, 6:34 PM

Change 886127 merged by jenkins-bot:

[operations/mediawiki-config@master] Stop writing to cuc_comment in group1 wikis

https://gerrit.wikimedia.org/r/886127

Stashbot added a comment.Feb 2 2023, 6:34 PM

Mentioned in SAL (#wikimedia-operations) [2023-02-02T18:34:26Z] <zabe@deploy1002> Started scap: Backport for [[gerrit:886127|Stop writing to cuc_comment in group1 wikis (T233004)]]

Stashbot added a comment.Feb 2 2023, 6:36 PM

Mentioned in SAL (#wikimedia-operations) [2023-02-02T18:36:23Z] <zabe@deploy1002> zabe: Backport for [[gerrit:886127|Stop writing to cuc_comment in group1 wikis (T233004)]] synced to the testservers: mwdebug2002.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug1001.eqiad.wmnet

Stashbot added a comment.Feb 2 2023, 6:42 PM

Mentioned in SAL (#wikimedia-operations) [2023-02-02T18:42:45Z] <zabe@deploy1002> Finished scap: Backport for [[gerrit:886127|Stop writing to cuc_comment in group1 wikis (T233004)]] (duration: 08m 19s)

gerritbot added a comment.Feb 2 2023, 6:51 PM

Change 886135 had a related patch set uploaded (by Zabe; author: Zabe):

[operations/mediawiki-config@master] Stop writing to cuc_user and cuc_user_text everywhere

https://gerrit.wikimedia.org/r/886135

gerritbot added a comment.Feb 2 2023, 8:01 PM

Change 886135 merged by jenkins-bot:

[operations/mediawiki-config@master] Stop writing to cuc_user and cuc_user_text everywhere

https://gerrit.wikimedia.org/r/886135

Stashbot added a comment.Feb 2 2023, 8:01 PM

Mentioned in SAL (#wikimedia-operations) [2023-02-02T20:01:29Z] <zabe@deploy1002> Started scap: Backport for [[gerrit:886135|Stop writing to cuc_user and cuc_user_text everywhere (T233004)]]

Stashbot added a comment.Feb 2 2023, 8:03 PM

Mentioned in SAL (#wikimedia-operations) [2023-02-02T20:03:18Z] <zabe@deploy1002> zabe: Backport for [[gerrit:886135|Stop writing to cuc_user and cuc_user_text everywhere (T233004)]] synced to the testservers: mwdebug1001.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2001.codfw.wmnet

Stashbot added a comment.Feb 2 2023, 8:11 PM

Mentioned in SAL (#wikimedia-operations) [2023-02-02T20:11:09Z] <zabe@deploy1002> Finished scap: Backport for [[gerrit:886135|Stop writing to cuc_user and cuc_user_text everywhere (T233004)]] (duration: 09m 39s)

gerritbot added a comment.Feb 2 2023, 8:12 PM

Change 886149 had a related patch set uploaded (by Zabe; author: Zabe):

[operations/mediawiki-config@master] Stop writing to cuc_comment everywhere

https://gerrit.wikimedia.org/r/886149

gerritbot added a comment.Feb 2 2023, 9:05 PM

Change 885359 merged by jenkins-bot:

[operations/mediawiki-config@master] Disable write old for CheckUserLog reason everywhere

https://gerrit.wikimedia.org/r/885359

Stashbot added a comment.Feb 2 2023, 9:06 PM

Mentioned in SAL (#wikimedia-operations) [2023-02-02T21:06:04Z] <brennen@deploy1002> Started scap: Backport for [[gerrit:885359|Disable write old for CheckUserLog reason everywhere (T233004)]]

Stashbot added a comment.Feb 2 2023, 9:07 PM

Mentioned in SAL (#wikimedia-operations) [2023-02-02T21:07:48Z] <brennen@deploy1002> brennen and dreamyjazz: Backport for [[gerrit:885359|Disable write old for CheckUserLog reason everywhere (T233004)]] synced to the testservers: mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2002.codfw.wmnet

Stashbot added a comment.Feb 2 2023, 9:18 PM

Mentioned in SAL (#wikimedia-operations) [2023-02-02T21:18:07Z] <brennen@deploy1002> Finished scap: Backport for [[gerrit:885359|Disable write old for CheckUserLog reason everywhere (T233004)]] (duration: 12m 02s)

gerritbot added a comment.Feb 2 2023, 9:50 PM

Change 886149 merged by jenkins-bot:

[operations/mediawiki-config@master] Stop writing to cuc_comment everywhere

https://gerrit.wikimedia.org/r/886149

Stashbot added a comment.Feb 2 2023, 9:50 PM

Mentioned in SAL (#wikimedia-operations) [2023-02-02T21:50:39Z] <zabe@deploy1002> Started scap: Backport for [[gerrit:886149|Stop writing to cuc_comment everywhere (T233004)]]

Stashbot added a comment.Feb 2 2023, 9:52 PM

Mentioned in SAL (#wikimedia-operations) [2023-02-02T21:52:26Z] <zabe@deploy1002> zabe: Backport for [[gerrit:886149|Stop writing to cuc_comment everywhere (T233004)]] synced to the testservers: mwdebug1002.eqiad.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug2001.codfw.wmnet

Stashbot added a comment.Feb 2 2023, 9:58 PM

Mentioned in SAL (#wikimedia-operations) [2023-02-02T21:58:38Z] <zabe@deploy1002> Finished scap: Backport for [[gerrit:886149|Stop writing to cuc_comment everywhere (T233004)]] (duration: 07m 58s)

gerritbot added a comment.Feb 2 2023, 10:02 PM

Change 886162 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Remove cul_reason comment migration code

https://gerrit.wikimedia.org/r/886162

gerritbot added a comment.Feb 2 2023, 10:24 PM

Change 886165 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Remove cul_reason column from cu_log

https://gerrit.wikimedia.org/r/886165

gerritbot added a comment.Feb 3 2023, 12:48 AM

Change 885911 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Drop cuc_actor migration code

https://gerrit.wikimedia.org/r/885911

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.22; 2023-02-06); removed MW-1.40-notes (1.40.0-wmf.21; 2023-01-30).Feb 3 2023, 1:00 AM
Dreamy_Jazz removed a subtask: T324907: Create separate tables for log events in CheckUser.Feb 3 2023, 1:01 AM
gerritbot added a comment.Feb 3 2023, 1:51 AM

Change 886162 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Remove cul_reason comment table migration code

https://gerrit.wikimedia.org/r/886162

gerritbot added a comment.Feb 3 2023, 8:02 PM

Change 886165 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Remove cul_reason column from cu_log

https://gerrit.wikimedia.org/r/886165

Dreamy_Jazz added a subtask: T328807: Drop cul_reason from cu_log on wmf wikis.Feb 3 2023, 8:27 PM
gerritbot added a comment.Feb 3 2023, 9:09 PM

Change 886426 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/CheckUser@master] Remove cuc_user and cuc_user_text from cu_changes

https://gerrit.wikimedia.org/r/886426

gerritbot added a comment.Feb 3 2023, 11:00 PM

Change 886426 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Remove cuc_user and cuc_user_text from cu_changes

https://gerrit.wikimedia.org/r/886426

gerritbot added a comment.Feb 3 2023, 11:06 PM

Change 886431 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Remove default from cu_log comment table ID fields

https://gerrit.wikimedia.org/r/886431

Zabe added a subtask: T328817: Drop cuc_user and cuc_user_text from cu_changes in wmf wikis.Feb 3 2023, 11:09 PM
gerritbot added a comment.Feb 4 2023, 1:56 AM

Change 886431 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Remove default from cu_log comment table ID fields

https://gerrit.wikimedia.org/r/886431

Dreamy_Jazz added a subtask: T328828: Remove default on cul_reason_id and cul_reason_plaintext_id in the cu_log table on wmf wikis.Feb 4 2023, 2:18 AM
gerritbot added a comment.Feb 4 2023, 8:43 PM

Change 886454 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/CheckUser@master] Drop cuc_comment_id migration variable

https://gerrit.wikimedia.org/r/886454

Dreamy_Jazz added a subtask: T328849: Error 1265: Data truncated for column 'cul_reason_id' at row 1.Feb 4 2023, 9:33 PM
Dreamy_Jazz added a subtask: T328851: Removal of columns causes sqlite updates that have temporary tables to fail.Feb 4 2023, 9:48 PM
Dreamy_Jazz closed subtask T328849: Error 1265: Data truncated for column 'cul_reason_id' at row 1 as Resolved.Feb 4 2023, 11:26 PM
Dreamy_Jazz closed subtask T328851: Removal of columns causes sqlite updates that have temporary tables to fail as Resolved.Feb 5 2023, 12:32 AM
Dreamy_Jazz added a subtask: T328855: Removal of columns causes 1.39 postgres updates to fail.Feb 5 2023, 12:43 AM
gerritbot added a comment.Feb 5 2023, 1:17 AM

Change 886454 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Drop cuc_comment_id migration variable

https://gerrit.wikimedia.org/r/886454

Dreamy_Jazz closed subtask T328855: Removal of columns causes 1.39 postgres updates to fail as Resolved.Feb 5 2023, 1:18 AM
Maintenance_bot removed a project: Patch-For-Review.Feb 5 2023, 1:30 AM
gerritbot added a comment.Feb 5 2023, 1:34 AM

Change 886465 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Remove CheckUserLogCommentStore as cu_log comment migration is done

https://gerrit.wikimedia.org/r/886465

gerritbot added a project: Patch-For-Review.Feb 5 2023, 1:34 AM
gerritbot added a comment.Feb 5 2023, 2:14 AM

Change 886465 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Remove CheckUserLogCommentStore as cu_log comment migration is done

https://gerrit.wikimedia.org/r/886465

Maintenance_bot removed a project: Patch-For-Review.Feb 5 2023, 2:30 AM
gerritbot added a comment.Feb 5 2023, 4:05 PM

Change 886474 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/Flow@master] Use core's CommentStore

https://gerrit.wikimedia.org/r/886474

gerritbot added a project: Patch-For-Review.Feb 5 2023, 4:05 PM

Change 886475 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/CheckUser@master] Remove CheckUserCommentStore as cu_changes comment migration is done

https://gerrit.wikimedia.org/r/886475

gerritbot added a comment.Feb 5 2023, 4:30 PM

Change 886476 had a related patch set uploaded (by Zabe; author: Zabe):

[operations/mediawiki-config@master] stop setting checkuser actor/comment migartion variables

https://gerrit.wikimedia.org/r/886476

gerritbot added a comment.Feb 5 2023, 7:21 PM

Change 886474 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] Use core's CommentStore

https://gerrit.wikimedia.org/r/886474

gerritbot added a comment.Feb 5 2023, 7:21 PM

Change 886475 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Remove CheckUserCommentStore as cu_changes comment migration is done

https://gerrit.wikimedia.org/r/886475

Zabe mentioned this in T329000: +2 in mediawiki/ for Dreamy Jazz.Feb 7 2023, 1:56 AM
• EChetty closed subtask T326330: Update sqoop for CheckUser table as Resolved.Feb 7 2023, 11:10 AM
Zabe added a subtask: T329151: Wikimedia\Rdbms\DBQueryError: Error 1054: Unknown column 'cul_reason' in 'field list'Function: IndexPager::buildQueryInfo (MediaWiki\CheckUser\CheckUser\Pagers\CheckUserLogPager)Query: SELECT cul_id,cul_timestamp,cul_reason,.Feb 8 2023, 10:16 AM
gerritbot added a comment.Feb 8 2023, 10:30 AM

Change 887748 had a related patch set uploaded (by Zabe; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@wmf/1.40.0-wmf.21] Remove cul_reason comment table migration code

https://gerrit.wikimedia.org/r/887748

gerritbot added a comment.Feb 8 2023, 10:49 AM

Change 887748 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@wmf/1.40.0-wmf.21] Remove cul_reason comment table migration code

https://gerrit.wikimedia.org/r/887748

Stashbot added a comment.Feb 8 2023, 10:49 AM

Mentioned in SAL (#wikimedia-operations) [2023-02-08T10:49:46Z] <zabe@deploy1002> Started scap: Backport for [[gerrit:887748|Remove cul_reason comment table migration code (T233004 T329151)]]

Stashbot mentioned this in T329151: Wikimedia\Rdbms\DBQueryError: Error 1054: Unknown column 'cul_reason' in 'field list'Function: IndexPager::buildQueryInfo (MediaWiki\CheckUser\CheckUser\Pagers\CheckUserLogPager)Query: SELECT cul_id,cul_timestamp,cul_reason,.Feb 8 2023, 10:49 AM

Mentioned in SAL (#wikimedia-operations) [2023-02-08T10:51:36Z] <zabe@deploy1002> zabe: Backport for [[gerrit:887748|Remove cul_reason comment table migration code (T233004 T329151)]] synced to the testservers: mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2002.codfw.wmnet

Stashbot added a comment.Feb 8 2023, 10:57 AM

Mentioned in SAL (#wikimedia-operations) [2023-02-08T10:57:52Z] <zabe@deploy1002> Finished scap: Backport for [[gerrit:887748|Remove cul_reason comment table migration code (T233004 T329151)]] (duration: 08m 05s)

Zabe closed subtask T329151: Wikimedia\Rdbms\DBQueryError: Error 1054: Unknown column 'cul_reason' in 'field list'Function: IndexPager::buildQueryInfo (MediaWiki\CheckUser\CheckUser\Pagers\CheckUserLogPager)Query: SELECT cul_id,cul_timestamp,cul_reason, as Resolved.Feb 8 2023, 10:58 AM
Marostegui closed subtask T328807: Drop cul_reason from cu_log on wmf wikis as Resolved.Feb 8 2023, 1:04 PM
Marostegui closed subtask T328828: Remove default on cul_reason_id and cul_reason_plaintext_id in the cu_log table on wmf wikis as Resolved.
gerritbot added a comment.Feb 8 2023, 10:13 PM

Change 887839 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/CheckUser@master] Remove CheckUserActorMigration as cu_changes actor migration is done

https://gerrit.wikimedia.org/r/887839

gerritbot added a comment.Feb 8 2023, 10:39 PM

Change 887844 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/CheckUser@master] Remove cuc_comment from cu_changes

https://gerrit.wikimedia.org/r/887844

gerritbot added a comment.Feb 8 2023, 11:31 PM

Change 887844 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Remove cuc_comment from cu_changes

https://gerrit.wikimedia.org/r/887844

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.23; 2023-02-13); removed MW-1.40-notes (1.40.0-wmf.22; 2023-02-06).Feb 9 2023, 12:00 AM
Zabe added a subtask: T329260: Drop cuc_comment from cu_changes in wmf wikis.Feb 9 2023, 8:49 AM
Dreamy_Jazz added a subtask: T329494: Replace usage of deprecated ActorMigration in AbstractCheckUserPager.Feb 13 2023, 10:45 AM
gerritbot added a comment.Feb 13 2023, 11:06 AM

Change 887839 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Remove CheckUserActorMigration as cu_changes actor migration is done

https://gerrit.wikimedia.org/r/887839

gerritbot added a comment.Feb 13 2023, 10:51 PM

Change 886476 merged by jenkins-bot:

[operations/mediawiki-config@master] stop setting checkuser actor/comment migration variables

https://gerrit.wikimedia.org/r/886476

Stashbot added a comment.Feb 13 2023, 10:51 PM

Mentioned in SAL (#wikimedia-operations) [2023-02-13T22:51:53Z] <zabe@deploy1002> Started scap: Backport for [[gerrit:886476|stop setting checkuser actor/comment migration variables (T233004)]]

Stashbot added a comment.Feb 13 2023, 10:53 PM

Mentioned in SAL (#wikimedia-operations) [2023-02-13T22:53:34Z] <zabe@deploy1002> zabe: Backport for [[gerrit:886476|stop setting checkuser actor/comment migration variables (T233004)]] synced to the testservers: mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet

Stashbot added a comment.Feb 13 2023, 10:59 PM

Mentioned in SAL (#wikimedia-operations) [2023-02-13T22:59:40Z] <zabe@deploy1002> Finished scap: Backport for [[gerrit:886476|stop setting checkuser actor/comment migration variables (T233004)]] (duration: 07m 46s)

gerritbot added a comment.Feb 14 2023, 4:21 PM

Change 889168 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/CheckUser@master] Drop default from cuc_actor and cuc_comment

https://gerrit.wikimedia.org/r/889168

gerritbot added a comment.Feb 14 2023, 6:00 PM

Change 889168 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Drop default from cuc_actor and cuc_comment_id

https://gerrit.wikimedia.org/r/889168

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.24; 2023-02-20); removed MW-1.40-notes (1.40.0-wmf.23; 2023-02-13).Feb 14 2023, 7:00 PM
Zabe closed this task as Resolved.Feb 14 2023, 9:43 PM
Zabe added a subtask: T329684: Drop default value from cuc_actor and cuc_comment_id on wmf wikis.

\o/

Dreamy_Jazz added a comment.Feb 14 2023, 10:03 PM

\o/

Niharika added a subscriber: Niharika.Feb 15 2023, 12:33 AM

\o/

Marostegui closed subtask T328817: Drop cuc_user and cuc_user_text from cu_changes in wmf wikis as Resolved.Mar 9 2023, 6:37 AM
Marostegui closed subtask T329684: Drop default value from cuc_actor and cuc_comment_id on wmf wikis as Resolved.Mar 13 2023, 12:25 PM
Marostegui closed subtask T329260: Drop cuc_comment from cu_changes in wmf wikis as Resolved.Mar 14 2023, 1:15 PM
Izno removed a subtask: T329494: Replace usage of deprecated ActorMigration in AbstractCheckUserPager.Mar 14 2023, 5:50 PM
gerritbot added a comment.Apr 4 2023, 7:51 PM

Change 905732 had a related patch set uploaded (by SBassett; author: Zabe):

[mediawiki/extensions/CheckUser@REL1_40] SECURITY: api: Only add actor table to table list when querying from it

https://gerrit.wikimedia.org/r/905732

gerritbot added a comment.Apr 4 2023, 8:01 PM

Change 905732 abandoned by SBassett:

[mediawiki/extensions/CheckUser@REL1_40] SECURITY: api: Only add actor table to table list when querying from it

Reason:

Already on 1.40

https://gerrit.wikimedia.org/r/905732

Zabe removed a project: Patch-For-Review.May 29 2023, 10:38 PM
Zabe mentioned this in T337703: Requesting access to analytics-privatedata-users for Zabe.
tstarling mentioned this in T312399: Migrate usage of Database::select to SelectQueryBuilder in LoginNotify.Aug 28 2023, 2:34 AM
matej_suchanek mentioned this in T346003: AbuseFilter log entry for automatic account creation shows account name in the log but shows IP in CheckUser.Sep 11 2023, 8:20 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL