Page MenuHomePhabricator

Reconsider enlargement of user info in mobile diff view
Closed, DuplicatePublic

Assigned To
None
Authored By
Ammarpad
Sep 16 2019, 4:11 PM
Referenced Files
F30372615: IMG_20190916_165039_212.jpg
Sep 16 2019, 4:11 PM
F30372624: IMG_20190916_165009_518.jpg
Sep 16 2019, 4:11 PM
F30372644: IMG_20190916_170155_983.jpg
Sep 16 2019, 4:11 PM
F30372540: IMG_20190916_164934_321.jpg
Sep 16 2019, 4:11 PM

Description

The latest deployed changes enlarged the user info viewable in mobile diff to a weird size almost double previous one thus hiding substantial parts of the details if a user is in many user groups or has a long username that can't align with the big thanks button.

Previous sizeEnlarged new size
IMG_20190916_164934_321.jpg (1×720 px, 54 KB)
IMG_20190916_165039_212.jpg (1×720 px, 93 KB)
Implications for users with a lot of user groups.

Note how the edit counts of both users cannot be shown completely because of lack of space (caused by this the recent enlargement). Even some of their user groups had to be truncated, thus giving incomplete information. For instance, the first user is in template-editor group, but it can not be shown now.

User with a long usernameUser with a short username
IMG_20190916_165009_518.jpg (1×720 px, 123 KB)
IMG_20190916_170155_983.jpg (1×720 px, 137 KB)

It's not even clear the benefit of this enlargement and I believe the former size should be restored. If those details are not removed completely they shouldn't be enlarged to this size either.