Page MenuHomePhabricator

ICONS menu alignment and list item spacing
Closed, ResolvedPublic2 Estimated Story Points

Description

Description

@Jdlrobson @Jdrewniak the positioning of the menus is correct, but the vertical spacing between the list items is still too large. I would recommend 0.75em for the vertical padding, e.g.

.toggle-list-item {
    display: block;
    padding: .75em 0.875em;
}

user menuoverflow menu

Developer notes

Updating padding should be self-contained to the menu and not having any side effects so risk feels low here.

Event Timeline

Change 537193 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Correct personal and overflow menu padding and positioning

https://gerrit.wikimedia.org/r/537193

Change 537193 merged by Jdlrobson:
[mediawiki/skins/MinervaNeue@master] Correct personal and overflow menu padding and positioning

https://gerrit.wikimedia.org/r/537193

@Jdlrobson @Jdrewniak the positioning of the menus is correct, but the vertical spacing between the list items is still too large. I would recommend 0.75em for the vertical padding, e.g.

.toggle-list-item {
    display: block;
    padding: .75em 0.875em;
}

Change 537671 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Labels for mw-ui-icon-before elements should be vertically aligned inside

https://gerrit.wikimedia.org/r/537671

Change 537671 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Labels for mw-ui-icon-before elements should be vertically aligned inside

https://gerrit.wikimedia.org/r/537671

Change 538978 had a related patch set uploaded (by Jdrewniak; owner: Jdrewniak):
[mediawiki/skins/MinervaNeue@master] Modify padding on .toggle-list-item

https://gerrit.wikimedia.org/r/538978

Change 538978 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Modify padding on .toggle-list-item

https://gerrit.wikimedia.org/r/538978

ovasileva claimed this task.

Sounds good, resolving

DannyS712 added a subscriber: DannyS712.

[batch] remove patch for review tag from resolved tasks