| • alexhollender_WMF | |
| Sep 16 2019, 8:31 PM |
| F30510003: image.png | |
| Sep 30 2019, 2:40 PM |
| F30381489: image.png | |
| Sep 17 2019, 5:50 PM |
| F30374176: image.png | |
| Sep 16 2019, 8:31 PM |
| F30374241: en.m.wikipedia.beta.wmflabs.org_wiki_9thdecemberchrome(iPhone 6_7_8) (1).png | |
| Sep 16 2019, 8:31 PM |
| F30374190: image.png | |
| Sep 16 2019, 8:31 PM |
@Jdlrobson @Jdrewniak the positioning of the menus is correct, but the vertical spacing between the list items is still too large. I would recommend 0.75em for the vertical padding, e.g.
.toggle-list-item {
display: block;
padding: .75em 0.875em;
}
| user menu | overflow menu |
 |  |
Updating padding should be self-contained to the menu and not having any side effects so risk feels low here.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | ovasileva | T226562 AMC - display labels for toolbar actions on larger screens | |||
| Resolved | • alexhollender_WMF | T229440 [EPIC] Refactor icon sizing in MF/Minerva to achieve consistency | |||
| Resolved | ovasileva | T233050 ICONS menu alignment and list item spacing |
Change 537193 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Correct personal and overflow menu padding and positioning
Change 537193 merged by Jdlrobson:
[mediawiki/skins/MinervaNeue@master] Correct personal and overflow menu padding and positioning
@Jdlrobson @Jdrewniak the positioning of the menus is correct, but the vertical spacing between the list items is still too large. I would recommend 0.75em for the vertical padding, e.g.
.toggle-list-item {
display: block;
padding: .75em 0.875em;
}Change 537671 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Labels for mw-ui-icon-before elements should be vertically aligned inside
Change 537671 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Labels for mw-ui-icon-before elements should be vertically aligned inside
Change 538978 had a related patch set uploaded (by Jdrewniak; owner: Jdrewniak):
[mediawiki/skins/MinervaNeue@master] Modify padding on .toggle-list-item
Change 538978 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Modify padding on .toggle-list-item
