Page MenuHomePhabricator

Show simple error message on filepage when submit fails
Open, Needs TriagePublic

Description

User story: As a Commons user, when I submit structured data for a file and the process fails, I need to see an informative error message so I can fix the problem.

We have this: When the submit() method of the StatementWidget fails, an error message is posted to the DOM for a split second then is removed before the user can read it and the offending element is removed from the page.

We want this: When submit fails, the offending element should remain in place and an error message should be shown to the user explaining what happened and, if applicable, how they can fix it. For the time being, we can show a standard error message above the Publish button as depicted here:

Acceptance Criteria:

  • When the API call to Wikibase fails on publish, the user is informed about what happened and what they should do (come back later, contact someone, fix an error, etc.)

During development, please test the following:

  • Test this feature while logged in AND logged out
  • Test this feature on at least one mobile browser
  • Test that this feature works on the file page only

Details

Related Gerrit Patches:
mediawiki/extensions/WikibaseMediaInfo : masterUpdate error UX on submit
mediawiki/extensions/WikibaseMediaInfo : masterShow submission errors at the statement panel level

Event Timeline

AnneT created this task.Sep 16 2019, 8:38 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 16 2019, 8:38 PM

Here’s a screen recording of this happening to a real user (affected by an IP block due to using a VPN), to give an impression of just how fast the error message vanishes: https://twitter.com/leli_gibts_scho/status/1199843097431171072

Here’s the frame (yes, singular) with the error:

Notice that the “open proxy” part of the block message would probably be quite useful to the user, so I think it should be part of the message informing the user “about what happened and what they should do”.

AnneT claimed this task.Dec 2 2019, 8:40 PM

Thanks very much for passing this along Lucas!

AnneT removed AnneT as the assignee of this task.Dec 2 2019, 8:59 PM
AnneT added a comment.Dec 12 2019, 6:29 PM

Once this patch is deployed, submit errors will print to the page. As discussed in our design/dev meeting today, I'll update the UI a bit to follow foundation design standards and unify the error UX across different scenarios in the following ways:

  • Display error at the top of the statement panel
  • Use default OOUI styles
  • Show inline errors for invalid values

Examples, language pending:

Change 558717 had a related patch set uploaded (by Anne Tomasevich; owner: Anne Tomasevich):
[mediawiki/extensions/WikibaseMediaInfo@master] Show submission errors at the statement panel level

https://gerrit.wikimedia.org/r/558717

Change 558717 abandoned by Anne Tomasevich:
Show submission errors at the statement panel level

Reason:
This super doesn't work

https://gerrit.wikimedia.org/r/558717

Change 559211 had a related patch set uploaded (by Anne Tomasevich; owner: Anne Tomasevich):
[mediawiki/extensions/WikibaseMediaInfo@master] Update error UX on submit

https://gerrit.wikimedia.org/r/559211

Change 559211 merged by Matthias Mullie:
[mediawiki/extensions/WikibaseMediaInfo@master] Update error UX on submit

https://gerrit.wikimedia.org/r/559211